* [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files
@ 2014-09-27 16:29 Bernd Kuhls
2014-10-29 22:40 ` Thomas Petazzoni
2014-11-22 19:11 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Bernd Kuhls @ 2014-09-27 16:29 UTC (permalink / raw)
To: buildroot
This is a follow-up patch for
http://git.buildroot.net/buildroot/commit/package/openssl/openssl.mk?id=c130c5d4635e2a4c7338161953152faf8fca07c4
Fixes
http://autobuild.buildroot.net/results/358/35899961b6dc01c1522b17f63946da5ab809bff8/
http://autobuild.buildroot.net/results/c86/c865214e74dd3766b6343ef73c666fa89c0b5dec/
http://autobuild.buildroot.net/results/fc1/fc12e88fb789e2b68d427c37f39789954309b05d/
http://autobuild.buildroot.net/results/f4d/f4deef4e7d2e2cf5fbc9ce5f02289b4dc60cd23b/
http://autobuild.buildroot.net/results/dfd/dfd81f1f1f0f315317b2a85d24b286a277ac7c16/
http://autobuild.buildroot.net/results/918/9188fc9a63d880cac28c5a9a246ca5504dd11bb2/
http://autobuild.buildroot.net/results/dd1/dd1c326345f8f9c8b5838601ace19002f5360bb2/
http://autobuild.buildroot.net/results/27b/27b4544c59166a9f40092403ed3f530190544a82/
http://autobuild.buildroot.net/results/c37/c37022e334d763bad2a59f7311b93504a569b2dd/
http://autobuild.buildroot.net/results/e89/e89265937a6b4808b817be16bcab79bae4a9aed1/
http://autobuild.buildroot.net/results/4a2/4a222a40d627fda6e49714b13b4321d62c9c2e51/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/openssl/openssl.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
index 4911034..4800bea 100644
--- a/package/openssl/openssl.mk
+++ b/package/openssl/openssl.mk
@@ -118,6 +118,8 @@ endef
# libdl has no business in a static build
ifeq ($(BR2_PREFER_STATIC_LIB),y)
define OPENSSL_FIXUP_STATIC_PKGCONFIG
+ $(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/libcrypto.pc
+ $(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/libssl.pc
$(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/openssl.pc
endef
OPENSSL_POST_INSTALL_STAGING_HOOKS += OPENSSL_FIXUP_STATIC_PKGCONFIG
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files
2014-09-27 16:29 [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files Bernd Kuhls
@ 2014-10-29 22:40 ` Thomas Petazzoni
2014-10-29 22:48 ` Bernd Kuhls
2014-10-31 21:39 ` Bernd Kuhls
2014-11-22 19:11 ` Thomas Petazzoni
1 sibling, 2 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-10-29 22:40 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Sat, 27 Sep 2014 18:29:03 +0200, Bernd Kuhls wrote:
> This is a follow-up patch for
> http://git.buildroot.net/buildroot/commit/package/openssl/openssl.mk?id=c130c5d4635e2a4c7338161953152faf8fca07c4
>
> Fixes
> http://autobuild.buildroot.net/results/358/35899961b6dc01c1522b17f63946da5ab809bff8/
> http://autobuild.buildroot.net/results/c86/c865214e74dd3766b6343ef73c666fa89c0b5dec/
> http://autobuild.buildroot.net/results/fc1/fc12e88fb789e2b68d427c37f39789954309b05d/
> http://autobuild.buildroot.net/results/f4d/f4deef4e7d2e2cf5fbc9ce5f02289b4dc60cd23b/
> http://autobuild.buildroot.net/results/dfd/dfd81f1f1f0f315317b2a85d24b286a277ac7c16/
> http://autobuild.buildroot.net/results/918/9188fc9a63d880cac28c5a9a246ca5504dd11bb2/
> http://autobuild.buildroot.net/results/dd1/dd1c326345f8f9c8b5838601ace19002f5360bb2/
> http://autobuild.buildroot.net/results/27b/27b4544c59166a9f40092403ed3f530190544a82/
> http://autobuild.buildroot.net/results/c37/c37022e334d763bad2a59f7311b93504a569b2dd/
> http://autobuild.buildroot.net/results/e89/e89265937a6b4808b817be16bcab79bae4a9aed1/
> http://autobuild.buildroot.net/results/4a2/4a222a40d627fda6e49714b13b4321d62c9c2e51/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/openssl/openssl.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
> index 4911034..4800bea 100644
> --- a/package/openssl/openssl.mk
> +++ b/package/openssl/openssl.mk
> @@ -118,6 +118,8 @@ endef
> # libdl has no business in a static build
> ifeq ($(BR2_PREFER_STATIC_LIB),y)
> define OPENSSL_FIXUP_STATIC_PKGCONFIG
> + $(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/libcrypto.pc
> + $(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/libssl.pc
> $(SED) 's/-ldl//' $(STAGING_DIR)/usr/lib/pkgconfig/openssl.pc
> endef
> OPENSSL_POST_INSTALL_STAGING_HOOKS += OPENSSL_FIXUP_STATIC_PKGCONFIG
Is this patch still needed? According to
http://autobuild.buildroot.org/?reason=libcurl-7.37.1, the problem
doesn't seem to have appeared since September, 2nd. With just a simple
Blackfin FLAT config with openssl and libcurl enabled, I didn't
reproduce it:
BR2_bfin=y
BR2_BINFMT_FLAT=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_OPENSSL=y
BR2_PACKAGE_LIBCURL=y
# BR2_TARGET_ROOTFS_TAR is not set
Is there some other package needed in the game to reproduce the issue?
Or was the issue fixed as a side effect of some other change (the
libssl.pc and libcrypto.pc still have -ldl in their Libs.private).
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files
2014-10-29 22:40 ` Thomas Petazzoni
@ 2014-10-29 22:48 ` Bernd Kuhls
2014-10-31 21:39 ` Bernd Kuhls
1 sibling, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2014-10-29 22:48 UTC (permalink / raw)
To: buildroot
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141029234038.7f3d1c11 at free-electrons.com:
> Is this patch still needed? According to
> http://autobuild.buildroot.org/?reason=libcurl-7.37.1, the problem
> doesn't seem to have appeared since September, 2nd.
Hi,
we are at 7.38.0 now ;) and the error is still reported by the autobuilders:
http://autobuild.buildroot.net/?reason=libcurl-7.38.0
I will try to reproduce the bug using your defconfig in the near future.
Regards, Bernd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files
2014-10-29 22:40 ` Thomas Petazzoni
2014-10-29 22:48 ` Bernd Kuhls
@ 2014-10-31 21:39 ` Bernd Kuhls
1 sibling, 0 replies; 5+ messages in thread
From: Bernd Kuhls @ 2014-10-31 21:39 UTC (permalink / raw)
To: buildroot
[posted and mailed]
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141029234038.7f3d1c11 at free-electrons.com:
> Is there some other package needed in the game to reproduce the issue?
Hi,
yes, libssh2 is also needed to trigger the bug, but openssl is the package to
be fixed. Please try with this defconfig:
BR2_bfin=y
BR2_BINFMT_FLAT=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_LIBSSH2=y
BR2_PACKAGE_OPENSSL=y
BR2_PACKAGE_LIBCURL=y
# BR2_TARGET_ROOTFS_TAR is not set
Regards, Bernd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files
2014-09-27 16:29 [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files Bernd Kuhls
2014-10-29 22:40 ` Thomas Petazzoni
@ 2014-11-22 19:11 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-11-22 19:11 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Sat, 27 Sep 2014 18:29:03 +0200, Bernd Kuhls wrote:
> This is a follow-up patch for
> http://git.buildroot.net/buildroot/commit/package/openssl/openssl.mk?id=c130c5d4635e2a4c7338161953152faf8fca07c4
>
> Fixes
> http://autobuild.buildroot.net/results/358/35899961b6dc01c1522b17f63946da5ab809bff8/
> http://autobuild.buildroot.net/results/c86/c865214e74dd3766b6343ef73c666fa89c0b5dec/
> http://autobuild.buildroot.net/results/fc1/fc12e88fb789e2b68d427c37f39789954309b05d/
> http://autobuild.buildroot.net/results/f4d/f4deef4e7d2e2cf5fbc9ce5f02289b4dc60cd23b/
> http://autobuild.buildroot.net/results/dfd/dfd81f1f1f0f315317b2a85d24b286a277ac7c16/
> http://autobuild.buildroot.net/results/918/9188fc9a63d880cac28c5a9a246ca5504dd11bb2/
> http://autobuild.buildroot.net/results/dd1/dd1c326345f8f9c8b5838601ace19002f5360bb2/
> http://autobuild.buildroot.net/results/27b/27b4544c59166a9f40092403ed3f530190544a82/
> http://autobuild.buildroot.net/results/c37/c37022e334d763bad2a59f7311b93504a569b2dd/
> http://autobuild.buildroot.net/results/e89/e89265937a6b4808b817be16bcab79bae4a9aed1/
> http://autobuild.buildroot.net/results/4a2/4a222a40d627fda6e49714b13b4321d62c9c2e51/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/openssl/openssl.mk | 2 ++
> 1 file changed, 2 insertions(+)
Applied to master, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-22 19:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-27 16:29 [Buildroot] [PATCH 1/1] package/openssl: drop libdl from more pc files Bernd Kuhls
2014-10-29 22:40 ` Thomas Petazzoni
2014-10-29 22:48 ` Bernd Kuhls
2014-10-31 21:39 ` Bernd Kuhls
2014-11-22 19:11 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox