[Buildroot] [PATCH 1/1] package/nfs-utils: Fix static build

[Buildroot] [PATCH 1/1] package/nfs-utils: Fix static build

[Bernd Kuhls]

Fixes
http://autobuild.buildroot.net/results/17d/17d1d94e6f1617851e374f4fe9804f1e5ea9e99f/
http://autobuild.buildroot.net/results/c08/c08b7be40c8f208147a4f95ad897e4a1df7e108d/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/nfs-utils/nfs-utils.mk |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 522e790..4049024 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -29,6 +29,9 @@ NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 NFS_UTILS_CONF_OPTS += --enable-tirpc --with-tirpcinclude=$(STAGING_DIR)/usr/include/tirpc/
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+NFS_UTILS_CONF_ENV += LIBS="-lpthread"
+endif
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
 NFS_UTILS_CONF_OPTS += --disable-tirpc
-- 
1.7.10.4

[Buildroot] [PATCH 1/1] package/nfs-utils: Fix static build

[Bernd Kuhls]

Bernd Kuhls <bernd.kuhls@t-online.de> wrote in 
news:1416748839-5316-1-git-send-email-bernd.kuhls at t-online.de:

> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +NFS_UTILS_CONF_ENV += LIBS="-lpthread"
> +endif

Hi,

lol, Yann and I had the same thought, but his patch is better, therefore I 
marked mine as superseded in patchworks ;)

Regards, Bernd

[Buildroot] [PATCH 1/1] package/nfs-utils: Fix static build

[Yann E. MORIN]

Bernd, All!

On 2014-11-23 14:26 +0100, Bernd Kuhls spake thusly:
> Bernd Kuhls <bernd.kuhls@t-online.de> wrote in 
> news:1416748839-5316-1-git-send-email-bernd.kuhls at t-online.de:
> > +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> > +NFS_UTILS_CONF_ENV += LIBS="-lpthread"
> > +endif
> 
> lol,

Indeed! That's pretty funny! :-)

> Yann and I had the same thought, but his patch is better, therefore I 
> marked mine as superseded in patchworks ;)

However, your patch is much simpler, and might be considered sufficient
for the release.

So I would not have been so prompt as to mark it in Patchwork.

Peter, Thomas, what's your preference?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/nfs-utils: fix static build

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/f17/f17a554c86f0b24327b49fdc75612cc133f129ed/

f9dc4bab9f4576eed3a22ca7517bfc88d9812c34 bumped nfs-utils to version
2.6.3 which includes the addition of the two files patched here.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
After trying for an hour to register an account upstream I gave up
because all my public mail accounts were rejected. So I was unable to
send the patch upstream.

 ...-guard-dlfcn.h-include-with-HAVE_DLF.patch | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch

diff --git a/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
new file mode 100644
index 0000000000..3af4b75623
--- /dev/null
+++ b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
@@ -0,0 +1,44 @@
+From 274e4d212c30183242e48b639889865819f3ac33 Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd.kuhls@t-online.de>
+Date: Sun, 11 Jun 2023 08:57:11 +0200
+Subject: [PATCH] support/reexport: guard dlfcn.h include with HAVE_DLFCN_H
+
+Upstream: pending upload
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+---
+ support/reexport/fsidd.c    | 2 ++
+ support/reexport/reexport.c | 2 ++
+ 2 files changed, 4 insertions(+)
+
+diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
+index 37649d06..d4b245e8 100644
+--- a/support/reexport/fsidd.c
++++ b/support/reexport/fsidd.c
+@@ -3,7 +3,9 @@
+ #endif
+ 
+ #include <assert.h>
++#ifdef HAVE_DLFCN_H
+ #include <dlfcn.h>
++#endif
+ #include <event2/event.h>
+ #include <limits.h>
+ #include <stdint.h>
+diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
+index d597a2f7..d9a700af 100644
+--- a/support/reexport/reexport.c
++++ b/support/reexport/reexport.c
+@@ -2,7 +2,9 @@
+ #include <config.h>
+ #endif
+ 
++#ifdef HAVE_DLFCN_H
+ #include <dlfcn.h>
++#endif
+ #include <stdint.h>
+ #include <stdio.h>
+ #include <sys/random.h>
+-- 
+2.39.2
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nfs-utils: fix static build

[Giulio Benetti]

Hi Bernd,

> Il giorno 11 giu 2023, alle ore 09:52, Bernd Kuhls <bernd.kuhls@t-online.de> ha scritto:
> 
> Fixes:
> http://autobuild.buildroot.net/results/f17/f17a554c86f0b24327b49fdc75612cc133f129ed/
> 
> f9dc4bab9f4576eed3a22ca7517bfc88d9812c34 bumped nfs-utils to version
> 2.6.3 which includes the addition of the two files patched here.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> After trying for an hour to register an account upstream I gave up
> because all my public mail accounts were rejected. So I was unable to
> send the patch upstream.

Thanks a lot for providing such patch. I will send it to their Mailing List after giving a try.
Last days I’ve seen their git repo down too and in general it’s unstable.

Giulio

> 
> ...-guard-dlfcn.h-include-with-HAVE_DLF.patch | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> 
> diff --git a/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> new file mode 100644
> index 0000000000..3af4b75623
> --- /dev/null
> +++ b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> @@ -0,0 +1,44 @@
> +From 274e4d212c30183242e48b639889865819f3ac33 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd.kuhls@t-online.de>
> +Date: Sun, 11 Jun 2023 08:57:11 +0200
> +Subject: [PATCH] support/reexport: guard dlfcn.h include with HAVE_DLFCN_H
> +
> +Upstream: pending upload
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +---
> + support/reexport/fsidd.c    | 2 ++
> + support/reexport/reexport.c | 2 ++
> + 2 files changed, 4 insertions(+)
> +
> +diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
> +index 37649d06..d4b245e8 100644
> +--- a/support/reexport/fsidd.c
> ++++ b/support/reexport/fsidd.c
> +@@ -3,7 +3,9 @@
> + #endif
> + 
> + #include <assert.h>
> ++#ifdef HAVE_DLFCN_H
> + #include <dlfcn.h>
> ++#endif
> + #include <event2/event.h>
> + #include <limits.h>
> + #include <stdint.h>
> +diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
> +index d597a2f7..d9a700af 100644
> +--- a/support/reexport/reexport.c
> ++++ b/support/reexport/reexport.c
> +@@ -2,7 +2,9 @@
> + #include <config.h>
> + #endif
> + 
> ++#ifdef HAVE_DLFCN_H
> + #include <dlfcn.h>
> ++#endif
> + #include <stdint.h>
> + #include <stdio.h>
> + #include <sys/random.h>
> +-- 
> +2.39.2
> +
> -- 
> 2.39.2
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/nfs-utils: fix static build

[Giulio Benetti]

Hi Bernd,

thanks again,

On 11/06/23 09:51, Bernd Kuhls wrote:
> Fixes:
> http://autobuild.buildroot.net/results/f17/f17a554c86f0b24327b49fdc75612cc133f129ed/
> 
> f9dc4bab9f4576eed3a22ca7517bfc88d9812c34 bumped nfs-utils to version
> 2.6.3 which includes the addition of the two files patched here.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

> ---
> After trying for an hour to register an account upstream I gave up
> because all my public mail accounts were rejected. So I was unable to
> send the patch upstream.

I've sent the patch upstream:
https://marc.info/?l=linux-nfs&m=168650558019402&w=2

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas

>   ...-guard-dlfcn.h-include-with-HAVE_DLF.patch | 44 +++++++++++++++++++
>   1 file changed, 44 insertions(+)
>   create mode 100644 package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> 
> diff --git a/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> new file mode 100644
> index 0000000000..3af4b75623
> --- /dev/null
> +++ b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch
> @@ -0,0 +1,44 @@
> +From 274e4d212c30183242e48b639889865819f3ac33 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd.kuhls@t-online.de>
> +Date: Sun, 11 Jun 2023 08:57:11 +0200
> +Subject: [PATCH] support/reexport: guard dlfcn.h include with HAVE_DLFCN_H
> +
> +Upstream: pending upload
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +---
> + support/reexport/fsidd.c    | 2 ++
> + support/reexport/reexport.c | 2 ++
> + 2 files changed, 4 insertions(+)
> +
> +diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
> +index 37649d06..d4b245e8 100644
> +--- a/support/reexport/fsidd.c
> ++++ b/support/reexport/fsidd.c
> +@@ -3,7 +3,9 @@
> + #endif
> +
> + #include <assert.h>
> ++#ifdef HAVE_DLFCN_H
> + #include <dlfcn.h>
> ++#endif
> + #include <event2/event.h>
> + #include <limits.h>
> + #include <stdint.h>
> +diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
> +index d597a2f7..d9a700af 100644
> +--- a/support/reexport/reexport.c
> ++++ b/support/reexport/reexport.c
> +@@ -2,7 +2,9 @@
> + #include <config.h>
> + #endif
> +
> ++#ifdef HAVE_DLFCN_H
> + #include <dlfcn.h>
> ++#endif
> + #include <stdint.h>
> + #include <stdio.h>
> + #include <sys/random.h>
> +--
> +2.39.2
> +

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot