Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/1] (node.js) fix npm CC, other npm tweaks
Date: Sun, 23 Nov 2014 21:46:25 +0100	[thread overview]
Message-ID: <20141123214625.619c57da@free-electrons.com> (raw)
In-Reply-To: <1416775178-13738-1-git-send-email-mwei@cs.ucsd.edu>

Dear Michael Wei,

On Sun, 23 Nov 2014 12:39:37 -0800, Michael Wei wrote:
> For some reason, node modules with native code (compiled using tools
> like gyp) were not being cross compiled properly without the
> --target_arch switch.
> 
> In addition, the version of npm that is provided with the version of
> node uses is old, and has some bugs like race conditions in dependency
> resolution which can break builds, so this patch also updates the 
> host npm before install.
> 
> Finally, node modules are now installed globally. This allows modules
> to install things such as command line utilities.

Thanks for this contribution. Could you include this detailed
explanation into the commit log of the patch?

Currently, the detailed explanation is only part of the cover letter,
which will not become part of the Buildroot commit history. It would
therefore be better to have the same explanation inside the patch
itself, so that it will become part of the Buildroot commit history.

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2014-11-23 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23 20:39 [Buildroot] [PATCH 0/1] (node.js) fix npm CC, other npm tweaks Michael Wei
2014-11-23 20:39 ` [Buildroot] [PATCH 1/1] Fix npm module cross compilation, use up-to-date npm and install modules globally Michael Wei
2014-11-26 21:42   ` Thomas Petazzoni
2014-11-27  8:08     ` Michael Wei
2015-07-12 22:09   ` Thomas Petazzoni
     [not found]     ` <1436858924.2564.14.camel@posteo.de>
2015-07-14  7:44       ` Thomas Petazzoni
2014-11-23 20:46 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141123214625.619c57da@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox