From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix npm module cross compilation, use up-to-date npm and install modules globally
Date: Tue, 14 Jul 2015 09:44:50 +0200 [thread overview]
Message-ID: <20150714094450.49189293@free-electrons.com> (raw)
In-Reply-To: <1436858924.2564.14.camel@posteo.de>
Dear J?rg Krause,
On Tue, 14 Jul 2015 09:28:44 +0200, J?rg Krause wrote:
> I replied to the patch on 15 Dec 2014 [1], but the mail was not added
> to the thread.
>
> In short: The patch does not work as intended.
>
> There was indeed an issue with cross-compilation for certain modules
> (eg serialport) which was fixed by Martin Bark [1].
>
> I would suggest to mark this patch as Rejected.
Thanks a lot for the feedback! We already marked the patch as Changes
Requested, which makes it no longer visible to us in the list of
pending patches, so that's good enough.
Again, thanks for the feedback.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-14 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 20:39 [Buildroot] [PATCH 0/1] (node.js) fix npm CC, other npm tweaks Michael Wei
2014-11-23 20:39 ` [Buildroot] [PATCH 1/1] Fix npm module cross compilation, use up-to-date npm and install modules globally Michael Wei
2014-11-26 21:42 ` Thomas Petazzoni
2014-11-27 8:08 ` Michael Wei
2015-07-12 22:09 ` Thomas Petazzoni
[not found] ` <1436858924.2564.14.camel@posteo.de>
2015-07-14 7:44 ` Thomas Petazzoni [this message]
2014-11-23 20:46 ` [Buildroot] [PATCH 0/1] (node.js) fix npm CC, other npm tweaks Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714094450.49189293@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox