[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Bernd Kuhls]

minidlna triggers the _gp bug:
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/77875/

"Fixes"
http://autobuild.buildroot.net/results/712/71230ee530a41b3611cd4526f0f010f9c2ef25eb/
http://autobuild.buildroot.net/results/79c/79cbae4dab3ad712bc20c752fdd91e168eade9fe/
http://autobuild.buildroot.net/results/df7/df7da91985a7bf2b05093bae7379ef22362a44fc/
and many others

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/minidlna/Config.in |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/minidlna/Config.in b/package/minidlna/Config.in
index 5c5306d..c0620d5 100644
--- a/package/minidlna/Config.in
+++ b/package/minidlna/Config.in
@@ -14,6 +14,8 @@ config BR2_PACKAGE_MINIDLNA
 	select BR2_PACKAGE_LIBJPEG
 	select BR2_PACKAGE_SQLITE
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
+	# Triggers the _gp link issue
+	depends on !BR2_nios2
 	help
 	  MiniDLNA (aka ReadyDLNA) is server software with the aim of being
 	  fully compliant with DLNA/UPnP-AV clients.
-- 
1.7.10.4

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Yann E. MORIN]

Bernd, All,

On 2014-11-29 19:56 +0100, Bernd Kuhls spake thusly:
> minidlna triggers the _gp bug:
> http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/77875/
> 
> "Fixes"
> http://autobuild.buildroot.net/results/712/71230ee530a41b3611cd4526f0f010f9c2ef25eb/
> http://autobuild.buildroot.net/results/79c/79cbae4dab3ad712bc20c752fdd91e168eade9fe/
> http://autobuild.buildroot.net/results/df7/df7da91985a7bf2b05093bae7379ef22362a44fc/
> and many others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/minidlna/Config.in |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/minidlna/Config.in b/package/minidlna/Config.in
> index 5c5306d..c0620d5 100644
> --- a/package/minidlna/Config.in
> +++ b/package/minidlna/Config.in
> @@ -14,6 +14,8 @@ config BR2_PACKAGE_MINIDLNA
>  	select BR2_PACKAGE_LIBJPEG
>  	select BR2_PACKAGE_SQLITE
>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> +	# Triggers the _gp link issue
> +	depends on !BR2_nios2
>  	help
>  	  MiniDLNA (aka ReadyDLNA) is server software with the aim of being
>  	  fully compliant with DLNA/UPnP-AV clients.
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sat, 29 Nov 2014 19:56:21 +0100, Bernd Kuhls wrote:

> diff --git a/package/minidlna/Config.in b/package/minidlna/Config.in
> index 5c5306d..c0620d5 100644
> --- a/package/minidlna/Config.in
> +++ b/package/minidlna/Config.in
> @@ -14,6 +14,8 @@ config BR2_PACKAGE_MINIDLNA
>  	select BR2_PACKAGE_LIBJPEG
>  	select BR2_PACKAGE_SQLITE
>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> +	# Triggers the _gp link issue
> +	depends on !BR2_nios2

Can we instead please blacklist only the specific NIOS II toolchain
causing the problem?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Bernd Kuhls]

[posted and mailed]

Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:20141130094300.256d43e0 at free-electrons.com:

>> +     # Triggers the _gp link issue
>> +     depends on !BR2_nios2
> 
> Can we instead please blacklist only the specific NIOS II toolchain
> causing the problem?

Hi,

BR2_nios2 does not allow building an internal toolchain and both external 
toolchains supported by buildroot are affected by the problem, so practically 
it makes no difference currently to disable the platform or both toolchains, 
but you are right, there might be a newer toolchain fixing the bug, so I sent 
v2: (and forgot the patch changelog..., arg), v3: 
http://patchwork.ozlabs.org/patch/416036/

Regards, Bernd

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Yann E. MORIN]

Thomas, All,

On 2014-11-30 09:43 +0100, Thomas Petazzoni spake thusly:
> On Sat, 29 Nov 2014 19:56:21 +0100, Bernd Kuhls wrote:
> > diff --git a/package/minidlna/Config.in b/package/minidlna/Config.in
> > index 5c5306d..c0620d5 100644
> > --- a/package/minidlna/Config.in
> > +++ b/package/minidlna/Config.in
> > @@ -14,6 +14,8 @@ config BR2_PACKAGE_MINIDLNA
> >  	select BR2_PACKAGE_LIBJPEG
> >  	select BR2_PACKAGE_SQLITE
> >  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> > +	# Triggers the _gp link issue
> > +	depends on !BR2_nios2
> 
> Can we instead please blacklist only the specific NIOS II toolchain
> causing the problem?

Well, as Bernd says, both toolchains we support exhibit that bug.

And you already did two similar patches, where you just did what Bernd
submitted for minidlna:
  - f287f0aa crda: disable on NIOS II
  - 50d36731 aiccu: not available on NIOS II

So I think it is a bit too much to ask to just blacklist the affected
toolchains, especially since they all are affected, and we can not build
our own.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/minidlna: disable on nios2

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sun, 30 Nov 2014 12:20:49 +0100, Yann E. MORIN wrote:

> > Can we instead please blacklist only the specific NIOS II toolchain
> > causing the problem?
> 
> Well, as Bernd says, both toolchains we support exhibit that bug.
> 
> And you already did two similar patches, where you just did what Bernd
> submitted for minidlna:
>   - f287f0aa crda: disable on NIOS II
>   - 50d36731 aiccu: not available on NIOS II
> 
> So I think it is a bit too much to ask to just blacklist the affected
> toolchains, especially since they all are affected, and we can not build
> our own.

I agree that we may not be doing this properly in other packages.
However, I still believe in such situations that it's better to
blacklist the individual toolchains that are known to be broken, so
that if we add another toolchain, we will be able to see if the same
bug happens as well or not.

Ideally, we should report such bugs to Mentor, but so far, they have
never seem to be really interested by bug reports we could make about
their toolchains.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com