* [Buildroot] [PATCH] package/bdwgc: only enable on supported architectures
@ 2014-12-01 18:10 Yann E. MORIN
2014-12-01 18:13 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2014-12-01 18:10 UTC (permalink / raw)
To: buildroot
bdwgc has support for a sub-set of the architectures we support.
Since there is roughly a 50-50 split of our architectures that have
support in bdwgc vs. those that do not, use a positive dependency logic,
rather than a negative one.
The list was constructed by visual inspection of the source code of
bdwgc, but the header doing the check is, to say it politely, a bit
difficult to read...
So, some working archotectures may be missing. Users needing it may
investigate if their architectures are indeed supported.
Fixes;
http://autobuild.buildroot.net/results/529/529b0b6dd47744c13f56e59a4c669a3f5d56530d/
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Pedro Aguilar <paguilar@paguilar.org>
---
package/bdwgc/Config.in | 7 +++++++
package/bdwgc/bdwgc.mk | 2 ++
package/guile/Config.in | 1 +
3 files changed, 10 insertions(+)
diff --git a/package/bdwgc/Config.in b/package/bdwgc/Config.in
index 9aa7c7d..277b6e4 100644
--- a/package/bdwgc/Config.in
+++ b/package/bdwgc/Config.in
@@ -1,5 +1,12 @@
+config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
+ default y
+ depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
+ || BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \
+ || BR2_sparc || BR2_x86_64
+
config BR2_PACKAGE_BDWGC
bool "bdwgc"
+ depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS
select BR2_PACKAGE_LIBATOMIC_OPS
help
diff --git a/package/bdwgc/bdwgc.mk b/package/bdwgc/bdwgc.mk
index 3e6de1a..b408947 100644
--- a/package/bdwgc/bdwgc.mk
+++ b/package/bdwgc/bdwgc.mk
@@ -4,6 +4,8 @@
#
################################################################################
+# When bumping the version number, check if the list of supported architectures
+# is still valid; see Config.log.
BDWGC_VERSION = 7.2f
BDWGC_SOURCE = gc-$(BDWGC_VERSION).tar.gz
BDWGC_SITE = http://www.hboehm.info/gc/gc_source
diff --git a/package/guile/Config.in b/package/guile/Config.in
index 009dbdf..8f86e9f 100644
--- a/package/guile/Config.in
+++ b/package/guile/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_GUILE
bool "guile"
depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_PACKAGE_BDWGC_ARCH_SUPPORTS # bdwgc
depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS # bdwgc
depends on BR2_USE_WCHAR # libunistring
select BR2_PACKAGE_LIBUNISTRING
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/bdwgc: only enable on supported architectures
2014-12-01 18:10 [Buildroot] [PATCH] package/bdwgc: only enable on supported architectures Yann E. MORIN
@ 2014-12-01 18:13 ` Baruch Siach
2014-12-01 18:16 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2014-12-01 18:13 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Mon, Dec 01, 2014 at 07:10:26PM +0100, Yann E. MORIN wrote:
> diff --git a/package/bdwgc/Config.in b/package/bdwgc/Config.in
> index 9aa7c7d..277b6e4 100644
> --- a/package/bdwgc/Config.in
> +++ b/package/bdwgc/Config.in
> @@ -1,5 +1,12 @@
> +config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
> + default y
> + depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
> + || BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \
s/BR2_MIPSEL/BR2_mipsel/
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/bdwgc: only enable on supported architectures
2014-12-01 18:13 ` Baruch Siach
@ 2014-12-01 18:16 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-12-01 18:16 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2014-12-01 20:13 +0200, Baruch Siach spake thusly:
> On Mon, Dec 01, 2014 at 07:10:26PM +0100, Yann E. MORIN wrote:
> > diff --git a/package/bdwgc/Config.in b/package/bdwgc/Config.in
> > index 9aa7c7d..277b6e4 100644
> > --- a/package/bdwgc/Config.in
> > +++ b/package/bdwgc/Config.in
> > @@ -1,5 +1,12 @@
> > +config BR2_PACKAGE_BDWGC_ARCH_SUPPORTS
> > + default y
> > + depends on BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 \
> > + || BR2_mips || BR2_MIPSEL || BR2_powerpc || BR2_sh \
>
> s/BR2_MIPSEL/BR2_mipsel/
Damned, I forgot to lowercase that one...
How easy it is to read just what one expects, not what is really
written... Cognitive bias? :-]
Thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-01 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-01 18:10 [Buildroot] [PATCH] package/bdwgc: only enable on supported architectures Yann E. MORIN
2014-12-01 18:13 ` Baruch Siach
2014-12-01 18:16 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox