Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] ifplugd: remove spurious newline excape
@ 2014-12-02  6:58 Baruch Siach
  2014-12-02  7:00 ` Baruch Siach
  2014-12-02  8:40 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2014-12-02  6:58 UTC (permalink / raw)
  To: buildroot

Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally)
removed the conditional configuration file install, but left an redundant
newline escape, causing the following error:

package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'.  Stop.

Fix this.

Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/ifplugd/ifplugd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ifplugd/ifplugd.mk b/package/ifplugd/ifplugd.mk
index 03ed8cdf33a2..6b6141e7b8b3 100644
--- a/package/ifplugd/ifplugd.mk
+++ b/package/ifplugd/ifplugd.mk
@@ -24,7 +24,7 @@ define IFPLUGD_INSTALL_FIXUP
 	$(INSTALL) -D -m 0644 $(@D)/conf/ifplugd.conf $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(SED) 's^\(ARGS=.*\)w^\1^' $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
 	$(INSTALL) -D -m 0755 $(@D)/conf/ifplugd.action \
-		$(TARGET_DIR)/etc/ifplugd/ifplugd.action ; \
+		$(TARGET_DIR)/etc/ifplugd/ifplugd.action
 endef
 
 IFPLUGD_POST_INSTALL_TARGET_HOOKS += IFPLUGD_INSTALL_FIXUP
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] ifplugd: remove spurious newline excape
  2014-12-02  6:58 [Buildroot] [PATCH] ifplugd: remove spurious newline excape Baruch Siach
@ 2014-12-02  7:00 ` Baruch Siach
  2014-12-02  8:40 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2014-12-02  7:00 UTC (permalink / raw)
  To: buildroot

Hi Buildroot list,

On Tue, Dec 02, 2014 at 08:58:49AM +0200, Baruch Siach wrote:
> Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally)
> removed the conditional configuration file install, but left an redundant
> newline escape, causing the following error:
> 
> package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'.  Stop.
> 
> Fix this.

In subject: s/excape/escape/

baruch

> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/ifplugd/ifplugd.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/ifplugd/ifplugd.mk b/package/ifplugd/ifplugd.mk
> index 03ed8cdf33a2..6b6141e7b8b3 100644
> --- a/package/ifplugd/ifplugd.mk
> +++ b/package/ifplugd/ifplugd.mk
> @@ -24,7 +24,7 @@ define IFPLUGD_INSTALL_FIXUP
>  	$(INSTALL) -D -m 0644 $(@D)/conf/ifplugd.conf $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
>  	$(SED) 's^\(ARGS=.*\)w^\1^' $(TARGET_DIR)/etc/ifplugd/ifplugd.conf; \
>  	$(INSTALL) -D -m 0755 $(@D)/conf/ifplugd.action \
> -		$(TARGET_DIR)/etc/ifplugd/ifplugd.action ; \
> +		$(TARGET_DIR)/etc/ifplugd/ifplugd.action
>  endef
>  
>  IFPLUGD_POST_INSTALL_TARGET_HOOKS += IFPLUGD_INSTALL_FIXUP

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] ifplugd: remove spurious newline excape
  2014-12-02  6:58 [Buildroot] [PATCH] ifplugd: remove spurious newline excape Baruch Siach
  2014-12-02  7:00 ` Baruch Siach
@ 2014-12-02  8:40 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-12-02  8:40 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Commit 5ad5d55924bcc (ifplugd: install configuration files unconditionally)
 > removed the conditional configuration file install, but left an redundant
 > newline escape, causing the following error:

 > package/ifplugd/ifplugd.mk:23: *** missing 'endef', unterminated 'define'.  Stop.

 > Fix this.

 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed, thanks - And sorry.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-02  8:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02  6:58 [Buildroot] [PATCH] ifplugd: remove spurious newline excape Baruch Siach
2014-12-02  7:00 ` Baruch Siach
2014-12-02  8:40 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox