Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains
@ 2014-12-04 10:18 Nicolas Serafini
  2014-12-06 12:47 ` Thomas Petazzoni
  2014-12-07 21:10 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Serafini @ 2014-12-04 10:18 UTC (permalink / raw)
  To: buildroot

This patch remove a header inclusion that is not required an can create
build error with some toolchains.
The patch is pushed on the upstream for the next release.
http://dev.exiv2.org/issues/1007

Fixes:
http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/

Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
---
 package/exiv2/exiv2-0001-remove-useless-header.patch | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 package/exiv2/exiv2-0001-remove-useless-header.patch

diff --git a/package/exiv2/exiv2-0001-remove-useless-header.patch b/package/exiv2/exiv2-0001-remove-useless-header.patch
new file mode 100644
index 0000000..96a3734
--- /dev/null
+++ b/package/exiv2/exiv2-0001-remove-useless-header.patch
@@ -0,0 +1,19 @@
+version.cpp: remove useless header inclusion
+
+The inclusion of link.h header is not required and can create build
+error with some toolchains.
+The patch is pushed on the upstream for the next release.
+http://dev.exiv2.org/issues/1007
+
+Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
+
+--- exiv2-0.24.orig/src/version.cpp	2013-12-01 13:13:42.000000000 +0100
++++ exiv2-0.24/src/version.cpp	2014-12-04 09:30:39.667234130 +0100
+@@ -116,7 +116,6 @@ typedef string_v::iterator  string_i;
+ #elif defined(__linux__)
+ # include <unistd.h>
+ // http://syprog.blogspot.com/2011/12/listing-loaded-shared-objects-in-linux.html
+-# include "link.h"
+ # include <dlfcn.h>
+   struct something
+   {
-- 
2.1.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains
  2014-12-04 10:18 [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains Nicolas Serafini
@ 2014-12-06 12:47 ` Thomas Petazzoni
  2014-12-07 21:10 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-06 12:47 UTC (permalink / raw)
  To: buildroot

Dear Nicolas Serafini,

On Thu, 4 Dec 2014 11:18:14 +0100, Nicolas Serafini wrote:
> This patch remove a header inclusion that is not required an can create
> build error with some toolchains.
> The patch is pushed on the upstream for the next release.
> http://dev.exiv2.org/issues/1007
> 
> Fixes:
> http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/
> 
> Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
> ---
>  package/exiv2/exiv2-0001-remove-useless-header.patch | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 package/exiv2/exiv2-0001-remove-useless-header.patch

Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I tested that it indeed fixes the Blackfin build failure mentioned in
the commit log. The only minor detail is that the patch is not named
correctly, it should be named 0001-remove-useless-header.patch, and not
exiv2-0001-remove-useless-header.patch, but this can be fixed when
applying Nicolas patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains
  2014-12-04 10:18 [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains Nicolas Serafini
  2014-12-06 12:47 ` Thomas Petazzoni
@ 2014-12-07 21:10 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-07 21:10 UTC (permalink / raw)
  To: buildroot

Dear Nicolas Serafini,

On Thu, 4 Dec 2014 11:18:14 +0100, Nicolas Serafini wrote:
> This patch remove a header inclusion that is not required an can create
> build error with some toolchains.
> The patch is pushed on the upstream for the next release.
> http://dev.exiv2.org/issues/1007
> 
> Fixes:
> http://autobuild.buildroot.net/results/09d/09d9b525eeee458247e10a7948070c00bbabb964/
> 
> Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-07 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 10:18 [Buildroot] [PATCH] exiv2: add patch to fix build error with some toolchains Nicolas Serafini
2014-12-06 12:47 ` Thomas Petazzoni
2014-12-07 21:10 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox