* [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies
@ 2014-12-04 21:11 Romain Naour
2014-12-07 20:36 ` Yann E. MORIN
2014-12-07 21:06 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Romain Naour @ 2014-12-04 21:11 UTC (permalink / raw)
To: buildroot
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/binutils/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/binutils/Config.in b/package/binutils/Config.in
index 50c38b6..fb037ef 100644
--- a/package/binutils/Config.in
+++ b/package/binutils/Config.in
@@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
endif
comment "binutils needs a toolchain w/ wchar"
- depends on !BR2_aarch64 && !BR2_nios2
- depends on BR2_USE_WCHAR
+ depends on !BR2_aarch64 || !BR2_nios2
+ depends on !BR2_USE_WCHAR
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies
2014-12-04 21:11 [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies Romain Naour
@ 2014-12-07 20:36 ` Yann E. MORIN
2014-12-07 21:06 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-12-07 20:36 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2014-12-04 22:11 +0100, Romain Naour spake thusly:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/binutils/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/binutils/Config.in b/package/binutils/Config.in
> index 50c38b6..fb037ef 100644
> --- a/package/binutils/Config.in
> +++ b/package/binutils/Config.in
> @@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
> endif
>
> comment "binutils needs a toolchain w/ wchar"
> - depends on !BR2_aarch64 && !BR2_nios2
> - depends on BR2_USE_WCHAR
> + depends on !BR2_aarch64 || !BR2_nios2
Nope. Architecture dependency must be the same as for the package
symbol, so we must keep the '&&' here, like there is for
BR2_PACKAGE_BINUTILS.
> + depends on !BR2_USE_WCHAR
Yes.
Regards,
Yann E. MORIN.
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies
2014-12-04 21:11 [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies Romain Naour
2014-12-07 20:36 ` Yann E. MORIN
@ 2014-12-07 21:06 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-07 21:06 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Thu, 4 Dec 2014 22:11:02 +0100, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/binutils/Config.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/binutils/Config.in b/package/binutils/Config.in
> index 50c38b6..fb037ef 100644
> --- a/package/binutils/Config.in
> +++ b/package/binutils/Config.in
> @@ -22,5 +22,5 @@ config BR2_PACKAGE_BINUTILS_TARGET
> endif
>
> comment "binutils needs a toolchain w/ wchar"
> - depends on !BR2_aarch64 && !BR2_nios2
> - depends on BR2_USE_WCHAR
> + depends on !BR2_aarch64 || !BR2_nios2
I've kept that one as it was, as explained by Yann.
> + depends on !BR2_USE_WCHAR
Committed, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-07 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 21:11 [Buildroot] [PATCH 1/1] package/binutils: fix comment dependencies Romain Naour
2014-12-07 20:36 ` Yann E. MORIN
2014-12-07 21:06 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox