From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minidlna: fix static linking with OpenSSL enabled
Date: Sun, 7 Dec 2014 22:10:25 +0100 [thread overview]
Message-ID: <20141207211025.GC10809@free.fr> (raw)
In-Reply-To: <1417289292-7006-1-git-send-email-bernd.kuhls@t-online.de>
Bernd, All,
On 2014-11-29 20:28 +0100, Bernd Kuhls spake thusly:
> Fixes
> http://autobuild.buildroot.net/results/c38/c388b71ae154c062a863a35eca70a8c2ce121524/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/minidlna/minidlna.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/minidlna/minidlna.mk b/package/minidlna/minidlna.mk
> index 9e997f3..3a0ca35 100644
> --- a/package/minidlna/minidlna.mk
> +++ b/package/minidlna/minidlna.mk
> @@ -18,7 +18,9 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
> # the configure script / Makefile forgets to link with some of the dependent
> # libraries breaking static linking, so help it along
> MINIDLNA_CONF_ENV = \
> - LIBS='-lavformat -lavcodec -lavutil -logg -lz -lpthread -lm'
> + LIBS='-lavformat -lavcodec -lavutil -logg \
> + $(if $(BR2_PACKAGE_OPENSSL),-lssl -lcrypto) \
> + -lz -lpthread -lm'
I'm not too fond of the way this is handled. I'd prefer we get something
like:
MINIDLNA_LIBS = -lavformat -lavcodec -lavutil -logg
MINIDLAN_LIBS += $(if $(BR2_PACKAGE_OPENSSL),-lssl -lcrypto)
MINIDLAN_LIBS += -lz -lpthread -lm
MINIDLNA_CONF_ENV = LIBS='$(MINIDLNA_LIBS)'
> else
> MINIDLNA_CONF_OPTS = \
> --disable-static
> --
> 1.7.10.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-12-07 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 19:28 [Buildroot] [PATCH 1/1] package/minidlna: fix static linking with OpenSSL enabled Bernd Kuhls
2014-12-07 21:10 ` Yann E. MORIN [this message]
2014-12-07 21:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207211025.GC10809@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox