From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/minidlna: fix static linking with OpenSSL enabled
Date: Sun, 7 Dec 2014 22:52:54 +0100 [thread overview]
Message-ID: <20141207225254.3cc97f02@free-electrons.com> (raw)
In-Reply-To: <20141207211025.GC10809@free.fr>
Dear Yann E. MORIN,
On Sun, 7 Dec 2014 22:10:25 +0100, Yann E. MORIN wrote:
> I'm not too fond of the way this is handled. I'd prefer we get something
> like:
>
> MINIDLNA_LIBS = -lavformat -lavcodec -lavutil -logg
> MINIDLAN_LIBS += $(if $(BR2_PACKAGE_OPENSSL),-lssl -lcrypto)
> MINIDLAN_LIBS += -lz -lpthread -lm
>
> MINIDLNA_CONF_ENV = LIBS='$(MINIDLNA_LIBS)'
Agreed, with maybe "$(MINIDLNA_LIBS)" instead of simple quotes.
A further possible improvement would be to switch to use pkg-config
instead, so that this becomes more maintainable :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-12-07 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 19:28 [Buildroot] [PATCH 1/1] package/minidlna: fix static linking with OpenSSL enabled Bernd Kuhls
2014-12-07 21:10 ` Yann E. MORIN
2014-12-07 21:52 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141207225254.3cc97f02@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox