* [Buildroot] [PATCHv2] qtuio: add error handling to for loop
@ 2014-12-03 22:05 Thomas Petazzoni
2014-12-07 20:44 ` Yann E. MORIN
2014-12-07 20:54 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-03 22:05 UTC (permalink / raw)
To: buildroot
Also remove unneeded sub-shell usage in the build and installation
steps. It is kept for the configure step as it is actually useful, and
works fine because "|| exit 1" is outside the sub-shell.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Changes v1 -> v2:
* Remove unneeded sub-shell usage, noticed by Yann E. Morin.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/qtuio/qtuio.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/qtuio/qtuio.mk b/package/qtuio/qtuio.mk
index 9925f84..5fa10a7 100644
--- a/package/qtuio/qtuio.mk
+++ b/package/qtuio/qtuio.mk
@@ -19,7 +19,7 @@ QTUIO_EXAMPLES = dials fingerpaint knobs pinchzoom
ifeq ($(BR2_QTUIO_EXAMPLES),y)
define QTUIO_CONFIGURE_EXAMPLES
for example in $(QTUIO_EXAMPLES) ; do \
- (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) ; \
+ (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) || exit 1; \
done
endef
endif
@@ -32,7 +32,7 @@ endef
ifeq ($(BR2_QTUIO_EXAMPLES),y)
define QTUIO_BUILD_EXAMPLES
for example in $(QTUIO_EXAMPLES) ; do \
- ($(MAKE) -C $(@D)/examples/$${example}) ; \
+ $(MAKE) -C $(@D)/examples/$${example} || exit 1; \
done
endef
endif
@@ -46,7 +46,7 @@ endef
ifeq ($(BR2_QTUIO_EXAMPLES),y)
define QTUIO_INSTALL_EXAMPLES
for example in $(QTUIO_EXAMPLES) ; do \
- ($(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example}) ; \
+ $(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example} || exit 1 ; \
done
endef
endif
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCHv2] qtuio: add error handling to for loop
2014-12-03 22:05 [Buildroot] [PATCHv2] qtuio: add error handling to for loop Thomas Petazzoni
@ 2014-12-07 20:44 ` Yann E. MORIN
2014-12-07 20:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-12-07 20:44 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2014-12-03 23:05 +0100, Thomas Petazzoni spake thusly:
> Also remove unneeded sub-shell usage in the build and installation
> steps. It is kept for the configure step as it is actually useful, and
> works fine because "|| exit 1" is outside the sub-shell.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Changes v1 -> v2:
> * Remove unneeded sub-shell usage, noticed by Yann E. Morin.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/qtuio/qtuio.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/package/qtuio/qtuio.mk b/package/qtuio/qtuio.mk
> index 9925f84..5fa10a7 100644
> --- a/package/qtuio/qtuio.mk
> +++ b/package/qtuio/qtuio.mk
> @@ -19,7 +19,7 @@ QTUIO_EXAMPLES = dials fingerpaint knobs pinchzoom
> ifeq ($(BR2_QTUIO_EXAMPLES),y)
> define QTUIO_CONFIGURE_EXAMPLES
> for example in $(QTUIO_EXAMPLES) ; do \
> - (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) ; \
> + (cd $(@D)/examples/$${example} && $(TARGET_MAKE_ENV) $(QT_QMAKE)) || exit 1; \
> done
> endef
> endif
> @@ -32,7 +32,7 @@ endef
> ifeq ($(BR2_QTUIO_EXAMPLES),y)
> define QTUIO_BUILD_EXAMPLES
> for example in $(QTUIO_EXAMPLES) ; do \
> - ($(MAKE) -C $(@D)/examples/$${example}) ; \
> + $(MAKE) -C $(@D)/examples/$${example} || exit 1; \
> done
> endef
> endif
> @@ -46,7 +46,7 @@ endef
> ifeq ($(BR2_QTUIO_EXAMPLES),y)
> define QTUIO_INSTALL_EXAMPLES
> for example in $(QTUIO_EXAMPLES) ; do \
> - ($(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example}) ; \
> + $(INSTALL) -D -m 0755 $(@D)/examples/$${example}/$${example} $(TARGET_DIR)/usr/share/qtuio/$${example} || exit 1 ; \
> done
> endef
> endif
> --
> 2.1.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCHv2] qtuio: add error handling to for loop
2014-12-03 22:05 [Buildroot] [PATCHv2] qtuio: add error handling to for loop Thomas Petazzoni
2014-12-07 20:44 ` Yann E. MORIN
@ 2014-12-07 20:54 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-12-07 20:54 UTC (permalink / raw)
To: buildroot
Dear Thomas Petazzoni,
On Wed, 3 Dec 2014 23:05:44 +0100, Thomas Petazzoni wrote:
> Also remove unneeded sub-shell usage in the build and installation
> steps. It is kept for the configure step as it is actually useful, and
> works fine because "|| exit 1" is outside the sub-shell.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Applied.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-07 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 22:05 [Buildroot] [PATCHv2] qtuio: add error handling to for loop Thomas Petazzoni
2014-12-07 20:44 ` Yann E. MORIN
2014-12-07 20:54 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox