* [Buildroot] [PATCH] arch/Config.in: Drop unused BR2_BINFMT_ELF
2014-11-20 9:37 [Buildroot] [PATCH] arch/Config.in: Drop unused BR2_BINFMT_ELF Baruch Siach
@ 2014-11-20 10:25 ` Thomas Petazzoni
2014-12-07 22:34 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-11-20 10:25 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Thu, 20 Nov 2014 11:37:19 +0200, Baruch Siach wrote:
> The BR2_BINFMT_ELF symbol (introduced in commit 57133825c930) can't possibly
> be selected because it depends on (!BR2_bfin && !BR2_m68k), while the
> surrounding choice depends on (BR2_bfin || BR2_m68k). This symbol is never
> used.
>
> Cc: Sonic Zhang <sonic.zhang@analog.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> arch/Config.in | 8 --------
> 1 file changed, 8 deletions(-)
Well, it's true that it's never selected today. However, it can be
useful in a number of situations, with some changes: better support for
static/shared library selection, support for ARM noMMU, etc. For
example, I have one commit in one of my branches that does this:
commit f31d45345e3e260b2942324e43b0a366ec279007
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sat Sep 21 07:31:07 2013 +0200
arch: ensure BR2_BINFMT_ELF is really used
Currently, the binary format choice is only shown for the Blackfin and
m68k architectures, since we assume that all other architectures are
using the ELF binary format. However, due to this, the BR2_BINFMT_ELF
symbol is in fact not set to 'y' for those architectures that use the
ELF format.
This will be causing problems for the refactoring of the static/shared
library support, as we will need to know if the binary format supports
shared libraries or not.
Therefore, it moves out the BR2_BINFMT_ELF option outside of the
choice, ensures it is enabled on all architectures but Blackfin and
m68k, and turns the option within the choice into
BR2_BINFMT_ELF_CHOICE (but in fact this option can never be seen at
the moment, since it depends on !blackfin && !m68k, but the choice it
self depends on blackfin || m68k).
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
diff --git a/arch/Config.in b/arch/Config.in
index 204b543..0a4d36d 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -225,15 +225,20 @@ config BR2_GCC_TARGET_FLOAT_ABI
config BR2_GCC_TARGET_MODE
string
+config BR2_BINFMT_ELF
+ bool
+ default y if !BR2_bfin && !BR2_m68k
+
# Set up target binary format
choice
prompt "Target Binary Format"
depends on BR2_bfin || BR2_m68k
default BR2_BINFMT_FDPIC
-config BR2_BINFMT_ELF
+config BR2_BINFMT_ELF_CHOICE
bool "ELF"
depends on !BR2_bfin && !BR2_m68k
+ select BR2_BINFMT_ELF
help
ELF (Executable and Linkable Format) is a format for libraries and
executables used across different architectures and operating
However, I'm fine with BR2_BINFMT_ELF being removed for now, and
re-added later when actually needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Buildroot] [PATCH] arch/Config.in: Drop unused BR2_BINFMT_ELF
2014-11-20 9:37 [Buildroot] [PATCH] arch/Config.in: Drop unused BR2_BINFMT_ELF Baruch Siach
2014-11-20 10:25 ` Thomas Petazzoni
@ 2014-12-07 22:34 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-12-07 22:34 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2014-11-20 11:37 +0200, Baruch Siach spake thusly:
> The BR2_BINFMT_ELF symbol (introduced in commit 57133825c930) can't possibly
> be selected because it depends on (!BR2_bfin && !BR2_m68k), while the
> surrounding choice depends on (BR2_bfin || BR2_m68k). This symbol is never
> used.
>
> Cc: Sonic Zhang <sonic.zhang@analog.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
As Thomas P. said, he has a series that needs this symbol, and he now
has posted that series to the list:
http://lists.busybox.net/pipermail/buildroot/2014-December/114192.html
So I've marked this patch "Superseded" in Patchowrk.
Thanks!
Regards,
Yann E. MORIN.
> ---
> arch/Config.in | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/Config.in b/arch/Config.in
> index d62d8872b3f3..966046aa4b84 100644
> --- a/arch/Config.in
> +++ b/arch/Config.in
> @@ -257,14 +257,6 @@ choice
> depends on BR2_bfin || BR2_m68k
> default BR2_BINFMT_FDPIC
>
> -config BR2_BINFMT_ELF
> - bool "ELF"
> - depends on !BR2_bfin && !BR2_m68k
> - help
> - ELF (Executable and Linkable Format) is a format for libraries and
> - executables used across different architectures and operating
> - systems.
> -
> config BR2_BINFMT_FDPIC
> bool "FDPIC"
> depends on BR2_bfin || BR2_m68k
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread