[Buildroot] [PATCH] package/mutt: specify the mailpath

[Buildroot] [PATCH] package/mutt: specify the mailpath

[Yann E. MORIN]

mutt's ./configure looks for different paths for where to look for
incoming mails.

This is absolutely worng in the case of cross-compilation, because the
path it may find on the host may not exist on the target.

Not only that, but some host may not even have any of the paths
./configure looks for.

Fix that by specifying the mailpath, and set it to the value documented
in the FHS [0]

Since Buildroot only guarantees /tmp to be writable, make /var/mail a
symlink to /tmp .

[0] http://refspecs.linuxfoundation.org/FHS_2.3/fhs-2.3.html#VARMAILUSERMAILBOXFILES

Reported-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/mutt/mutt.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/mutt/mutt.mk b/package/mutt/mutt.mk
index b4f18b0..92457a1 100644
--- a/package/mutt/mutt.mk
+++ b/package/mutt/mutt.mk
@@ -57,4 +57,11 @@ MUTT_CONF_ENV += \
 	mutt_cv_iconv_good=yes \
 	mutt_cv_iconv_nontrans=no
 
+MUTT_CONF_OPTS += --with-mailpath=/var/mail
+
+define MUTT_VAR_MAIL
+	ln -sf /tmp $(TARGET_DIR)/var/mail
+endef
+MUTT_POST_INSTALL_TARGET_HOOKS += MUTT_VAR_MAIL
+
 $(eval $(autotools-package))
-- 
1.9.1

[Buildroot] [PATCH] package/mutt: specify the mailpath

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sat, 29 Nov 2014 11:55:56 +0100, Yann E. MORIN wrote:
> mutt's ./configure looks for different paths for where to look for
> incoming mails.
> 
> This is absolutely worng in the case of cross-compilation, because the
> path it may find on the host may not exist on the target.
> 
> Not only that, but some host may not even have any of the paths
> ./configure looks for.
> 
> Fix that by specifying the mailpath, and set it to the value documented
> in the FHS [0]
> 
> Since Buildroot only guarantees /tmp to be writable, make /var/mail a
> symlink to /tmp .
> 
> [0] http://refspecs.linuxfoundation.org/FHS_2.3/fhs-2.3.html#VARMAILUSERMAILBOXFILES
> 
> Reported-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/mutt/mutt.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

At this point, I'm not sure if this is still material for master
(2014.11) or for next.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/mutt: specify the mailpath

[Yann E. MORIN]

Thomas, All,

On 2014-11-30 15:15 +0100, Thomas Petazzoni spake thusly:
> On Sat, 29 Nov 2014 11:55:56 +0100, Yann E. MORIN wrote:
> > mutt's ./configure looks for different paths for where to look for
> > incoming mails.
> > 
> > This is absolutely worng in the case of cross-compilation, because the
> > path it may find on the host may not exist on the target.
> > 
> > Not only that, but some host may not even have any of the paths
> > ./configure looks for.
> > 
> > Fix that by specifying the mailpath, and set it to the value documented
> > in the FHS [0]
> > 
> > Since Buildroot only guarantees /tmp to be writable, make /var/mail a
> > symlink to /tmp .
> > 
> > [0] http://refspecs.linuxfoundation.org/FHS_2.3/fhs-2.3.html#VARMAILUSERMAILBOXFILES
> > 
> > Reported-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  package/mutt/mutt.mk | 7 +++++++
> >  1 file changed, 7 insertions(+)
> 
> At this point, I'm not sure if this is still material for master
> (2014.11) or for next.

I don;'t realy care either. It fixes a relatively rare occurence of a
build failure, which happens only in very tightly controlled systems,
and we have had only one report of it since we've been packaging mutt
(that is, the past 7 years!), so I think it can well go in -next.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] package/mutt: specify the mailpath

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sat, 29 Nov 2014 11:55:56 +0100, Yann E. MORIN wrote:
> mutt's ./configure looks for different paths for where to look for
> incoming mails.
> 
> This is absolutely worng in the case of cross-compilation, because the
> path it may find on the host may not exist on the target.
> 
> Not only that, but some host may not even have any of the paths
> ./configure looks for.
> 
> Fix that by specifying the mailpath, and set it to the value documented
> in the FHS [0]
> 
> Since Buildroot only guarantees /tmp to be writable, make /var/mail a
> symlink to /tmp .
> 
> [0] http://refspecs.linuxfoundation.org/FHS_2.3/fhs-2.3.html#VARMAILUSERMAILBOXFILES
> 
> Reported-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com