[Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: rename patches to the new convention

[Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: rename patches to the new convention

[Bernd Kuhls]

Patch 0003 will be extended to fix the blackfin build as well, therefore
it is renamed according to the fixed variable.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 ...atch => 0001-os-log-adjust-gcc-version-conditions-for-pragma.patch} |    0
 ...r_xorg-server-0002-glyphpadbytes.patch => 0002-glyphpadbytes.patch} |    0
 ...r_xorg-server-0003-microblaze.patch => 0003-image-byte-order.patch} |    0
 3 files changed, 0 insertions(+), 0 deletions(-)
 rename package/x11r7/xserver_xorg-server/{xserver_xorg-server-0001-os-log-adjust-gcc-version-conditions-for-pragma.patch => 0001-os-log-adjust-gcc-version-conditions-for-pragma.patch} (100%)
 rename package/x11r7/xserver_xorg-server/{xserver_xorg-server-0002-glyphpadbytes.patch => 0002-glyphpadbytes.patch} (100%)
 rename package/x11r7/xserver_xorg-server/{xserver_xorg-server-0003-microblaze.patch => 0003-image-byte-order.patch} (100%)

diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server-0001-os-log-adjust-gcc-version-conditions-for-pragma.patch b/package/x11r7/xserver_xorg-server/0001-os-log-adjust-gcc-version-conditions-for-pragma.patch
similarity index 100%
rename from package/x11r7/xserver_xorg-server/xserver_xorg-server-0001-os-log-adjust-gcc-version-conditions-for-pragma.patch
rename to package/x11r7/xserver_xorg-server/0001-os-log-adjust-gcc-version-conditions-for-pragma.patch
diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server-0002-glyphpadbytes.patch b/package/x11r7/xserver_xorg-server/0002-glyphpadbytes.patch
similarity index 100%
rename from package/x11r7/xserver_xorg-server/xserver_xorg-server-0002-glyphpadbytes.patch
rename to package/x11r7/xserver_xorg-server/0002-glyphpadbytes.patch
diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server-0003-microblaze.patch b/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
similarity index 100%
rename from package/x11r7/xserver_xorg-server/xserver_xorg-server-0003-microblaze.patch
rename to package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] package/x11r7/xserver_xorg-server: Fix blackfin build

[Bernd Kuhls]

Fixes
http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/

Upstream bug report was updated:
https://bugs.freedesktop.org/show_bug.cgi?id=83582

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xserver_xorg-server/0003-image-byte-order.patch |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch b/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
index b99b669..59e8177 100644
--- a/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
+++ b/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
@@ -1,4 +1,4 @@
-xserver_xorg-server: Fix compile error for microblaze
+xserver_xorg-server: Fix compile error for microblaze/blackfin
 
 Fixes
 mipushpxl.c: In function 'miPushPixels':
@@ -16,7 +16,7 @@ diff -uNr xorg-server-1.16.0.glyph/include/servermd.h xorg-server-1.16.0/include
  
  #endif                          /* mips */
  
-+#if defined(__microblaze__) || defined(microblaze)
++#if defined(__microblaze__) || defined(microblaze) || defined(BFIN)
 +
 +#ifdef __BIG_ENDIAN__
 +#define IMAGE_BYTE_ORDER	MSBFirst
-- 
1.7.10.4

[Buildroot] [PATCH 2/2] package/x11r7/xserver_xorg-server: Fix blackfin build

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Fixes
 > http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
 > http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
 > http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/

These are all the same URL?

 > Upstream bug report was updated:
 > https://bugs.freedesktop.org/show_bug.cgi?id=83582

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 >  package/x11r7/xserver_xorg-server/0003-image-byte-order.patch |    4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch b/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
 > index b99b669..59e8177 100644
 > --- a/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
 > +++ b/package/x11r7/xserver_xorg-server/0003-image-byte-order.patch
 > @@ -1,4 +1,4 @@
 > -xserver_xorg-server: Fix compile error for microblaze
 > +xserver_xorg-server: Fix compile error for microblaze/blackfin
 
 >  Fixes
 >  mipushpxl.c: In function 'miPushPixels':
 > @@ -16,7 +16,7 @@ diff -uNr xorg-server-1.16.0.glyph/include/servermd.h xorg-server-1.16.0/include
  
 >   #endif                          /* mips */
  
 > -+#if defined(__microblaze__) || defined(microblaze)
 > ++#if defined(__microblaze__) || defined(microblaze) || defined(BFIN)

But xserver_xorg-server depends on !BR2_USE_MMU since 7c00cd:

    xorg-server: needs mmu
    
    os/utils.c::System() unconditionally uses fork(), so it only builds on
    configurations with mmu.
    
    (Indirectly) fixes:
    http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
    http://autobuild.buildroot.net/results/d27/d279dc35bff53b7f939af02bee70b1ed3014e49b/
    http://autobuild.buildroot.net/results/84b/84b8f19221a5c841de3016959c99b92c96c57e81/
    
    Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Which even lists the same autobuilder issue you listed about. So what is
the point?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] package/x11r7/xserver_xorg-server: Fix blackfin build

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sat, 29 Nov 2014 22:23:52 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
> http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
> http://autobuild.buildroot.net/results/497/4970352598a68d7af89acbb33cdf69d656e23f4d/
> 
> Upstream bug report was updated:
> https://bugs.freedesktop.org/show_bug.cgi?id=83582
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Seeing the comments made by Peter on your patch, I've marked it as
'Rejected' in patchwork. Please resend an updated version if you think
there is nonetheless something to be fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: rename patches to the new convention

[Thomas Petazzoni]

Dear Bernd Kuhls,

On Sat, 29 Nov 2014 22:23:51 +0100, Bernd Kuhls wrote:
> Patch 0003 will be extended to fix the blackfin build as well, therefore
> it is renamed according to the fixed variable.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com