From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] screen: add support for 256 colors
Date: Tue, 9 Dec 2014 17:57:28 +0200 [thread overview]
Message-ID: <20141209155728.GL2440@tarshish> (raw)
In-Reply-To: <54871795.2010403@imgtec.com>
Hi Vicente, Thierry,
On Tue, Dec 09, 2014 at 03:39:01PM +0000, Vicente Olivert Riera wrote:
> On 12/09/2014 03:26 PM, Thierry Bultel wrote:
>
> > define SCREEN_INSTALL_SCREENRC
> > - $(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc
> > + if [ ! -f $(TARGET_DIR)/etc/screenrc ]; then \
> > + $(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc; \
> > + fi
> > endef
> >
> > SCREEN_POST_INSTALL_TARGET_HOOKS += SCREEN_INSTALL_SCREENRC
>
> This part is not related with adding support for 256 colors, so, why
> don't you send a separate patch for it? Or at least, state in your
> commit message you are fixing a little issue with the 'screenrc' file
> installation. But I would say that a separate patch would be better.
I don't think the change in this separate patch is desired. We have just
recently (commit 963bbf266bfebc [screen: install configuration file
unconditionally]) switched to unconditional install of the config file.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-12-09 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 15:26 [Buildroot] [PATCH 1/1] screen: add support for 256 colors Thierry Bultel
2014-12-09 15:39 ` Vicente Olivert Riera
2014-12-09 15:57 ` Baruch Siach [this message]
2014-12-10 17:37 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209155728.GL2440@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox