From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] screen: add support for 256 colors
Date: Tue, 9 Dec 2014 15:39:01 +0000 [thread overview]
Message-ID: <54871795.2010403@imgtec.com> (raw)
In-Reply-To: <1418138819-19772-1-git-send-email-tbultel@free.fr>
Dear Thierry Bultel,
On 12/09/2014 03:26 PM, Thierry Bultel wrote:
> define SCREEN_INSTALL_SCREENRC
> - $(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc
> + if [ ! -f $(TARGET_DIR)/etc/screenrc ]; then \
> + $(INSTALL) -m 0755 -D $(@D)/etc/screenrc $(TARGET_DIR)/etc/screenrc; \
> + fi
> endef
>
> SCREEN_POST_INSTALL_TARGET_HOOKS += SCREEN_INSTALL_SCREENRC
This part is not related with adding support for 256 colors, so, why
don't you send a separate patch for it? Or at least, state in your
commit message you are fixing a little issue with the 'screenrc' file
installation. But I would say that a separate patch would be better.
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
next prev parent reply other threads:[~2014-12-09 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 15:26 [Buildroot] [PATCH 1/1] screen: add support for 256 colors Thierry Bultel
2014-12-09 15:39 ` Vicente Olivert Riera [this message]
2014-12-09 15:57 ` Baruch Siach
2014-12-10 17:37 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54871795.2010403@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox