Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] mtr: bump to version 0.86 and use github call
Date: Wed, 10 Dec 2014 21:52:07 +0100	[thread overview]
Message-ID: <20141210215207.384d34ea@free-electrons.com> (raw)
In-Reply-To: <1418177637-28038-1-git-send-email-vsergeev@kumunetworks.com>

Dear Ivan Sergeev,

On Tue,  9 Dec 2014 18:13:57 -0800, Ivan Sergeev wrote:
> Signed-off-by: Ivan Sergeev <vsergeev@kumunetworks.com>
> ---
>  package/mtr/mtr.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks, I've applied your patch, after removing the --without-glib
option that is no longer useful.

Also, if you have some time to work on mtr, it would be good to get rid
of the ugly:

# uClibc has res_ninit but not res_nmkquery
ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
define MTR_DISABLE_RES_NINIT
        $(SED) 's/#ifdef res_ninit/#if 0/' \
                $(@D)/dns.c
endef
endif

MTR_POST_PATCH_HOOKS += MTR_DISABLE_RES_NINIT

that we have in package/mtr/mtr.mk. To do this, some improvements to
configure.ac are needed to detect if the C library has res_ninit() and
res_nmkquery(). Feel free to work this out with upstream :-)

Thanks!

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2014-12-10 20:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  2:10 [Buildroot] [PATCH 1/1] mtr: bump to version 0.86 and use github call Ivan Sergeev
2014-12-10  2:13 ` [Buildroot] [PATCH v2 " Ivan Sergeev
2014-12-10 16:37   ` Vicente Olivert Riera
2014-12-10 18:59     ` Thomas Petazzoni
2014-12-10 19:47       ` Vincent Olivert Riera
2014-12-12 21:43     ` Ivan Sergeev
2014-12-10 20:52   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141210215207.384d34ea@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox