From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] mtr: bump to version 0.86 and use github call
Date: Wed, 10 Dec 2014 16:37:12 +0000 [thread overview]
Message-ID: <548876B8.6060104@imgtec.com> (raw)
In-Reply-To: <1418177637-28038-1-git-send-email-vsergeev@kumunetworks.com>
Dear Ivan Sergeev,
just a few things:
On 12/10/2014 02:13 AM, Ivan Sergeev wrote:
> MTR_CONF_OPTS = --without-gtk --without-glib
The '--without-glib' option doesn't exist in the configure script. You
can remove it.
Also, while you are doing the version bump, why not adding a hash file
as well:
http://buildroot.uclibc.org/downloads/manual/manual.html#adding-packages-hash
Could you please mark the previous versions of this patch as
'superseded' in patchwork?
And finally, could you please state what changes you make between versions?
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
next prev parent reply other threads:[~2014-12-10 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 2:10 [Buildroot] [PATCH 1/1] mtr: bump to version 0.86 and use github call Ivan Sergeev
2014-12-10 2:13 ` [Buildroot] [PATCH v2 " Ivan Sergeev
2014-12-10 16:37 ` Vicente Olivert Riera [this message]
2014-12-10 18:59 ` Thomas Petazzoni
2014-12-10 19:47 ` Vincent Olivert Riera
2014-12-12 21:43 ` Ivan Sergeev
2014-12-10 20:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548876B8.6060104@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox