[Buildroot] [buildroot-test 1/2] Taking into account BR2_PREFER_STATIC_LIB rename

[Buildroot] [buildroot-test 1/2] Taking into account BR2_PREFER_STATIC_LIB rename

[Thomas Petazzoni]

In Buildroot, the BR2_PREFER_STATIC_LIB option was renamed to
BR2_STATIC_LIBS. This commit takes this into account when generating
the autobuild configurations.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 scripts/autobuild-run | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 4d9ef90..ce89e1e 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -348,7 +348,7 @@ def gen_config(instance, log, sysinfo):
     elif randint(0, 20) == 0:
         configlines.append("BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y\n")
     if config["libc"] != "glibc" and randint(0, 20) == 0:
-        configlines.append("BR2_PREFER_STATIC_LIB=y\n")
+        configlines.append("BR2_STATIC_LIBS=y\n")
 
     # Write out the configuration file
     with open(os.path.join(outputdir, ".config"), "w+") as configf:
-- 
2.1.0

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Thomas Petazzoni]

Now that Buildroot has support for paranoid path checking (check for
clearly invalid header and library directories used when
cross-compiling), let's enable this in the autobuilders.

Without this, the paranoid path checking only emits warnings. With
this patch enabled, whenever an invalid header or library path is
used, the build will stop and fail, which will allow us to clearly
notice such cases.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Do we want to apply this right now? We already have a lot of failures
caused by the static/shared change. Do we want to have more?

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 scripts/autobuild-run | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index ce89e1e..b27b2fc 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -341,6 +341,7 @@ def gen_config(instance, log, sysinfo):
     # Amend the configuration with a few things.
     configlines.append("BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y\n")
     configlines.append("# BR2_TARGET_ROOTFS_TAR is not set\n")
+    configlines.append("BR2_COMPILER_PARANOID_UNSAFE_PATH=y\n")
     if randint(0, 20) == 0:
         configlines.append("BR2_ENABLE_DEBUG=y\n")
     if randint(0, 30) == 0:
-- 
2.1.0

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Bernd Kuhls]

Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
@public.gmane.org> wrote in news:1418852858-818-2-git-send-email-
thomas.petazzoni at free-electrons.com:

> Do we want to apply this right now? We already have a lot of failures
> caused by the static/shared change. Do we want to have more?
[...]
> +    configlines.append("BR2_COMPILER_PARANOID_UNSAFE_PATH=y\n")

Hi,

I vote for yes.

Regards, Bernd

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Yann E. MORIN]

Thomas, All,

On 2014-12-17 22:47 +0100, Thomas Petazzoni spake thusly:
> Now that Buildroot has support for paranoid path checking (check for
> clearly invalid header and library directories used when
> cross-compiling), let's enable this in the autobuilders.
> 
> Without this, the paranoid path checking only emits warnings. With
> this patch enabled, whenever an invalid header or library path is
> used, the build will stop and fail, which will allow us to clearly
> notice such cases.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Do we want to apply this right now? We already have a lot of failures
> caused by the static/shared change. Do we want to have more?

Well, either we set it right now, so we have time to investigate before
the 2015.02 release, or we post-pone that for after.

We're almost one mont in the release cycle, with a bit more than another
month before rc1, so it might be already too late for the switch, but it
is still doable.

So:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Romain Naour]

Hi Thomas,
Le 17/12/2014 22:47, Thomas Petazzoni a ?crit :
> Now that Buildroot has support for paranoid path checking (check for
> clearly invalid header and library directories used when
> cross-compiling), let's enable this in the autobuilders.
>
> Without this, the paranoid path checking only emits warnings. With
> this patch enabled, whenever an invalid header or library path is
> used, the build will stop and fail, which will allow us to clearly
> notice such cases.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Do we want to apply this right now? We already have a lot of failures
> caused by the static/shared change. Do we want to have more?
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>
Several packages have already been fixed since this feature has been
added. Enabling this check now will help to discover the remaining
packages left to fix.

Acked-by: Romain Naour <romain.naour@openwide.fr>

Best regards,
Romain

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Thomas Petazzoni]

Dear Romain Naour,

On Fri, 26 Dec 2014 18:51:12 +0100, Romain Naour wrote:

> Several packages have already been fixed since this feature has been
> added. Enabling this check now will help to discover the remaining
> packages left to fix.
> 
> Acked-by: Romain Naour <romain.naour@openwide.fr>

The patch has been committed, however the new version of the script has
not yet been deployed on the autobuilders.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [buildroot-test 2/2] Enable paranoid path checking

[Romain Naour]

Hi Thomas,

Le 26/12/2014 19:09, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Fri, 26 Dec 2014 18:51:12 +0100, Romain Naour wrote:
>
>> Several packages have already been fixed since this feature has been
>> added. Enabling this check now will help to discover the remaining
>> packages left to fix.
>>
>> Acked-by: Romain Naour <romain.naour@openwide.fr>
> The patch has been committed, however the new version of the script has
> not yet been deployed on the autobuilders.
>
> Thomas
Ok, thanks.
I thought it was not because I didn't see any failure.

Best regards,
Romain

[Buildroot] [buildroot-test 1/2] Taking into account BR2_PREFER_STATIC_LIB rename

[Thomas Petazzoni]

Hello,

On Wed, 17 Dec 2014 22:47:37 +0100, Thomas Petazzoni wrote:

>      if config["libc"] != "glibc" and randint(0, 20) == 0:
> -        configlines.append("BR2_PREFER_STATIC_LIB=y\n")
> +        configlines.append("BR2_STATIC_LIBS=y\n")

Instead, should I also sometimes test BR2_SHARED_STATIC_LIBS ? Like 5%
of times static only, 5% of times static+shared, and 90% of the time
shared only (the default) ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [buildroot-test 1/2] Taking into account BR2_PREFER_STATIC_LIB rename

[Yann E. MORIN]

Thomas, All,

On 2014-12-21 22:03 +0100, Thomas Petazzoni spake thusly:
> On Wed, 17 Dec 2014 22:47:37 +0100, Thomas Petazzoni wrote:
> >      if config["libc"] != "glibc" and randint(0, 20) == 0:
> > -        configlines.append("BR2_PREFER_STATIC_LIB=y\n")
> > +        configlines.append("BR2_STATIC_LIBS=y\n")
> 
> Instead, should I also sometimes test BR2_SHARED_STATIC_LIBS ? Like 5%
> of times static only, 5% of times static+shared, and 90% of the time
> shared only (the default) ?

Yes.

If there are some packages that do not like to be build both static and
shared at the same time, we want to catch those.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [buildroot-test 1/2] Taking into account BR2_PREFER_STATIC_LIB rename

[Thomas Petazzoni]

Dear Yann E. MORIN,

On Sun, 21 Dec 2014 22:13:58 +0100, Yann E. MORIN wrote:

> If there are some packages that do not like to be build both static and
> shared at the same time, we want to catch those.

I've already pushed my autobuild-run patches, but we can do a followup
patch to implement this.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com