From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/7] Adding libnice
Date: Wed, 31 Dec 2014 17:05:59 +0100 [thread overview]
Message-ID: <20141231170559.12bb9aae@free-electrons.com> (raw)
In-Reply-To: <1418398967-2183-4-git-send-email-gregd72002@gmail.com>
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:43 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
Thanks, I've applied your patch, but after doing a fairly significant
set of changes. As detailed in the commit log:
[Thomas:
- Rename patch to the proper naming convention
- Reduce patch to only take care of the IPv6 case
- Add description in the patch
- Propagate libglib2 dependencies in Config.in + added the
corresponding comment.
- Added a real help text, and fixed the help text indentation.
- Fixed the comment header in the .mk file to have the right number
of # signs.
- Added the license informations
- Added a dependency on host-pkgconf, used by the configure script
- Added --without-gstreamer and --without-gstreamer-0.10 to be
explicit about the fact that we don't support GStreamer in libnice
for now.
- Fixed the hash file to have the proper format.]
See http://git.buildroot.net/buildroot/commit/?id=89502b9d56ad4f06954fae55684ef21525ad2515.
May I suggest you to compare the final commit and your original patch,
so that you can see what the issues were, for your upcoming
contributions?
Thanks a lot!
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-31 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
2014-12-31 17:03 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
2015-01-01 14:07 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
2014-12-31 16:05 ` Thomas Petazzoni [this message]
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
2015-01-01 10:30 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
2015-01-01 11:43 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
2015-01-01 13:52 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
2015-01-01 15:46 ` Thomas Petazzoni
2014-12-12 15:58 ` [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Vicente Olivert Riera
2014-12-12 16:06 ` Gregory Dymarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141231170559.12bb9aae@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox