From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 7/7] Adding janus-gateway
Date: Thu, 1 Jan 2015 16:46:38 +0100 [thread overview]
Message-ID: <20150101164638.66901cd9@free-electrons.com> (raw)
In-Reply-To: <1418398967-2183-8-git-send-email-gregd72002@gmail.com>
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:47 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
> ---
> package/Config.in | 1 +
> package/janus-gateway/Config.in | 13 +++++++++++
> .../janus-gateway-0001-disable-ssp.patch | 12 ++++++++++
> package/janus-gateway/janus-gateway.hash | 1 +
> package/janus-gateway/janus-gateway.mk | 27 ++++++++++++++++++++++
> 5 files changed, 54 insertions(+)
> create mode 100644 package/janus-gateway/Config.in
> create mode 100644 package/janus-gateway/janus-gateway-0001-disable-ssp.patch
> create mode 100644 package/janus-gateway/janus-gateway.hash
> create mode 100644 package/janus-gateway/janus-gateway.mk
Thanks, applied, with a number of changes:
[Thomas:
- Rename patch to the proper naming convention, and add a
description to it.
- Add mandatory dependency to OpenSSL.
- Make the dependency on libwebsock optional.
- Remove select of host-gengetopt, since this package no longer has
a menuconfig option.
- Add missing toolchain option dependencies inherited from selected
packages.
- Add proper Config.in help text.
- Fix the .mk comment header to the proper format.
- Use the github function and remove the unneeded SITE_METHOD
variable.
- Add support for optional Opus and Libogg support.
- Remove hash file, since the package is fetched from github.]
See the final commit at
http://git.buildroot.net/buildroot/commit/?id=f95c7e6fb9c0cf30eb769a8f0e272e76f36c5eae.
Also, could you:
* Submit the SSP patch to the upstream project, and ask them to create
the m4/ directory?
* Create a followup patch for Buildroot that adds a working example of
janus.cfg configuration file and an init script to start the janus
daemon? This way users of the package at least have a working
starting point.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-01 15:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 15:42 [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Gregory Dymarek
2014-12-12 15:42 ` [Buildroot] [PATCH v2 1/7] Adding ding-libs Gregory Dymarek
2014-12-31 17:03 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 2/7] Adding gengetopt Gregory Dymarek
2015-01-01 14:07 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 3/7] Adding libnice Gregory Dymarek
2014-12-31 16:05 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 4/7] Adding libsrtp Gregory Dymarek
2015-01-01 10:30 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 5/7] Adding libwebsock Gregory Dymarek
2015-01-01 11:43 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 6/7] Adding sofia-sip Gregory Dymarek
2015-01-01 13:52 ` Thomas Petazzoni
2014-12-12 15:42 ` [Buildroot] [PATCH v2 7/7] Adding janus-gateway Gregory Dymarek
2015-01-01 15:46 ` Thomas Petazzoni [this message]
2014-12-12 15:58 ` [Buildroot] [PATCH v2 0/7] Adding janus-gateway and dependencies Vicente Olivert Riera
2014-12-12 16:06 ` Gregory Dymarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150101164638.66901cd9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox