* [Buildroot] [PATCH 0/2 v8] Improve silent builds (branch yem/fabio/silent)
@ 2015-01-01 16:50 Yann E. MORIN
2015-01-01 16:50 ` [Buildroot] [PATCH 1/2 v8] Makefile: improve detection of make "-s" flag Yann E. MORIN
2015-01-01 16:50 ` [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent Yann E. MORIN
0 siblings, 2 replies; 11+ messages in thread
From: Yann E. MORIN @ 2015-01-01 16:50 UTC (permalink / raw)
To: buildroot
Hello All!
This patch set improves silent builds.
Silent builds are also nice when top-level parallel make is being used
to reduce the output clutter.
Changes v7 -> v8:
- simply by just consigning stdout to oblivion (Yann)
Regards,
Yann E. MORIN.
The following changes since commit b7e7b417fa1210a7f9c4e76ee747238981dcd012:
wpa_supplicant: fix indentation and change file permissions (2015-01-01 11:31:14 +0100)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildroot yem/fabio/silent
for you to fetch changes up to 70490271dbf1774e87cc5dab1a5e907105afeb62:
pkg-download: silence downloads if make is silent (2015-01-01 17:47:49 +0100)
----------------------------------------------------------------
Fabio Porcedda (2):
Makefile: improve detection of make "-s" flag
pkg-download: silence downloads if make is silent
Makefile | 2 +-
package/pkg-download.mk | 8 ++++++++
support/download/dl-wrapper | 3 ++-
3 files changed, 11 insertions(+), 2 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH 1/2 v8] Makefile: improve detection of make "-s" flag 2015-01-01 16:50 [Buildroot] [PATCH 0/2 v8] Improve silent builds (branch yem/fabio/silent) Yann E. MORIN @ 2015-01-01 16:50 ` Yann E. MORIN 2015-01-01 16:50 ` [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent Yann E. MORIN 1 sibling, 0 replies; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 16:50 UTC (permalink / raw) To: buildroot From: Fabio Porcedda <fabio.porcedda@gmail.com> Because it's just checked the presence of the "s" character even a make --warn-undefined-variables is detected as a silent build so fix this by filtering out long options. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Cc: Arnout Vandecappelle <arnout@mind.be> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5e0b4f2..9995df7 100644 --- a/Makefile +++ b/Makefile @@ -304,7 +304,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess) TARGETS := # silent mode requested? -QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q) +QUIET := $(if $(findstring s,$(filter-out --%,$(MAKEFLAGS))),-q) # Strip off the annoying quoting ARCH := $(call qstrip,$(BR2_ARCH)) -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 16:50 [Buildroot] [PATCH 0/2 v8] Improve silent builds (branch yem/fabio/silent) Yann E. MORIN 2015-01-01 16:50 ` [Buildroot] [PATCH 1/2 v8] Makefile: improve detection of make "-s" flag Yann E. MORIN @ 2015-01-01 16:50 ` Yann E. MORIN 2015-01-01 17:54 ` Fabio Porcedda 1 sibling, 1 reply; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 16:50 UTC (permalink / raw) To: buildroot From: Fabio Porcedda <fabio.porcedda@gmail.com> If it is a silent build (make -s -> QUIET=-q) silence all downloads, as well as the check-hash. Only stdout is redirected, stderr is still visible, for errors and warning. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> [yann.morin.1998 at free.fr: greatly simplify by simply consigning stdout to oblivion] Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> --- package/pkg-download.mk | 8 ++++++++ support/download/dl-wrapper | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index ba72fc1..9c782fe 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -88,6 +88,7 @@ define DOWNLOAD_GIT $(EXTRA_ENV) $(DL_WRAPPER) -b git \ -o $(DL_DIR)/$($(PKG)_SOURCE) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $($(PKG)_SITE) \ $($(PKG)_DL_VERSION) \ @@ -109,6 +110,7 @@ define DOWNLOAD_BZR $(EXTRA_ENV) $(DL_WRAPPER) -b bzr \ -o $(DL_DIR)/$($(PKG)_SOURCE) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $($(PKG)_SITE) \ $($(PKG)_DL_VERSION) \ @@ -127,6 +129,7 @@ define DOWNLOAD_CVS $(EXTRA_ENV) $(DL_WRAPPER) -b cvs \ -o $(DL_DIR)/$($(PKG)_SOURCE) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $(call stripurischeme,$(call qstrip,$($(PKG)_SITE))) \ $($(PKG)_DL_VERSION) \ @@ -147,6 +150,7 @@ define DOWNLOAD_SVN $(EXTRA_ENV) $(DL_WRAPPER) -b svn \ -o $(DL_DIR)/$($(PKG)_SOURCE) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $($(PKG)_SITE) \ $($(PKG)_DL_VERSION) \ @@ -168,6 +172,7 @@ define DOWNLOAD_SCP $(EXTRA_ENV) $(DL_WRAPPER) -b scp \ -o $(DL_DIR)/$(2) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ '$(call stripurischeme,$(call qstrip,$(1)))' endef @@ -185,6 +190,7 @@ define DOWNLOAD_HG $(EXTRA_ENV) $(DL_WRAPPER) -b hg \ -o $(DL_DIR)/$($(PKG)_SOURCE) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $($(PKG)_SITE) \ $($(PKG)_DL_VERSION) \ @@ -206,6 +212,7 @@ define DOWNLOAD_WGET $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ -o $(DL_DIR)/$(2) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ '$(call qstrip,$(1))' endef @@ -222,6 +229,7 @@ define DOWNLOAD_LOCALFILES $(EXTRA_ENV) $(DL_WRAPPER) -b cp \ -o $(DL_DIR)/$(2) \ -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ + $(QUIET) \ -- \ $(call stripurischeme,$(call qstrip,$(1))) endef diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper index cced8f6..57a799e 100755 --- a/support/download/dl-wrapper +++ b/support/download/dl-wrapper @@ -24,12 +24,13 @@ main() { local backend output hfile # Parse our options; anything after '--' is for the backend - while getopts :hb:o:H: OPT; do + while getopts :hb:o:H:q OPT; do case "${OPT}" in h) help; exit 0;; b) backend="${OPTARG}";; o) output="${OPTARG}";; H) hfile="${OPTARG}";; + q) exec >/dev/null;; :) error "option '%s' expects a mandatory argument\n" "${OPTARG}";; \?) error "unknown option '%s'\n" "${OPTARG}";; esac -- 1.9.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 16:50 ` [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent Yann E. MORIN @ 2015-01-01 17:54 ` Fabio Porcedda 2015-01-01 17:58 ` Yann E. MORIN 2015-01-01 18:08 ` Yann E. MORIN 0 siblings, 2 replies; 11+ messages in thread From: Fabio Porcedda @ 2015-01-01 17:54 UTC (permalink / raw) To: buildroot On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > From: Fabio Porcedda <fabio.porcedda@gmail.com> > > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as > well as the check-hash. Only stdout is redirected, stderr is still > visible, for errors and warning. Hi Yann, nice idea, i tried this patch but even if it works for check-hash and svn it does not works for the git backend (e.g. libubox) and the wget bakend (try it without the QUIET flags in the WGET variable). I don't understand the reason for this behavior. Do you have an idea for this strange behavior? > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > [yann.morin.1998 at free.fr: greatly simplify by simply consigning stdout > to oblivion] > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > --- > package/pkg-download.mk | 8 ++++++++ > support/download/dl-wrapper | 3 ++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index ba72fc1..9c782fe 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -88,6 +88,7 @@ define DOWNLOAD_GIT > $(EXTRA_ENV) $(DL_WRAPPER) -b git \ > -o $(DL_DIR)/$($(PKG)_SOURCE) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $($(PKG)_SITE) \ > $($(PKG)_DL_VERSION) \ > @@ -109,6 +110,7 @@ define DOWNLOAD_BZR > $(EXTRA_ENV) $(DL_WRAPPER) -b bzr \ > -o $(DL_DIR)/$($(PKG)_SOURCE) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $($(PKG)_SITE) \ > $($(PKG)_DL_VERSION) \ > @@ -127,6 +129,7 @@ define DOWNLOAD_CVS > $(EXTRA_ENV) $(DL_WRAPPER) -b cvs \ > -o $(DL_DIR)/$($(PKG)_SOURCE) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $(call stripurischeme,$(call qstrip,$($(PKG)_SITE))) \ > $($(PKG)_DL_VERSION) \ > @@ -147,6 +150,7 @@ define DOWNLOAD_SVN > $(EXTRA_ENV) $(DL_WRAPPER) -b svn \ > -o $(DL_DIR)/$($(PKG)_SOURCE) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $($(PKG)_SITE) \ > $($(PKG)_DL_VERSION) \ > @@ -168,6 +172,7 @@ define DOWNLOAD_SCP > $(EXTRA_ENV) $(DL_WRAPPER) -b scp \ > -o $(DL_DIR)/$(2) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > '$(call stripurischeme,$(call qstrip,$(1)))' > endef > @@ -185,6 +190,7 @@ define DOWNLOAD_HG > $(EXTRA_ENV) $(DL_WRAPPER) -b hg \ > -o $(DL_DIR)/$($(PKG)_SOURCE) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $($(PKG)_SITE) \ > $($(PKG)_DL_VERSION) \ > @@ -206,6 +212,7 @@ define DOWNLOAD_WGET > $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ > -o $(DL_DIR)/$(2) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > '$(call qstrip,$(1))' > endef > @@ -222,6 +229,7 @@ define DOWNLOAD_LOCALFILES > $(EXTRA_ENV) $(DL_WRAPPER) -b cp \ > -o $(DL_DIR)/$(2) \ > -H $(PKGDIR)/$($(PKG)_RAWNAME).hash \ > + $(QUIET) \ > -- \ > $(call stripurischeme,$(call qstrip,$(1))) > endef > diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper > index cced8f6..57a799e 100755 > --- a/support/download/dl-wrapper > +++ b/support/download/dl-wrapper > @@ -24,12 +24,13 @@ main() { > local backend output hfile > > # Parse our options; anything after '--' is for the backend > - while getopts :hb:o:H: OPT; do > + while getopts :hb:o:H:q OPT; do > case "${OPT}" in > h) help; exit 0;; > b) backend="${OPTARG}";; > o) output="${OPTARG}";; > H) hfile="${OPTARG}";; > + q) exec >/dev/null;; > :) error "option '%s' expects a mandatory argument\n" "${OPTARG}";; > \?) error "unknown option '%s'\n" "${OPTARG}";; > esac > -- > 1.9.1 > -- Fabio Porcedda ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 17:54 ` Fabio Porcedda @ 2015-01-01 17:58 ` Yann E. MORIN 2015-01-01 18:03 ` Fabio Porcedda 2015-01-01 18:08 ` Yann E. MORIN 1 sibling, 1 reply; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 17:58 UTC (permalink / raw) To: buildroot Fabio, All, On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: > On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > From: Fabio Porcedda <fabio.porcedda@gmail.com> > > > > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as > > well as the check-hash. Only stdout is redirected, stderr is still > > visible, for errors and warning. > > Hi Yann, > nice idea, i tried this patch but even if it works for check-hash and > svn it does not works for the git backend (e.g. libubox) and the wget > bakend (try it without the QUIET flags in the WGET variable). > > I don't understand the reason for this behavior. > Do you have an idea for this strange behavior? Damn, no. I'll have look. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 17:58 ` Yann E. MORIN @ 2015-01-01 18:03 ` Fabio Porcedda 2015-01-01 18:08 ` Yann E. MORIN 0 siblings, 1 reply; 11+ messages in thread From: Fabio Porcedda @ 2015-01-01 18:03 UTC (permalink / raw) To: buildroot On Thu, Jan 1, 2015 at 6:58 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Fabio, All, > > On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: >> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> > From: Fabio Porcedda <fabio.porcedda@gmail.com> >> > >> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as >> > well as the check-hash. Only stdout is redirected, stderr is still >> > visible, for errors and warning. >> >> Hi Yann, >> nice idea, i tried this patch but even if it works for check-hash and >> svn it does not works for the git backend (e.g. libubox) and the wget >> bakend (try it without the QUIET flags in the WGET variable). >> >> I don't understand the reason for this behavior. >> Do you have an idea for this strange behavior? > > Damn, no. I'll have look. Thank, i think that it must works even when the QUIET variables is not added to the environment variables: diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 9c782fe..5e74519 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -8,14 +8,14 @@ ################################################################################ # Download method commands -export WGET := $(call qstrip,$(BR2_WGET)) $(QUIET) +export WGET := $(call qstrip,$(BR2_WGET)) export SVN := $(call qstrip,$(BR2_SVN)) export CVS := $(call qstrip,$(BR2_CVS)) export BZR := $(call qstrip,$(BR2_BZR)) export GIT := $(call qstrip,$(BR2_GIT)) -export HG := $(call qstrip,$(BR2_HG)) $(QUIET) -export SCP := $(call qstrip,$(BR2_SCP)) $(QUIET) -SSH := $(call qstrip,$(BR2_SSH)) $(QUIET) +export HG := $(call qstrip,$(BR2_HG)) +export SCP := $(call qstrip,$(BR2_SCP)) +SSH := $(call qstrip,$(BR2_SSH)) export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES)) DL_WRAPPER = support/download/dl-wrapper BR -- Fabio Porcedda ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 18:03 ` Fabio Porcedda @ 2015-01-01 18:08 ` Yann E. MORIN 0 siblings, 0 replies; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 18:08 UTC (permalink / raw) To: buildroot Fabio, All, On 2015-01-01 19:03 +0100, Fabio Porcedda spake thusly: > On Thu, Jan 1, 2015 at 6:58 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Fabio, All, > > > > On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: > >> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > >> > From: Fabio Porcedda <fabio.porcedda@gmail.com> > >> > > >> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as > >> > well as the check-hash. Only stdout is redirected, stderr is still > >> > visible, for errors and warning. > >> > >> Hi Yann, > >> nice idea, i tried this patch but even if it works for check-hash and > >> svn it does not works for the git backend (e.g. libubox) and the wget > >> bakend (try it without the QUIET flags in the WGET variable). > >> > >> I don't understand the reason for this behavior. > >> Do you have an idea for this strange behavior? > > > > Damn, no. I'll have look. > > Thank, i think that it must works even when the QUIET variables is not > added to the environment variables: Yes, that's right. Regards, Yann E. MORIN. > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index 9c782fe..5e74519 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -8,14 +8,14 @@ > ################################################################################ > > # Download method commands > -export WGET := $(call qstrip,$(BR2_WGET)) $(QUIET) > +export WGET := $(call qstrip,$(BR2_WGET)) > export SVN := $(call qstrip,$(BR2_SVN)) > export CVS := $(call qstrip,$(BR2_CVS)) > export BZR := $(call qstrip,$(BR2_BZR)) > export GIT := $(call qstrip,$(BR2_GIT)) > -export HG := $(call qstrip,$(BR2_HG)) $(QUIET) > -export SCP := $(call qstrip,$(BR2_SCP)) $(QUIET) > -SSH := $(call qstrip,$(BR2_SSH)) $(QUIET) > +export HG := $(call qstrip,$(BR2_HG)) > +export SCP := $(call qstrip,$(BR2_SCP)) > +SSH := $(call qstrip,$(BR2_SSH)) > export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES)) > > DL_WRAPPER = support/download/dl-wrapper > > BR > -- > Fabio Porcedda -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 17:54 ` Fabio Porcedda 2015-01-01 17:58 ` Yann E. MORIN @ 2015-01-01 18:08 ` Yann E. MORIN 2015-01-01 18:14 ` Fabio Porcedda 1 sibling, 1 reply; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 18:08 UTC (permalink / raw) To: buildroot Fabio, All, On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: > On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > From: Fabio Porcedda <fabio.porcedda@gmail.com> > > > > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as > > well as the check-hash. Only stdout is redirected, stderr is still > > visible, for errors and warning. > > Hi Yann, > nice idea, i tried this patch but even if it works for check-hash and > svn it does not works for the git backend (e.g. libubox) and the wget > bakend (try it without the QUIET flags in the WGET variable). > > I don't understand the reason for this behavior. > Do you have an idea for this strange behavior? Ok, that's because git always sends its report status to stderr: --quiet, -q Operate quietly. Progress is not reported to the standard error stream. [...] So, we need to pass -q to git. Sigh, fscking borked behaviour... stderr is for failures, not normal reporting... :-( OK, so we need to pass -q to some backends. However, what I did not like in your original patch was the fact that some backends were singled out in the wrapper script. We do not want that, we want the wrapper to be backend-agnostic (that's the whole point of having a wrapper and backends). I'll rework that, then... Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 18:08 ` Yann E. MORIN @ 2015-01-01 18:14 ` Fabio Porcedda 2015-01-01 18:16 ` Fabio Porcedda 2015-01-01 18:20 ` Yann E. MORIN 0 siblings, 2 replies; 11+ messages in thread From: Fabio Porcedda @ 2015-01-01 18:14 UTC (permalink / raw) To: buildroot On Thu, Jan 1, 2015 at 7:08 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Fabio, All, > > On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: >> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> > From: Fabio Porcedda <fabio.porcedda@gmail.com> >> > >> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as >> > well as the check-hash. Only stdout is redirected, stderr is still >> > visible, for errors and warning. >> >> Hi Yann, >> nice idea, i tried this patch but even if it works for check-hash and >> svn it does not works for the git backend (e.g. libubox) and the wget >> bakend (try it without the QUIET flags in the WGET variable). >> >> I don't understand the reason for this behavior. >> Do you have an idea for this strange behavior? > > Ok, that's because git always sends its report status to stderr: > > --quiet, -q > Operate quietly. Progress is not reported to the standard > error stream. [...] > > So, we need to pass -q to git. Sigh, fscking borked behaviour... stderr > is for failures, not normal reporting... :-( So that's the reason... > > OK, so we need to pass -q to some backends. > > However, what I did not like in your original patch was the fact that > some backends were singled out in the wrapper script. We do not want > that, we want the wrapper to be backend-agnostic (that's the whole point > of having a wrapper and backends). Well that it's needed only until all backends support the "-q" flag, do you prefer a big patch to convert all backends so that check is not needed? > I'll rework that, then... BR -- Fabio Porcedda ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 18:14 ` Fabio Porcedda @ 2015-01-01 18:16 ` Fabio Porcedda 2015-01-01 18:20 ` Yann E. MORIN 1 sibling, 0 replies; 11+ messages in thread From: Fabio Porcedda @ 2015-01-01 18:16 UTC (permalink / raw) To: buildroot On Thu, Jan 1, 2015 at 7:14 PM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > On Thu, Jan 1, 2015 at 7:08 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> Fabio, All, >> >> On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: >>> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >>> > From: Fabio Porcedda <fabio.porcedda@gmail.com> >>> > >>> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as >>> > well as the check-hash. Only stdout is redirected, stderr is still >>> > visible, for errors and warning. >>> >>> Hi Yann, >>> nice idea, i tried this patch but even if it works for check-hash and >>> svn it does not works for the git backend (e.g. libubox) and the wget >>> bakend (try it without the QUIET flags in the WGET variable). >>> >>> I don't understand the reason for this behavior. >>> Do you have an idea for this strange behavior? >> >> Ok, that's because git always sends its report status to stderr: >> >> --quiet, -q >> Operate quietly. Progress is not reported to the standard >> error stream. [...] >> >> So, we need to pass -q to git. Sigh, fscking borked behaviour... stderr >> is for failures, not normal reporting... :-( > So that's the reason... > >> >> OK, so we need to pass -q to some backends. >> >> However, what I did not like in your original patch was the fact that >> some backends were singled out in the wrapper script. We do not want >> that, we want the wrapper to be backend-agnostic (that's the whole point >> of having a wrapper and backends). > > Well that it's needed only until all backends support the "-q" flag, > do you prefer a big patch to convert all backends so that check is not > needed? > >> I'll rework that, then... Even wget needs that flag, if it is fine for you i'll rework that patch set. BR -- Fabio Porcedda ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent 2015-01-01 18:14 ` Fabio Porcedda 2015-01-01 18:16 ` Fabio Porcedda @ 2015-01-01 18:20 ` Yann E. MORIN 1 sibling, 0 replies; 11+ messages in thread From: Yann E. MORIN @ 2015-01-01 18:20 UTC (permalink / raw) To: buildroot Fabio, All, On 2015-01-01 19:14 +0100, Fabio Porcedda spake thusly: > On Thu, Jan 1, 2015 at 7:08 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Fabio, All, > > > > On 2015-01-01 18:54 +0100, Fabio Porcedda spake thusly: > >> On Thu, Jan 1, 2015 at 5:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > >> > From: Fabio Porcedda <fabio.porcedda@gmail.com> > >> > > >> > If it is a silent build (make -s -> QUIET=-q) silence all downloads, as > >> > well as the check-hash. Only stdout is redirected, stderr is still > >> > visible, for errors and warning. > >> > >> Hi Yann, > >> nice idea, i tried this patch but even if it works for check-hash and > >> svn it does not works for the git backend (e.g. libubox) and the wget > >> bakend (try it without the QUIET flags in the WGET variable). > >> > >> I don't understand the reason for this behavior. > >> Do you have an idea for this strange behavior? > > > > Ok, that's because git always sends its report status to stderr: > > > > --quiet, -q > > Operate quietly. Progress is not reported to the standard > > error stream. [...] > > > > So, we need to pass -q to git. Sigh, fscking borked behaviour... stderr > > is for failures, not normal reporting... :-( > So that's the reason... > > > > > OK, so we need to pass -q to some backends. > > > > However, what I did not like in your original patch was the fact that > > some backends were singled out in the wrapper script. We do not want > > that, we want the wrapper to be backend-agnostic (that's the whole point > > of having a wrapper and backends). > > Well that it's needed only until all backends support the "-q" flag, > do you prefer a big patch to convert all backends so that check is not > needed? I'm already on it... ;-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-01-01 18:20 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-01 16:50 [Buildroot] [PATCH 0/2 v8] Improve silent builds (branch yem/fabio/silent) Yann E. MORIN 2015-01-01 16:50 ` [Buildroot] [PATCH 1/2 v8] Makefile: improve detection of make "-s" flag Yann E. MORIN 2015-01-01 16:50 ` [Buildroot] [PATCH 2/2 v8] pkg-download: silence downloads if make is silent Yann E. MORIN 2015-01-01 17:54 ` Fabio Porcedda 2015-01-01 17:58 ` Yann E. MORIN 2015-01-01 18:03 ` Fabio Porcedda 2015-01-01 18:08 ` Yann E. MORIN 2015-01-01 18:08 ` Yann E. MORIN 2015-01-01 18:14 ` Fabio Porcedda 2015-01-01 18:16 ` Fabio Porcedda 2015-01-01 18:20 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox