From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/10] package/lockdev: handle static/shared only build
Date: Fri, 2 Jan 2015 12:43:18 +0100 [thread overview]
Message-ID: <20150102124318.593ec365@free-electrons.com> (raw)
In-Reply-To: <1419717508-11627-6-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Sat, 27 Dec 2014 22:58:23 +0100, Romain Naour wrote:
> ifeq ($(BR2_STATIC_LIBS),y)
> -define LOCKDEV_BUILD_CMDS
> - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) static
> +LOCKDEV_BUILD_ARGS = static
> +LOCKDEV_INSTALL_ARGS = install_dev
> +else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> +LOCKDEV_BUILD_ARGS = static shared
> +LOCKDEV_INSTALL_ARGS = install_dev install_run
> +else # BR2_SHARED_LIBS
> +LOCKDEV_BUILD_ARGS = shared
> +LOCKDEV_INSTALL_ARGS = install_run
This case doesn't work: if you don't use the install_dev target, the
header files of lockdev will not be installed to the staging directory.
So you have to use install_dev, or rework the makefile to have two
separate targets to install the static library and the header files.
I'll mark your patch as Changes Requested in patchwork.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-02 11:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 21:58 [Buildroot] [PATCH 00/10] Misc shared only build fixes Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 01/10] package/lm-sensors: disable static library for shared-only build Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 02/10] package/libnspr: disable static library for shared only build Romain Naour
2015-01-01 16:48 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 03/10] package/libsvgtiny: enable shared library build Romain Naour
2015-01-02 11:38 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 04/10] package/keyutils: disable static library for shared only build Romain Naour
2015-01-02 11:39 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 05/10] package/lockdev: handle static/shared " Romain Naour
2014-12-28 6:07 ` Baruch Siach
2015-01-02 11:43 ` Thomas Petazzoni [this message]
2014-12-27 21:58 ` [Buildroot] [PATCH 06/10] package/libxmlrpc: fix shared libraries build for uClibc Romain Naour
2015-01-02 11:48 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 07/10] package/libxmlrpc: handle static/shared only install Romain Naour
2015-01-02 12:18 ` Thomas Petazzoni
2015-01-04 14:23 ` Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 08/10] package/dvb-apps: rename patches to follow the new name convention Romain Naour
2015-01-02 12:21 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 09/10] package/dvb-app: handle static/shared only build Romain Naour
2015-01-02 12:25 ` Thomas Petazzoni
2015-01-04 11:56 ` Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 10/10] package/dvb-app: remove tests Romain Naour
2015-01-02 12:26 ` Thomas Petazzoni
2015-01-04 11:56 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102124318.593ec365@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox