From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 09/10] package/dvb-app: handle static/shared only build
Date: Fri, 2 Jan 2015 13:25:03 +0100 [thread overview]
Message-ID: <20150102132503.7b9036cc@free-electrons.com> (raw)
In-Reply-To: <1419717508-11627-10-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Sat, 27 Dec 2014 22:58:27 +0100, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> .../0003-handle-static-shared-only-build.patch | 35 ++++++++++++++++++++++
> .../dvb-apps/0003-support-static-only-build.patch | 20 -------------
> package/dvb-apps/dvb-apps.mk | 6 +++-
> 3 files changed, 40 insertions(+), 21 deletions(-)
> create mode 100644 package/dvb-apps/0003-handle-static-shared-only-build.patch
> delete mode 100644 package/dvb-apps/0003-support-static-only-build.patch
Does not build with the following configuration:
BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2014.11.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_17=y
BR2_TOOLCHAIN_EXTERNAL_LARGEFILE=y
BR2_TOOLCHAIN_EXTERNAL_INET_IPV6=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_DVB_APPS=y
# BR2_TARGET_ROOTFS_TAR is not set
It gives:
CC dvbcfg_test
arm-linux-gcc: error: ../../lib/libdvbcfg/libdvbcfg.a: Aucun fichier ou dossier de ce type
../../Make.rules:81: recipe for target 'dvbcfg_test' failed
Do you actually test your patches before sending them? I don't mind
seeing corner cases being broken, but here it's the canonical case: a
BR2_SHARED_LIBS=y build (which is the default) on a major architecture
(ARM).
Patch rejected.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-02 12:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 21:58 [Buildroot] [PATCH 00/10] Misc shared only build fixes Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 01/10] package/lm-sensors: disable static library for shared-only build Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 02/10] package/libnspr: disable static library for shared only build Romain Naour
2015-01-01 16:48 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 03/10] package/libsvgtiny: enable shared library build Romain Naour
2015-01-02 11:38 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 04/10] package/keyutils: disable static library for shared only build Romain Naour
2015-01-02 11:39 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 05/10] package/lockdev: handle static/shared " Romain Naour
2014-12-28 6:07 ` Baruch Siach
2015-01-02 11:43 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 06/10] package/libxmlrpc: fix shared libraries build for uClibc Romain Naour
2015-01-02 11:48 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 07/10] package/libxmlrpc: handle static/shared only install Romain Naour
2015-01-02 12:18 ` Thomas Petazzoni
2015-01-04 14:23 ` Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 08/10] package/dvb-apps: rename patches to follow the new name convention Romain Naour
2015-01-02 12:21 ` Thomas Petazzoni
2014-12-27 21:58 ` [Buildroot] [PATCH 09/10] package/dvb-app: handle static/shared only build Romain Naour
2015-01-02 12:25 ` Thomas Petazzoni [this message]
2015-01-04 11:56 ` Romain Naour
2014-12-27 21:58 ` [Buildroot] [PATCH 10/10] package/dvb-app: remove tests Romain Naour
2015-01-02 12:26 ` Thomas Petazzoni
2015-01-04 11:56 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102132503.7b9036cc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox