From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path
Date: Sat, 10 Jan 2015 16:34:53 +0100 [thread overview]
Message-ID: <20150110163453.0d3cc906@free-electrons.com> (raw)
In-Reply-To: <1420902661-20721-2-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Sat, 10 Jan 2015 16:11:01 +0100, Romain Naour wrote:
> +diff --git a/configure.in b/configure.in
> +index a8fc950..0b0bcd1 100644
> +--- a/configure.in
> ++++ b/configure.in
> +@@ -82,7 +82,7 @@ AM_CONDITIONAL(CROSS_COMPILING, test x$cross_compiling = xyes)
> + dnl ***********************************************************************
> + dnl set compiler/linker flags
> + dnl ***********************************************************************
> +-INCLUDES="${INCLUDES} -I/usr/local/include"
> ++INCLUDES="${INCLUDES}"
Hum, INCLUDES="${INCLUDES}" could also be replaced with just nothing,
no? So shouldn't your patch simply get rid of this line?
Also, please submit upstream, thanks :)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-10 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 15:11 [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Romain Naour
2015-01-10 15:11 ` [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path Romain Naour
2015-01-10 15:34 ` Thomas Petazzoni [this message]
2015-01-10 15:36 ` [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150110163453.0d3cc906@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox