Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention
@ 2015-01-10 15:11 Romain Naour
  2015-01-10 15:11 ` [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path Romain Naour
  2015-01-10 15:36 ` [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Thomas Petazzoni
  0 siblings, 2 replies; 4+ messages in thread
From: Romain Naour @ 2015-01-10 15:11 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 .../{sane-backends-1.0.22-qcam-x86.patch => 0001-qcam-x86.patch}          | 0
 package/sane-backends/{sane-backends-1.0.22-v4l.patch => 0002-v4l.patch}  | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename package/sane-backends/{sane-backends-1.0.22-qcam-x86.patch => 0001-qcam-x86.patch} (100%)
 rename package/sane-backends/{sane-backends-1.0.22-v4l.patch => 0002-v4l.patch} (100%)

diff --git a/package/sane-backends/sane-backends-1.0.22-qcam-x86.patch b/package/sane-backends/0001-qcam-x86.patch
similarity index 100%
rename from package/sane-backends/sane-backends-1.0.22-qcam-x86.patch
rename to package/sane-backends/0001-qcam-x86.patch
diff --git a/package/sane-backends/sane-backends-1.0.22-v4l.patch b/package/sane-backends/0002-v4l.patch
similarity index 100%
rename from package/sane-backends/sane-backends-1.0.22-v4l.patch
rename to package/sane-backends/0002-v4l.patch
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path
  2015-01-10 15:11 [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Romain Naour
@ 2015-01-10 15:11 ` Romain Naour
  2015-01-10 15:34   ` Thomas Petazzoni
  2015-01-10 15:36 ` [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Thomas Petazzoni
  1 sibling, 1 reply; 4+ messages in thread
From: Romain Naour @ 2015-01-10 15:11 UTC (permalink / raw)
  To: buildroot

Fixes:
http://autobuild.buildroot.net/results/deb/deb3d45416633b9217d3cc09664273687c809464/

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 .../0003-remove-unsafe-headers-path.patch          | 29 ++++++++++++++++++++++
 package/sane-backends/sane-backends.mk             |  2 ++
 2 files changed, 31 insertions(+)
 create mode 100644 package/sane-backends/0003-remove-unsafe-headers-path.patch

diff --git a/package/sane-backends/0003-remove-unsafe-headers-path.patch b/package/sane-backends/0003-remove-unsafe-headers-path.patch
new file mode 100644
index 0000000..54b1835
--- /dev/null
+++ b/package/sane-backends/0003-remove-unsafe-headers-path.patch
@@ -0,0 +1,29 @@
+From a79d700923134678c38cedd96fa00b058f70d597 Mon Sep 17 00:00:00 2001
+From: Romain Naour <romain.naour@openwide.fr>
+Date: Sat, 10 Jan 2015 15:48:21 +0100
+Subject: [PATCH] configure.in: remove unsafe headers path
+
+Forcing /usr/local/include headers path in CFLAGS is unsafe for
+cross-compilation.
+
+Signed-off-by: Romain Naour <romain.naour@openwide.fr>
+---
+ configure.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.in b/configure.in
+index a8fc950..0b0bcd1 100644
+--- a/configure.in
++++ b/configure.in
+@@ -82,7 +82,7 @@ AM_CONDITIONAL(CROSS_COMPILING, test x$cross_compiling = xyes)
+ dnl ***********************************************************************
+ dnl set compiler/linker flags
+ dnl ***********************************************************************
+-INCLUDES="${INCLUDES} -I/usr/local/include"
++INCLUDES="${INCLUDES}"
+ AC_SUBST(INCLUDES)
+ SANE_SET_CFLAGS([$is_release])
+ SANE_SET_LDFLAGS
+-- 
+1.9.3
+
diff --git a/package/sane-backends/sane-backends.mk b/package/sane-backends/sane-backends.mk
index f8c59e8..bde8e6a 100644
--- a/package/sane-backends/sane-backends.mk
+++ b/package/sane-backends/sane-backends.mk
@@ -10,6 +10,8 @@ SANE_BACKENDS_CONFIG_SCRIPTS = sane-config
 SANE_BACKENDS_LICENSE = GPLv2+
 SANE_BACKENDS_LICENSE_FILES = COPYING
 SANE_BACKENDS_INSTALL_STAGING = YES
+# 0003-remove-unsafe-headers-path.patch patch configure.in
+SANE_BACKENDS_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_LIBUSB),y)
 SANE_BACKENDS_DEPENDENCIES += libusb
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path
  2015-01-10 15:11 ` [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path Romain Naour
@ 2015-01-10 15:34   ` Thomas Petazzoni
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-01-10 15:34 UTC (permalink / raw)
  To: buildroot

Dear Romain Naour,

On Sat, 10 Jan 2015 16:11:01 +0100, Romain Naour wrote:

> +diff --git a/configure.in b/configure.in
> +index a8fc950..0b0bcd1 100644
> +--- a/configure.in
> ++++ b/configure.in
> +@@ -82,7 +82,7 @@ AM_CONDITIONAL(CROSS_COMPILING, test x$cross_compiling = xyes)
> + dnl ***********************************************************************
> + dnl set compiler/linker flags
> + dnl ***********************************************************************
> +-INCLUDES="${INCLUDES} -I/usr/local/include"
> ++INCLUDES="${INCLUDES}"

Hum, INCLUDES="${INCLUDES}" could also be replaced with just nothing,
no? So shouldn't your patch simply get rid of this line?

Also, please submit upstream, thanks :)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention
  2015-01-10 15:11 [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Romain Naour
  2015-01-10 15:11 ` [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path Romain Naour
@ 2015-01-10 15:36 ` Thomas Petazzoni
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-01-10 15:36 UTC (permalink / raw)
  To: buildroot

Dear Romain Naour,

On Sat, 10 Jan 2015 16:11:00 +0100, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-10 15:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-10 15:11 [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Romain Naour
2015-01-10 15:11 ` [Buildroot] [PATCH 2/2] package/sane-backends: remove unsafe headers path Romain Naour
2015-01-10 15:34   ` Thomas Petazzoni
2015-01-10 15:36 ` [Buildroot] [PATCH 1/2] package/sane-backends: rename patches to the new naming convention Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox