From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/7] rsyslog: rename sysv initscript to S01logging
Date: Wed, 14 Jan 2015 20:30:51 +0100 [thread overview]
Message-ID: <20150114203051.513c370c@free-electrons.com> (raw)
In-Reply-To: <1421191022-5509-3-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Tue, 13 Jan 2015 20:16:58 -0300, Gustavo Zacarias wrote:
> Do it to avoid having duplicate and conflicting functionality with
> busybox's S01logging.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/rsyslog/{S01rsyslog => S01logging} | 0
> package/rsyslog/rsyslog.mk | 4 ++--
> 2 files changed, 2 insertions(+), 2 deletions(-)
> rename package/rsyslog/{S01rsyslog => S01logging} (100%)
To be honest, I wasn't really sure whether the right approach to handle
this issue was to rename the init script as you did, or to have rsyslog
explicitly remove S01logging when Busybox is enabled.
Since the rest of patch series was doing some cleanup on the renamed
S01logging, I decided to take your approach, but I must say I wasn't
entirely sure on how to handle this.
Comments from others are welcome, I don't consider the proposed
solution to be set in stone.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-14 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 23:16 [Buildroot] [PATCH 1/7] libestr: bump to version 0.1.10 Gustavo Zacarias
2015-01-13 23:16 ` [Buildroot] [PATCH 2/7] liblogging: bump to version 1.0.5 Gustavo Zacarias
2015-01-13 23:16 ` [Buildroot] [PATCH 3/7] rsyslog: rename sysv initscript to S01logging Gustavo Zacarias
2015-01-14 19:30 ` Thomas Petazzoni [this message]
2015-01-14 19:33 ` Gustavo Zacarias
2015-01-14 19:43 ` Thomas Petazzoni
2015-01-13 23:16 ` [Buildroot] [PATCH 4/7] rsyslog: clean up sysv initscript Gustavo Zacarias
2015-01-14 19:31 ` Thomas Petazzoni
2015-01-14 19:35 ` Gustavo Zacarias
2015-01-14 19:44 ` Thomas Petazzoni
2015-01-13 23:17 ` [Buildroot] [PATCH 5/7] rsyslog: doesn't need largefile/wchar Gustavo Zacarias
2015-01-13 23:17 ` [Buildroot] [PATCH 6/7] rsyslog: bump to version 8.7.0 Gustavo Zacarias
2015-01-13 23:17 ` [Buildroot] [PATCH 7/7] rsyslog: enable more basic features Gustavo Zacarias
2015-01-14 19:31 ` Thomas Petazzoni
2015-01-14 19:29 ` [Buildroot] [PATCH 1/7] libestr: bump to version 0.1.10 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114203051.513c370c@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox