From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/7] rsyslog: clean up sysv initscript
Date: Wed, 14 Jan 2015 20:31:12 +0100 [thread overview]
Message-ID: <20150114203112.3412efb6@free-electrons.com> (raw)
In-Reply-To: <1421191022-5509-4-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Tue, 13 Jan 2015 20:16:59 -0300, Gustavo Zacarias wrote:
> start() {
> - echo -n "Starting rsyslog daemon: "
> - umask 077
> - start-stop-daemon -S -q -p /var/run/rsyslogd.pid --exec /usr/sbin/rsyslogd
> - echo "OK"
> + echo -n "Starting rsyslog daemon: "
> + umask 077
Do we really need this umask 077 ?
> restart() {
> - stop
> - start
> + stop
> + sleep 1
And this sleep 1 ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-14 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 23:16 [Buildroot] [PATCH 1/7] libestr: bump to version 0.1.10 Gustavo Zacarias
2015-01-13 23:16 ` [Buildroot] [PATCH 2/7] liblogging: bump to version 1.0.5 Gustavo Zacarias
2015-01-13 23:16 ` [Buildroot] [PATCH 3/7] rsyslog: rename sysv initscript to S01logging Gustavo Zacarias
2015-01-14 19:30 ` Thomas Petazzoni
2015-01-14 19:33 ` Gustavo Zacarias
2015-01-14 19:43 ` Thomas Petazzoni
2015-01-13 23:16 ` [Buildroot] [PATCH 4/7] rsyslog: clean up sysv initscript Gustavo Zacarias
2015-01-14 19:31 ` Thomas Petazzoni [this message]
2015-01-14 19:35 ` Gustavo Zacarias
2015-01-14 19:44 ` Thomas Petazzoni
2015-01-13 23:17 ` [Buildroot] [PATCH 5/7] rsyslog: doesn't need largefile/wchar Gustavo Zacarias
2015-01-13 23:17 ` [Buildroot] [PATCH 6/7] rsyslog: bump to version 8.7.0 Gustavo Zacarias
2015-01-13 23:17 ` [Buildroot] [PATCH 7/7] rsyslog: enable more basic features Gustavo Zacarias
2015-01-14 19:31 ` Thomas Petazzoni
2015-01-14 19:29 ` [Buildroot] [PATCH 1/7] libestr: bump to version 0.1.10 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114203112.3412efb6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox