* [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency
@ 2015-01-18 11:34 Romain Naour
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Romain Naour @ 2015-01-18 11:34 UTC (permalink / raw)
To: buildroot
rpm check for libintl library if BR2_NEEDS_GETTEXT_IF_LOCALE is set.
checking for GNU gettext in libintl... yes
checking whether to use NLS... yes
checking where the gettext function comes from... external libintl
checking how to link with libintl... -lintl
But the dependency on gettext package is missing to ensures
reproducible builds.
Also, sort selected packages alphabetically in Config.in
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/rpm/Config.in | 7 ++++---
package/rpm/rpm.mk | 4 ++++
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/package/rpm/Config.in b/package/rpm/Config.in
index 620eb1a..5ec4167 100644
--- a/package/rpm/Config.in
+++ b/package/rpm/Config.in
@@ -7,12 +7,13 @@ config BR2_PACKAGE_RPM
depends on BR2_TOOLCHAIN_HAS_THREADS # beecrypt
depends on BR2_USE_MMU # fork()
select BR2_PACKAGE_BEECRYPT
- select BR2_PACKAGE_POPT
- select BR2_PACKAGE_OPENSSL
+ select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
select BR2_PACKAGE_NEON
+ select BR2_PACKAGE_NEON_SSL
select BR2_PACKAGE_NEON_XML
select BR2_PACKAGE_NEON_ZLIB
- select BR2_PACKAGE_NEON_SSL
+ select BR2_PACKAGE_OPENSSL
+ select BR2_PACKAGE_POPT
select BR2_PACKAGE_ZLIB
help
The RPM package management system.
diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
index c4215b5..74f5b88 100644
--- a/package/rpm/rpm.mk
+++ b/package/rpm/rpm.mk
@@ -26,6 +26,10 @@ RPM_CONF_OPTS = \
--with-libbeecrypt=$(STAGING_DIR) \
--with-popt=$(STAGING_DIR)
+ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
+RPM_DEPENDENCIES += gettext
+endif
+
ifeq ($(BR2_PACKAGE_PCRE),y)
RPM_DEPENDENCIES += pcre
RPM_CONF_OPTS += --with-pcre=external
--
1.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/3] package/rpm: use external xz library
2015-01-18 11:34 [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Romain Naour
@ 2015-01-18 11:34 ` Romain Naour
2015-01-18 14:59 ` Yann E. MORIN
2015-01-18 11:35 ` [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path Romain Naour
2015-01-18 14:21 ` [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Yann E. MORIN
2 siblings, 1 reply; 8+ messages in thread
From: Romain Naour @ 2015-01-18 11:34 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/2c6/2c61562008418ff58fa3085a3342b0e304923073/
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/rpm/Config.in | 1 +
package/rpm/rpm.mk | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/rpm/Config.in b/package/rpm/Config.in
index 5ec4167..fe7a38a 100644
--- a/package/rpm/Config.in
+++ b/package/rpm/Config.in
@@ -31,6 +31,7 @@ config BR2_PACKAGE_RPM_BZIP2_PAYLOADS
config BR2_PACKAGE_RPM_XZ_PAYLOADS
bool "support for xz payloads"
depends on BR2_INSTALL_LIBSTDCPP
+ select BR2_PACKAGE_XZ
help
Support for xz payloads in RPM.
diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
index 74f5b88..ce7189e 100644
--- a/package/rpm/rpm.mk
+++ b/package/rpm/rpm.mk
@@ -45,7 +45,10 @@ RPM_CONF_OPTS += --with-file=no
endif
ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
-RPM_CONF_OPTS += --with-xz
+RPM_CONF_OPTS += --with-xz=external
+RPM_DEPENDENCIES += xz
+else
+RPM_CONF_OPTS += --with-xz=none
endif
ifeq ($(BR2_PACKAGE_RPM_BZIP2_PAYLOADS),y)
--
1.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path
2015-01-18 11:34 [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Romain Naour
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
@ 2015-01-18 11:35 ` Romain Naour
2015-01-18 15:01 ` Yann E. MORIN
2015-01-18 14:21 ` [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Yann E. MORIN
2 siblings, 1 reply; 8+ messages in thread
From: Romain Naour @ 2015-01-18 11:35 UTC (permalink / raw)
To: buildroot
The recognized keywords are:
(location path: "external:internal:none")
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/rpm/rpm.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
index ce7189e..6725ca4 100644
--- a/package/rpm/rpm.mk
+++ b/package/rpm/rpm.mk
@@ -34,14 +34,14 @@ ifeq ($(BR2_PACKAGE_PCRE),y)
RPM_DEPENDENCIES += pcre
RPM_CONF_OPTS += --with-pcre=external
else
-RPM_CONF_OPTS += --with-pcre=no
+RPM_CONF_OPTS += --with-pcre=none
endif
ifeq ($(BR2_PACKAGE_FILE),y)
RPM_DEPENDENCIES += file
RPM_CONF_OPTS += --with-file=external
else
-RPM_CONF_OPTS += --with-file=no
+RPM_CONF_OPTS += --with-file=none
endif
ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
--
1.9.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency
2015-01-18 11:34 [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Romain Naour
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
2015-01-18 11:35 ` [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path Romain Naour
@ 2015-01-18 14:21 ` Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
2 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-01-18 14:21 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2015-01-18 12:34 +0100, Romain Naour spake thusly:
> rpm check for libintl library if BR2_NEEDS_GETTEXT_IF_LOCALE is set.
>
> checking for GNU gettext in libintl... yes
> checking whether to use NLS... yes
> checking where the gettext function comes from... external libintl
> checking how to link with libintl... -lintl
Do you ave a defconfig with which I could test, please?
> But the dependency on gettext package is missing to ensures
> reproducible builds.
>
> Also, sort selected packages alphabetically in Config.in
I would prefer we do not mix feature changes with eye-candy, it makes
reviewing a bit more complicated than it should be. Next time, could you
just do that in a different patch, please?
Regards,
Yann E. MORIN.
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/rpm/Config.in | 7 ++++---
> package/rpm/rpm.mk | 4 ++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/package/rpm/Config.in b/package/rpm/Config.in
> index 620eb1a..5ec4167 100644
> --- a/package/rpm/Config.in
> +++ b/package/rpm/Config.in
> @@ -7,12 +7,13 @@ config BR2_PACKAGE_RPM
> depends on BR2_TOOLCHAIN_HAS_THREADS # beecrypt
> depends on BR2_USE_MMU # fork()
> select BR2_PACKAGE_BEECRYPT
> - select BR2_PACKAGE_POPT
> - select BR2_PACKAGE_OPENSSL
> + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> select BR2_PACKAGE_NEON
> + select BR2_PACKAGE_NEON_SSL
> select BR2_PACKAGE_NEON_XML
> select BR2_PACKAGE_NEON_ZLIB
> - select BR2_PACKAGE_NEON_SSL
> + select BR2_PACKAGE_OPENSSL
> + select BR2_PACKAGE_POPT
> select BR2_PACKAGE_ZLIB
> help
> The RPM package management system.
> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> index c4215b5..74f5b88 100644
> --- a/package/rpm/rpm.mk
> +++ b/package/rpm/rpm.mk
> @@ -26,6 +26,10 @@ RPM_CONF_OPTS = \
> --with-libbeecrypt=$(STAGING_DIR) \
> --with-popt=$(STAGING_DIR)
>
> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
> +RPM_DEPENDENCIES += gettext
> +endif
> +
> ifeq ($(BR2_PACKAGE_PCRE),y)
> RPM_DEPENDENCIES += pcre
> RPM_CONF_OPTS += --with-pcre=external
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/3] package/rpm: use external xz library
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
@ 2015-01-18 14:59 ` Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
0 siblings, 1 reply; 8+ messages in thread
From: Yann E. MORIN @ 2015-01-18 14:59 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2015-01-18 12:34 +0100, Romain Naour spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/2c6/2c61562008418ff58fa3085a3342b0e304923073/
Weird, this build error is about being unable to link with libintl.so
(indeed while building the xz backend, but still about libintl).
Igues I could use that autobuild failure to test your patch 1/3,
though...
Otherwise, I have some comments, see below...
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/rpm/Config.in | 1 +
> package/rpm/rpm.mk | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/package/rpm/Config.in b/package/rpm/Config.in
> index 5ec4167..fe7a38a 100644
> --- a/package/rpm/Config.in
> +++ b/package/rpm/Config.in
> @@ -31,6 +31,7 @@ config BR2_PACKAGE_RPM_BZIP2_PAYLOADS
> config BR2_PACKAGE_RPM_XZ_PAYLOADS
> bool "support for xz payloads"
> depends on BR2_INSTALL_LIBSTDCPP
> + select BR2_PACKAGE_XZ
I know you are fixing existing code, but we usually do not have such
sub-options, and we instead rely entirely on the dependant package in
the .mk, without adding such sub-options...
> help
> Support for xz payloads in RPM.
>
> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> index 74f5b88..ce7189e 100644
> --- a/package/rpm/rpm.mk
> +++ b/package/rpm/rpm.mk
> @@ -45,7 +45,10 @@ RPM_CONF_OPTS += --with-file=no
> endif
>
> ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
> -RPM_CONF_OPTS += --with-xz
> +RPM_CONF_OPTS += --with-xz=external
> +RPM_DEPENDENCIES += xz
> +else
> +RPM_CONF_OPTS += --with-xz=none
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> endif
>
> ifeq ($(BR2_PACKAGE_RPM_BZIP2_PAYLOADS),y)
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path
2015-01-18 11:35 ` [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path Romain Naour
@ 2015-01-18 15:01 ` Yann E. MORIN
0 siblings, 0 replies; 8+ messages in thread
From: Yann E. MORIN @ 2015-01-18 15:01 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2015-01-18 12:35 +0100, Romain Naour spake thusly:
> The recognized keywords are:
> (location path: "external:internal:none")
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, some comments below...
> ---
> package/rpm/rpm.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> index ce7189e..6725ca4 100644
> --- a/package/rpm/rpm.mk
> +++ b/package/rpm/rpm.mk
> @@ -34,14 +34,14 @@ ifeq ($(BR2_PACKAGE_PCRE),y)
... here ...
> RPM_DEPENDENCIES += pcre
> RPM_CONF_OPTS += --with-pcre=external
> else
> -RPM_CONF_OPTS += --with-pcre=no
> +RPM_CONF_OPTS += --with-pcre=none
> endif
>
> ifeq ($(BR2_PACKAGE_FILE),y)
... and here, we do rely on the dependant packages, without adding
sub-options to rpm to select them. I think we should do the same for
bzip2 and xz.
Regards,
Yann E. MORIN.
> RPM_DEPENDENCIES += file
> RPM_CONF_OPTS += --with-file=external
> else
> -RPM_CONF_OPTS += --with-file=no
> +RPM_CONF_OPTS += --with-file=none
> endif
>
> ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency
2015-01-18 14:21 ` [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Yann E. MORIN
@ 2015-01-18 18:57 ` Romain Naour
0 siblings, 0 replies; 8+ messages in thread
From: Romain Naour @ 2015-01-18 18:57 UTC (permalink / raw)
To: buildroot
Hi Yann, all
Le 18/01/2015 15:21, Yann E. MORIN a ?crit :
> Romain, All,
>
> On 2015-01-18 12:34 +0100, Romain Naour spake thusly:
>> rpm check for libintl library if BR2_NEEDS_GETTEXT_IF_LOCALE is set.
>>
>> checking for GNU gettext in libintl... yes
>> checking whether to use NLS... yes
>> checking where the gettext function comes from... external libintl
>> checking how to link with libintl... -lintl
>
> Do you ave a defconfig with which I could test, please?
Yes, see:
http://autobuild.buildroot.net/results/2c6/2c61562008418ff58fa3085a3342b0e304923073/config
I'm fixing a autobuild failure, but while doing 'make rpm' the failure didn't
happened. So I make a diff with my build.log and the build-end.log provided by
the autobuilder. That is how I found the missing dependency on gettext.
>
>> But the dependency on gettext package is missing to ensures
>> reproducible builds.
>>
>> Also, sort selected packages alphabetically in Config.in
>
> I would prefer we do not mix feature changes with eye-candy, it makes
> reviewing a bit more complicated than it should be. Next time, could you
> just do that in a different patch, please?
Yes, sorry.
While rebasing to clean up this series, I wasn't happy that the select
BR2_PACKAGE_* wasn't alphabetically sorted.
I'll do that in a other patch.
Thanks for your review :)
Best regards,
Romain
>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> package/rpm/Config.in | 7 ++++---
>> package/rpm/rpm.mk | 4 ++++
>> 2 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/rpm/Config.in b/package/rpm/Config.in
>> index 620eb1a..5ec4167 100644
>> --- a/package/rpm/Config.in
>> +++ b/package/rpm/Config.in
>> @@ -7,12 +7,13 @@ config BR2_PACKAGE_RPM
>> depends on BR2_TOOLCHAIN_HAS_THREADS # beecrypt
>> depends on BR2_USE_MMU # fork()
>> select BR2_PACKAGE_BEECRYPT
>> - select BR2_PACKAGE_POPT
>> - select BR2_PACKAGE_OPENSSL
>> + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
>> select BR2_PACKAGE_NEON
>> + select BR2_PACKAGE_NEON_SSL
>> select BR2_PACKAGE_NEON_XML
>> select BR2_PACKAGE_NEON_ZLIB
>> - select BR2_PACKAGE_NEON_SSL
>> + select BR2_PACKAGE_OPENSSL
>> + select BR2_PACKAGE_POPT
>> select BR2_PACKAGE_ZLIB
>> help
>> The RPM package management system.
>> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
>> index c4215b5..74f5b88 100644
>> --- a/package/rpm/rpm.mk
>> +++ b/package/rpm/rpm.mk
>> @@ -26,6 +26,10 @@ RPM_CONF_OPTS = \
>> --with-libbeecrypt=$(STAGING_DIR) \
>> --with-popt=$(STAGING_DIR)
>>
>> +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
>> +RPM_DEPENDENCIES += gettext
>> +endif
>> +
>> ifeq ($(BR2_PACKAGE_PCRE),y)
>> RPM_DEPENDENCIES += pcre
>> RPM_CONF_OPTS += --with-pcre=external
>> --
>> 1.9.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 2/3] package/rpm: use external xz library
2015-01-18 14:59 ` Yann E. MORIN
@ 2015-01-18 18:57 ` Romain Naour
0 siblings, 0 replies; 8+ messages in thread
From: Romain Naour @ 2015-01-18 18:57 UTC (permalink / raw)
To: buildroot
Hi Yann, all
Le 18/01/2015 15:59, Yann E. MORIN a ?crit :
> Romain, All,
>
> On 2015-01-18 12:34 +0100, Romain Naour spake thusly:
>> Fixes:
>> http://autobuild.buildroot.net/results/2c6/2c61562008418ff58fa3085a3342b0e304923073/
>
> Weird, this build error is about being unable to link with libintl.so
> (indeed while building the xz backend, but still about libintl).
I seems that the internal xz backend is statically linked and needs libintl
library when BR2_NEEDS_GETTEXT_IF_LOCALE is set. But since it's a shared only
build, there is no static libintl available in the sysroot.
>
> Igues I could use that autobuild failure to test your patch 1/3,
> though...
Yes.
>
> Otherwise, I have some comments, see below...
>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> package/rpm/Config.in | 1 +
>> package/rpm/rpm.mk | 5 ++++-
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/rpm/Config.in b/package/rpm/Config.in
>> index 5ec4167..fe7a38a 100644
>> --- a/package/rpm/Config.in
>> +++ b/package/rpm/Config.in
>> @@ -31,6 +31,7 @@ config BR2_PACKAGE_RPM_BZIP2_PAYLOADS
>> config BR2_PACKAGE_RPM_XZ_PAYLOADS
>> bool "support for xz payloads"
>> depends on BR2_INSTALL_LIBSTDCPP
>> + select BR2_PACKAGE_XZ
>
> I know you are fixing existing code, but we usually do not have such
> sub-options, and we instead rely entirely on the dependant package in
> the .mk, without adding such sub-options...
OK, I will update this series and remove BR2_PACKAGE_RPM_BZIP2_PAYLOADS and
BR2_PACKAGE_RPM_XZ_PAYLOADS in Config.in, then modify
BR2_PACKAGE_RPM_XZ_PAYLOADS by BR2_PACKAGE_XZ (the same for bzip2) in the .mk
By the way, what's the use case for rpm and opkg for a rootfs build with Buildroot ?
Best regards,
Romain
>
>> help
>> Support for xz payloads in RPM.
>>
>> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
>> index 74f5b88..ce7189e 100644
>> --- a/package/rpm/rpm.mk
>> +++ b/package/rpm/rpm.mk
>> @@ -45,7 +45,10 @@ RPM_CONF_OPTS += --with-file=no
>> endif
>>
>> ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
>> -RPM_CONF_OPTS += --with-xz
>> +RPM_CONF_OPTS += --with-xz=external
>> +RPM_DEPENDENCIES += xz
>> +else
>> +RPM_CONF_OPTS += --with-xz=none
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
>
>> endif
>>
>> ifeq ($(BR2_PACKAGE_RPM_BZIP2_PAYLOADS),y)
>> --
>> 1.9.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-18 18:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-18 11:34 [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Romain Naour
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
2015-01-18 14:59 ` Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
2015-01-18 11:35 ` [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path Romain Naour
2015-01-18 15:01 ` Yann E. MORIN
2015-01-18 14:21 ` [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox