Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source
Date: Wed, 21 Jan 2015 19:19:54 +0100	[thread overview]
Message-ID: <20150121181954.GI4375@free.fr> (raw)
In-Reply-To: <54B802AD.2070701@zacarias.com.ar>

Zoltan, All,

On 2015-01-15 15:10 -0300, Gustavo Zacarias spake thusly:
> On 01/13/2015 09:37 PM, Zoltan Gyarmati wrote:
> 
> > Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> > ---
> >  package/pppd/Config.in | 8 ++++++++
> >  package/pppd/pppd.mk   | 5 +++++
> >  2 files changed, 13 insertions(+)
> > 
> > diff --git a/package/pppd/Config.in b/package/pppd/Config.in
> > index b77d7b0..6933fcf 100644
> > --- a/package/pppd/Config.in
> > +++ b/package/pppd/Config.in
> > @@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS
> >  	help
> >  	  Install RADIUS support for pppd
> >  
> > +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS
> > +	string "Install these PPP scripts"
> > +	default ""
> > +	help
> > +	  Space delimited list to specify which scripts
> > +	  need to be installed from pppd source tree's
> > +	  scripts directory
> > +
> 
> Hi.
> Isn't just simpler to copy those scripts that are useful/have no extra
> dependencies (like bash, expect, perl)?
> Otherwise it's just like a post-build script.
> Regards.

I concur with Gustavo: just install them, conditionally to the required
package being enabled, like:

  - needs nothing? Install it.
  - needs bash? Install if bash is 'y'.
  - And so on...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-01-21 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  0:37 [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source Zoltan Gyarmati
2015-01-15 18:10 ` Gustavo Zacarias
2015-01-21 18:19   ` Yann E. MORIN [this message]
2015-01-21 20:46     ` Zoltan Gyarmati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121181954.GI4375@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox