* [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source
@ 2015-01-14 0:37 Zoltan Gyarmati
2015-01-15 18:10 ` Gustavo Zacarias
0 siblings, 1 reply; 4+ messages in thread
From: Zoltan Gyarmati @ 2015-01-14 0:37 UTC (permalink / raw)
To: buildroot
Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
---
package/pppd/Config.in | 8 ++++++++
package/pppd/pppd.mk | 5 +++++
2 files changed, 13 insertions(+)
diff --git a/package/pppd/Config.in b/package/pppd/Config.in
index b77d7b0..6933fcf 100644
--- a/package/pppd/Config.in
+++ b/package/pppd/Config.in
@@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS
help
Install RADIUS support for pppd
+config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS
+ string "Install these PPP scripts"
+ default ""
+ help
+ Space delimited list to specify which scripts
+ need to be installed from pppd source tree's
+ scripts directory
+
endif
comment "pppd needs a toolchain w/ dynamic library"
diff --git a/package/pppd/pppd.mk b/package/pppd/pppd.mk
index 453445b..34e1d59 100644
--- a/package/pppd/pppd.mk
+++ b/package/pppd/pppd.mk
@@ -14,6 +14,7 @@ PPPD_LICENSE_FILES = \
PPPD_INSTALL_STAGING = YES
PPPD_TARGET_BINS = chat pppd pppdump pppstats
+PPPD_TARGET_SCRIPTS = $(call qstrip,$(BR2_PACKAGE_PPPD_INSTALL_SCRIPTS))
PPPD_RADIUS_CONF = \
dictionary dictionary.ascend dictionary.compat \
dictionary.merit dictionary.microsoft \
@@ -83,6 +84,10 @@ define PPPD_INSTALL_TARGET_CMDS
$(INSTALL) -D $(PPPD_DIR)/$$sbin/$$sbin \
$(TARGET_DIR)/usr/sbin/$$sbin; \
done
+ for scriptfile in $(PPPD_TARGET_SCRIPTS); do \
+ $(INSTALL) -D $(PPPD_DIR)/scripts/$$scriptfile \
+ $(TARGET_DIR)/usr/sbin/; \
+ done
$(INSTALL) -D $(PPPD_DIR)/pppd/plugins/minconn.so \
$(TARGET_DIR)/usr/lib/pppd/$(PPPD_VERSION)/minconn.so
$(INSTALL) -D $(PPPD_DIR)/pppd/plugins/passprompt.so \
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source
2015-01-14 0:37 [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source Zoltan Gyarmati
@ 2015-01-15 18:10 ` Gustavo Zacarias
2015-01-21 18:19 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2015-01-15 18:10 UTC (permalink / raw)
To: buildroot
On 01/13/2015 09:37 PM, Zoltan Gyarmati wrote:
> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> ---
> package/pppd/Config.in | 8 ++++++++
> package/pppd/pppd.mk | 5 +++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/package/pppd/Config.in b/package/pppd/Config.in
> index b77d7b0..6933fcf 100644
> --- a/package/pppd/Config.in
> +++ b/package/pppd/Config.in
> @@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS
> help
> Install RADIUS support for pppd
>
> +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS
> + string "Install these PPP scripts"
> + default ""
> + help
> + Space delimited list to specify which scripts
> + need to be installed from pppd source tree's
> + scripts directory
> +
Hi.
Isn't just simpler to copy those scripts that are useful/have no extra
dependencies (like bash, expect, perl)?
Otherwise it's just like a post-build script.
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source
2015-01-15 18:10 ` Gustavo Zacarias
@ 2015-01-21 18:19 ` Yann E. MORIN
2015-01-21 20:46 ` Zoltan Gyarmati
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2015-01-21 18:19 UTC (permalink / raw)
To: buildroot
Zoltan, All,
On 2015-01-15 15:10 -0300, Gustavo Zacarias spake thusly:
> On 01/13/2015 09:37 PM, Zoltan Gyarmati wrote:
>
> > Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> > ---
> > package/pppd/Config.in | 8 ++++++++
> > package/pppd/pppd.mk | 5 +++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/package/pppd/Config.in b/package/pppd/Config.in
> > index b77d7b0..6933fcf 100644
> > --- a/package/pppd/Config.in
> > +++ b/package/pppd/Config.in
> > @@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS
> > help
> > Install RADIUS support for pppd
> >
> > +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS
> > + string "Install these PPP scripts"
> > + default ""
> > + help
> > + Space delimited list to specify which scripts
> > + need to be installed from pppd source tree's
> > + scripts directory
> > +
>
> Hi.
> Isn't just simpler to copy those scripts that are useful/have no extra
> dependencies (like bash, expect, perl)?
> Otherwise it's just like a post-build script.
> Regards.
I concur with Gustavo: just install them, conditionally to the required
package being enabled, like:
- needs nothing? Install it.
- needs bash? Install if bash is 'y'.
- And so on...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source
2015-01-21 18:19 ` Yann E. MORIN
@ 2015-01-21 20:46 ` Zoltan Gyarmati
0 siblings, 0 replies; 4+ messages in thread
From: Zoltan Gyarmati @ 2015-01-21 20:46 UTC (permalink / raw)
To: buildroot
Dear Morin, Gustavo,
On 01/21/2015 07:19 PM, Yann E. MORIN wrote:
> Zoltan, All,
>
> On 2015-01-15 15:10 -0300, Gustavo Zacarias spake thusly:
>> On 01/13/2015 09:37 PM, Zoltan Gyarmati wrote:
>>
>>> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
>>> ---
>>> package/pppd/Config.in | 8 ++++++++
>>> package/pppd/pppd.mk | 5 +++++
>>> 2 files changed, 13 insertions(+)
>>>
>>> diff --git a/package/pppd/Config.in b/package/pppd/Config.in
>>> index b77d7b0..6933fcf 100644
>>> --- a/package/pppd/Config.in
>>> +++ b/package/pppd/Config.in
>>> @@ -22,6 +22,14 @@ config BR2_PACKAGE_PPPD_RADIUS
>>> help
>>> Install RADIUS support for pppd
>>>
>>> +config BR2_PACKAGE_PPPD_INSTALL_SCRIPTS
>>> + string "Install these PPP scripts"
>>> + default ""
>>> + help
>>> + Space delimited list to specify which scripts
>>> + need to be installed from pppd source tree's
>>> + scripts directory
>>> +
>>
>> Hi.
>> Isn't just simpler to copy those scripts that are useful/have no extra
>> dependencies (like bash, expect, perl)?
>> Otherwise it's just like a post-build script.
>> Regards.
>
> I concur with Gustavo: just install them, conditionally to the required
> package being enabled, like:
>
> - needs nothing? Install it.
> - needs bash? Install if bash is 'y'.
> - And so on...
OK, looking beck now it sounds better than my first approach, will
resend an updated patch, thanks for the review!
>
> Regards,
> Yann E. MORIN.
>
--
Bests,
Zoltan Gyarmati
IRC freenode: zgyarmati
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150121/6e79d5b3/attachment.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-21 20:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 0:37 [Buildroot] [PATCH 1/1] pppd: add config option to install scripts shipped with pppd's source Zoltan Gyarmati
2015-01-15 18:10 ` Gustavo Zacarias
2015-01-21 18:19 ` Yann E. MORIN
2015-01-21 20:46 ` Zoltan Gyarmati
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox