From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] qwt: compile as a static lib if QT_SHARED is not selected
Date: Fri, 23 Jan 2015 17:06:44 +0100 [thread overview]
Message-ID: <20150123160644.GC19129@free.fr> (raw)
In-Reply-To: <CACQ1gAhMPLWkod2SRKjDDS8mnDa6DknZnT0EHY5SZx_ENpg8mw@mail.gmail.com>
Richard, All,
On 2015-01-23 17:00 +0100, Richard Genoud spake thusly:
> 2015-01-20 17:45 GMT+01:00 Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com>:
> > Dear Richard Genoud,
> >
> > On Tue, 20 Jan 2015 11:17:28 +0100, Richard Genoud wrote:
> >> If Qt is compile as a static library, there's no point compiling qwt as
> >> a shared library, otherwise, we will have a huge qwt lib and a huge Qt
> >> application.
> >>
> >> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> >> ---
> >> package/qwt/qwt.mk | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/package/qwt/qwt.mk b/package/qwt/qwt.mk
> >> index a92d6b4b1540..d783314f7e40 100644
> >> --- a/package/qwt/qwt.mk
> >> +++ b/package/qwt/qwt.mk
> >> @@ -32,6 +32,12 @@ else
> >> QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtOpenGL.*$$/\# QWT_CONFIG += QwtOpenGL/'
> >> endif
> >>
> >> +ifeq ($(BR2_PACKAGE_QT_SHARED),y)
> >> + QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/QWT_CONFIG += QwtDll/'
> >> +else
> >> + QWT_CONFIG += -e 's/^.*QWT_CONFIG.*QwtDll.*$$/\# QWT_CONFIG += QwtDll/'
> >> +endif
> >
> > I think we should get rid of BR2_PACKAGE_QT_SHARED completely, and use
> > BR2_STATIC_LIBS here instead.
> you mean BR2_PREFER_STATIC_LIB, right ?
No, the option has been renamed in the tree, see:
http://git.buildroot.org/buildroot/commit/?id=665e13c85e1fd216499cdd335a88a4d1c20f175f
Please, use the master branch when hacking, you'll avoid surprises
later! ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-23 16:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 10:17 [Buildroot] [PATCH 1/2] qwt: compile as a static lib if QT_SHARED is not selected Richard Genoud
2015-01-20 10:17 ` [Buildroot] [PATCH 2/2] qwt: add license information Richard Genoud
2015-01-20 16:47 ` Thomas Petazzoni
2015-01-20 16:45 ` [Buildroot] [PATCH 1/2] qwt: compile as a static lib if QT_SHARED is not selected Thomas Petazzoni
2015-01-23 16:00 ` Richard Genoud
2015-01-23 16:06 ` Yann E. MORIN [this message]
2015-01-23 16:19 ` Richard Genoud
2015-01-25 22:20 ` Peter Korsgaard
2015-01-26 9:34 ` Richard Genoud
2015-01-26 9:54 ` Peter Korsgaard
2015-01-26 10:16 ` Richard Genoud
2015-01-26 11:21 ` Thomas Petazzoni
2015-01-26 17:00 ` Richard Genoud
2015-01-26 17:11 ` Thomas Petazzoni
2015-01-27 20:42 ` Arnout Vandecappelle
2015-01-27 20:55 ` Peter Korsgaard
2015-01-28 9:35 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123160644.GC19129@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox