From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
Date: Fri, 23 Jan 2015 19:31:27 +0100 [thread overview]
Message-ID: <20150123183127.GD19129@free.fr> (raw)
In-Reply-To: <1422036622-54535-1-git-send-email-ryan.barnett@rockwellcollins.com>
Ryan, All,
On 2015-01-23 12:10 -0600, Ryan Barnett spake thusly:
> When trying to compile a host-cmake-package type such as host-cdrkit,
> an error happens in regards to HOSTCC and HOSTCXX not being found.
>
> /bin/sh: HOSTCC: command not found
> /bin/sh: HOSTCXX: command not found
>
> This due to the fact that the environment is incorrectly configured by
> having the following:
>
> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
>
> This is due to having too many dollar signs. The fix is to remove the
> extra dollar sign.
>
> Also removing the unncessary quotes since the HOSTCC/HOSTCXX will
> already contain quotes. This could cause an issue with make as double
> quotes are not interpreted by make.
>
> Minor formatting fix too.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> Acked-by: Samuel Martin <s.martin49@gmail.com>
> CC: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> v1 -> v2
> - Implemented spacing and quote concerns from Yann E. MORIN and
> Samuel Marin.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> ---
> package/pkg-cmake.mk | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 1037513..e738ba9 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -22,13 +22,13 @@
>
> # Set compiler variables.
> ifeq ($(BR2_CCACHE),y)
> -CMAKE_HOST_C_COMPILER="$(HOST_DIR)/usr/bin/ccache"
> -CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
> -CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
> -CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
> +CMAKE_HOST_C_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
> +CMAKE_HOST_CXX_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
> +CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE)
> +CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE)
> else
> -CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
> -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
> +CMAKE_HOST_C_COMPILER = $(HOSTCC)
> +CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
> endif
>
> ################################################################################
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-23 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 18:10 [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type Ryan Barnett
2015-01-23 18:31 ` Yann E. MORIN [this message]
2015-01-23 19:34 ` Samuel Martin
-- strict thread matches above, loose matches on Subject: below --
2015-01-22 16:53 Ryan Barnett
2015-01-22 20:10 ` Samuel Martin
2015-01-23 15:50 ` Yann E. MORIN
2015-01-23 16:08 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123183127.GD19129@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox