* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
@ 2015-01-22 16:53 Ryan Barnett
2015-01-22 20:10 ` Samuel Martin
2015-01-23 15:50 ` Yann E. MORIN
0 siblings, 2 replies; 7+ messages in thread
From: Ryan Barnett @ 2015-01-22 16:53 UTC (permalink / raw)
To: buildroot
When trying to compile a host-cmake-package type such as host-cdrkit,
an error happens in regards to HOSTCC and HOSTCXX not being found.
/bin/sh: HOSTCC: command not found
/bin/sh: HOSTCXX: command not found
This due to the fact that the environment is incorrectly configured by
having the following:
-DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
This is due to having too many dollar signs. The fix is to remove the
extra dollar sign.
Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
---
package/pkg-cmake.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index 1037513..eac244f 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -27,8 +27,8 @@ CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
else
-CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
-CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
+CMAKE_HOST_C_COMPILER="$(HOSTCC)"
+CMAKE_HOST_CXX_COMPILER="$(HOSTCXX)"
endif
################################################################################
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
2015-01-22 16:53 Ryan Barnett
@ 2015-01-22 20:10 ` Samuel Martin
2015-01-23 15:50 ` Yann E. MORIN
1 sibling, 0 replies; 7+ messages in thread
From: Samuel Martin @ 2015-01-22 20:10 UTC (permalink / raw)
To: buildroot
On Thu, Jan 22, 2015 at 5:53 PM, Ryan Barnett
<ryan.barnett@rockwellcollins.com> wrote:
> When trying to compile a host-cmake-package type such as host-cdrkit,
> an error happens in regards to HOSTCC and HOSTCXX not being found.
>
> /bin/sh: HOSTCC: command not found
> /bin/sh: HOSTCXX: command not found
>
> This due to the fact that the environment is incorrectly configured by
> having the following:
>
> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
>
> This is due to having too many dollar signs. The fix is to remove the
> extra dollar sign.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
2015-01-22 16:53 Ryan Barnett
2015-01-22 20:10 ` Samuel Martin
@ 2015-01-23 15:50 ` Yann E. MORIN
2015-01-23 16:08 ` Samuel Martin
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2015-01-23 15:50 UTC (permalink / raw)
To: buildroot
Ryan, All,
On 2015-01-22 10:53 -0600, Ryan Barnett spake thusly:
> When trying to compile a host-cmake-package type such as host-cdrkit,
> an error happens in regards to HOSTCC and HOSTCXX not being found.
>
> /bin/sh: HOSTCC: command not found
> /bin/sh: HOSTCXX: command not found
>
> This due to the fact that the environment is incorrectly configured by
> having the following:
>
> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
As you may have noticed, the double-quaotes are doubled...
> This is due to having too many dollar signs. The fix is to remove the
> extra dollar sign.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> ---
> package/pkg-cmake.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 1037513..eac244f 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -27,8 +27,8 @@ CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
> CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
> CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
> else
> -CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
> -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
> +CMAKE_HOST_C_COMPILER="$(HOSTCC)"
> +CMAKE_HOST_CXX_COMPILER="$(HOSTCXX)"
That's because of here; in Makefile syntax, double-quotes are not
interpreted by make, and are part of the value.
So, you should also drop the double-quotes here.
Regards,
Yann E. MORIN.
> endif
>
> ################################################################################
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
2015-01-23 15:50 ` Yann E. MORIN
@ 2015-01-23 16:08 ` Samuel Martin
0 siblings, 0 replies; 7+ messages in thread
From: Samuel Martin @ 2015-01-23 16:08 UTC (permalink / raw)
To: buildroot
Yann, Ryan, all,
On Fri, Jan 23, 2015 at 4:50 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Ryan, All,
>
> On 2015-01-22 10:53 -0600, Ryan Barnett spake thusly:
>> When trying to compile a host-cmake-package type such as host-cdrkit,
>> an error happens in regards to HOSTCC and HOSTCXX not being found.
>>
>> /bin/sh: HOSTCC: command not found
>> /bin/sh: HOSTCXX: command not found
>>
>> This due to the fact that the environment is incorrectly configured by
>> having the following:
>>
>> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
>
> As you may have noticed, the double-quaotes are doubled...
>
>> This is due to having too many dollar signs. The fix is to remove the
>> extra dollar sign.
>>
>> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
>> ---
>> package/pkg-cmake.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
>> index 1037513..eac244f 100644
>> --- a/package/pkg-cmake.mk
>> +++ b/package/pkg-cmake.mk
>> @@ -27,8 +27,8 @@ CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
>> CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
>> CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
>> else
>> -CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
>> -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
>> +CMAKE_HOST_C_COMPILER="$(HOSTCC)"
>> +CMAKE_HOST_CXX_COMPILER="$(HOSTCXX)"
>
> That's because of here; in Makefile syntax, double-quotes are not
> interpreted by make, and are part of the value.
>
> So, you should also drop the double-quotes here.
While you are at cleaning this, adding 1 space before and after "="
will be good.
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
@ 2015-01-23 18:10 Ryan Barnett
2015-01-23 18:31 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Ryan Barnett @ 2015-01-23 18:10 UTC (permalink / raw)
To: buildroot
When trying to compile a host-cmake-package type such as host-cdrkit,
an error happens in regards to HOSTCC and HOSTCXX not being found.
/bin/sh: HOSTCC: command not found
/bin/sh: HOSTCXX: command not found
This due to the fact that the environment is incorrectly configured by
having the following:
-DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
This is due to having too many dollar signs. The fix is to remove the
extra dollar sign.
Also removing the unncessary quotes since the HOSTCC/HOSTCXX will
already contain quotes. This could cause an issue with make as double
quotes are not interpreted by make.
Minor formatting fix too.
Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
Acked-by: Samuel Martin <s.martin49@gmail.com>
CC: Yann E. MORIN <yann.morin.1998@free.fr>
---
v1 -> v2
- Implemented spacing and quote concerns from Yann E. MORIN and
Samuel Marin.
Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
---
package/pkg-cmake.mk | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index 1037513..e738ba9 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -22,13 +22,13 @@
# Set compiler variables.
ifeq ($(BR2_CCACHE),y)
-CMAKE_HOST_C_COMPILER="$(HOST_DIR)/usr/bin/ccache"
-CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
-CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
-CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
+CMAKE_HOST_C_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
+CMAKE_HOST_CXX_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
+CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE)
+CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE)
else
-CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
-CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
+CMAKE_HOST_C_COMPILER = $(HOSTCC)
+CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
endif
################################################################################
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
2015-01-23 18:10 [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type Ryan Barnett
@ 2015-01-23 18:31 ` Yann E. MORIN
2015-01-23 19:34 ` Samuel Martin
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2015-01-23 18:31 UTC (permalink / raw)
To: buildroot
Ryan, All,
On 2015-01-23 12:10 -0600, Ryan Barnett spake thusly:
> When trying to compile a host-cmake-package type such as host-cdrkit,
> an error happens in regards to HOSTCC and HOSTCXX not being found.
>
> /bin/sh: HOSTCC: command not found
> /bin/sh: HOSTCXX: command not found
>
> This due to the fact that the environment is incorrectly configured by
> having the following:
>
> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
>
> This is due to having too many dollar signs. The fix is to remove the
> extra dollar sign.
>
> Also removing the unncessary quotes since the HOSTCC/HOSTCXX will
> already contain quotes. This could cause an issue with make as double
> quotes are not interpreted by make.
>
> Minor formatting fix too.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> Acked-by: Samuel Martin <s.martin49@gmail.com>
> CC: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> v1 -> v2
> - Implemented spacing and quote concerns from Yann E. MORIN and
> Samuel Marin.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> ---
> package/pkg-cmake.mk | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 1037513..e738ba9 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -22,13 +22,13 @@
>
> # Set compiler variables.
> ifeq ($(BR2_CCACHE),y)
> -CMAKE_HOST_C_COMPILER="$(HOST_DIR)/usr/bin/ccache"
> -CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
> -CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
> -CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
> +CMAKE_HOST_C_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
> +CMAKE_HOST_CXX_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
> +CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE)
> +CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE)
> else
> -CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
> -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
> +CMAKE_HOST_C_COMPILER = $(HOSTCC)
> +CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
> endif
>
> ################################################################################
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type
2015-01-23 18:31 ` Yann E. MORIN
@ 2015-01-23 19:34 ` Samuel Martin
0 siblings, 0 replies; 7+ messages in thread
From: Samuel Martin @ 2015-01-23 19:34 UTC (permalink / raw)
To: buildroot
Hi Ryan,
On Fri, Jan 23, 2015 at 7:31 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Ryan, All,
>
> On 2015-01-23 12:10 -0600, Ryan Barnett spake thusly:
>> When trying to compile a host-cmake-package type such as host-cdrkit,
>> an error happens in regards to HOSTCC and HOSTCXX not being found.
>>
>> /bin/sh: HOSTCC: command not found
>> /bin/sh: HOSTCXX: command not found
>>
>> This due to the fact that the environment is incorrectly configured by
>> having the following:
>>
>> -DCMAKE_C_COMPILER=""$(HOSTCC)"" -DCMAKE_CXX_COMPILER=""$(HOSTCXX)""
>>
>> This is due to having too many dollar signs. The fix is to remove the
>> extra dollar sign.
>>
>> Also removing the unncessary quotes since the HOSTCC/HOSTCXX will
>> already contain quotes. This could cause an issue with make as double
>> quotes are not interpreted by make.
>>
>> Minor formatting fix too.
>>
>> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
>> Acked-by: Samuel Martin <s.martin49@gmail.com>
>> CC: Yann E. MORIN <yann.morin.1998@free.fr>
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> v1 -> v2
>> - Implemented spacing and quote concerns from Yann E. MORIN and
>> Samuel Marin.
>>
>> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
>> ---
>> package/pkg-cmake.mk | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
>> index 1037513..e738ba9 100644
>> --- a/package/pkg-cmake.mk
>> +++ b/package/pkg-cmake.mk
>> @@ -22,13 +22,13 @@
>>
>> # Set compiler variables.
>> ifeq ($(BR2_CCACHE),y)
>> -CMAKE_HOST_C_COMPILER="$(HOST_DIR)/usr/bin/ccache"
>> -CMAKE_HOST_CXX_COMPILER="$(HOST_DIR)/usr/bin/ccache"
>> -CMAKE_HOST_C_COMPILER_ARG1="$(HOSTCC_NOCCACHE)"
>> -CMAKE_HOST_CXX_COMPILER_ARG1="$(HOSTCXX_NOCCACHE)"
>> +CMAKE_HOST_C_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
>> +CMAKE_HOST_CXX_COMPILER = "$(HOST_DIR)/usr/bin/ccache"
No need for double quotes here (when used, this variable is surrounded
by quotes [1]).
Otherwise, it looks good.
>> +CMAKE_HOST_C_COMPILER_ARG1 = $(HOSTCC_NOCCACHE)
>> +CMAKE_HOST_CXX_COMPILER_ARG1 = $(HOSTCXX_NOCCACHE)
>> else
>> -CMAKE_HOST_C_COMPILER="$$(HOSTCC)"
>> -CMAKE_HOST_CXX_COMPILER="$$(HOSTCXX)"
>> +CMAKE_HOST_C_COMPILER = $(HOSTCC)
>> +CMAKE_HOST_CXX_COMPILER = $(HOSTCXX)
>> endif
>>
>> ################################################################################
>> --
>> 1.9.1
>>
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
[1] http://git.buildroot.net/buildroot/tree/package/pkg-cmake.mk#n110
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-23 19:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23 18:10 [Buildroot] [PATCH 1/1] pkg-cmake: fix host-cmake-package type Ryan Barnett
2015-01-23 18:31 ` Yann E. MORIN
2015-01-23 19:34 ` Samuel Martin
-- strict thread matches above, loose matches on Subject: below --
2015-01-22 16:53 Ryan Barnett
2015-01-22 20:10 ` Samuel Martin
2015-01-23 15:50 ` Yann E. MORIN
2015-01-23 16:08 ` Samuel Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox