[Buildroot] [PATCH] alsa-utils: needs dynamic library support

[Buildroot] [PATCH] alsa-utils: needs dynamic library support

[Baruch Siach]

Fixes:
http://autobuild.buildroot.net/results/314/314dac9f5e62ae9beb598eb1b4cb35c0a7bfe792/
http://autobuild.buildroot.net/results/964/964e44f0c1653370600c7e8c647abda3f6380e34/
http://autobuild.buildroot.net/results/d72/d72f31bab907c7485d03db4597d01fd759277db4/
...

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/alsa-utils/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
index cc667115084b..d8418639e394 100644
--- a/package/alsa-utils/Config.in
+++ b/package/alsa-utils/Config.in
@@ -1,12 +1,13 @@
-comment "alsa-utils needs a toolchain w/ largefile, threads"
+comment "alsa-utils needs a toolchain w/ largefile, threads, dynamic library"
 	depends on BR2_USE_MMU # fork
-	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
 
 config BR2_PACKAGE_ALSA_UTILS
 	bool "alsa-utils"
 	depends on BR2_USE_MMU # fork
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
-- 
2.1.4

[Buildroot] [PATCH] alsa-utils: needs dynamic library support

[Thomas Petazzoni]

Dear Baruch Siach,

On Tue, 27 Jan 2015 12:21:13 +0200, Baruch Siach wrote:
> Fixes:
> http://autobuild.buildroot.net/results/314/314dac9f5e62ae9beb598eb1b4cb35c0a7bfe792/
> http://autobuild.buildroot.net/results/964/964e44f0c1653370600c7e8c647abda3f6380e34/
> http://autobuild.buildroot.net/results/d72/d72f31bab907c7485d03db4597d01fd759277db4/
> ...
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/alsa-utils/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

I am not sure. alsa-utils hardcodes:

ALSA_LIBS="$ALSA_LIBS -lasound -lm -ldl -lpthread"

but in practice, alsa-lib does not necessarily depends on -ldl.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] alsa-utils: needs dynamic library support

[Baruch Siach]

Hi Thomas,

On Tue, Jan 27, 2015 at 01:52:20PM +0100, Thomas Petazzoni wrote:
> On Tue, 27 Jan 2015 12:21:13 +0200, Baruch Siach wrote:
> > Fixes:
> > http://autobuild.buildroot.net/results/314/314dac9f5e62ae9beb598eb1b4cb35c0a7bfe792/
> > http://autobuild.buildroot.net/results/964/964e44f0c1653370600c7e8c647abda3f6380e34/
> > http://autobuild.buildroot.net/results/d72/d72f31bab907c7485d03db4597d01fd759277db4/
> > ...
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/alsa-utils/Config.in | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> I am not sure. alsa-utils hardcodes:
> 
> ALSA_LIBS="$ALSA_LIBS -lasound -lm -ldl -lpthread"
> 
> but in practice, alsa-lib does not necessarily depends on -ldl.

Indeed. Now I see that commit ffd7a00aef723 (alsa-lib: add patch to remove 
hardcoded -ldl) intended to fix that exact same issue. Though it seems like we 
need to AUTORECONF alsa-utils for this fix to take effect, isn't it?. Thomas 
(DS)?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] alsa-utils: needs dynamic library support

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 >> ALSA_LIBS="$ALSA_LIBS -lasound -lm -ldl -lpthread"
 >> 
 >> but in practice, alsa-lib does not necessarily depends on -ldl.

 > Indeed. Now I see that commit ffd7a00aef723 (alsa-lib: add patch to remove 
 > hardcoded -ldl) intended to fix that exact same issue. Though it seems like we 
 > need to AUTORECONF alsa-utils for this fix to take effect, isn't it?. Thomas 
 > (DS)?

Yes, as far as I can see we just need to autoreconf/gettextize
alsa-utils to get it to pick up the alsa-lib change.

-- 
Bye, Peter Korsgaard