Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] batctl: new package
Date: Sun, 8 Feb 2015 21:23:58 +0100	[thread overview]
Message-ID: <20150208212358.3cbe7337@free-electrons.com> (raw)
In-Reply-To: <1423424838-5348-1-git-send-email-zettelmeyerj@goooglemail.com>

Dear Jens Zettelmeyer,

On Sun,  8 Feb 2015 19:47:18 +0000, Jens Zettelmeyer wrote:
> From: user <zettelmeyerj@goooglemail.com>

Does not look good.

> Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
> ---
>  package/Config.in          |  1 +
>  package/batctl/Config.in   |  9 +++++++++
>  package/batctl/batctl.hash |  2 ++
>  package/batctl/batctl.mk   | 23 +++++++++++++++++++++++
>  4 files changed, 35 insertions(+)
>  create mode 100644 package/batctl/Config.in
>  create mode 100644 package/batctl/batctl.hash
>  create mode 100644 package/batctl/batctl.mk

Also, you have taken into account none of the comments I made at:
http://lists.busybox.net/pipermail/buildroot/2015-February/118951.html.

Can you look at these comments?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-02-08 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 19:47 [Buildroot] [PATCH 1/1] batctl: new package Jens Zettelmeyer
2015-02-08 20:23 ` Thomas Petazzoni [this message]
2015-02-08 20:29   ` Jens Zettelmeyer
  -- strict thread matches above, loose matches on Subject: below --
2015-02-09 20:22 Jens Zettelmeyer
2015-02-09 21:48 ` Thomas Petazzoni
2015-02-08 19:23 user

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150208212358.3cbe7337@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox