* [Buildroot] [PATCH 1/1] batctl: new package
@ 2015-02-08 19:47 Jens Zettelmeyer
2015-02-08 20:23 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Jens Zettelmeyer @ 2015-02-08 19:47 UTC (permalink / raw)
To: buildroot
From: user <zettelmeyerj@goooglemail.com>
Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
---
package/Config.in | 1 +
package/batctl/Config.in | 9 +++++++++
package/batctl/batctl.hash | 2 ++
package/batctl/batctl.mk | 23 +++++++++++++++++++++++
4 files changed, 35 insertions(+)
create mode 100644 package/batctl/Config.in
create mode 100644 package/batctl/batctl.hash
create mode 100644 package/batctl/batctl.mk
diff --git a/package/Config.in b/package/Config.in
index fe3d3d0..b9d6753 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1055,6 +1055,7 @@ menu "Networking applications"
source "package/avahi/Config.in"
source "package/axel/Config.in"
source "package/bandwidthd/Config.in"
+ source "package/batctl/Config.in"
source "package/bcusdk/Config.in"
source "package/bind/Config.in"
source "package/bluez_utils/Config.in"
diff --git a/package/batctl/Config.in b/package/batctl/Config.in
new file mode 100644
index 0000000..56badd3
--- /dev/null
+++ b/package/batctl/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_BATCTL
+ bool "batctl"
+ depends on BR2_INET_IPV6
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBNL
+ help
+ Batctl is the configuration and debugging tool for batman-adv.
+
+ http://www.open-mesh.org/projects/batman-adv/wiki/Using-batctl
diff --git a/package/batctl/batctl.hash b/package/batctl/batctl.hash
new file mode 100644
index 0000000..663e602
--- /dev/null
+++ b/package/batctl/batctl.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 77509ed70232ebc0b73e2fa9471ae13b12d6547d167dda0a82f7a7fad7252c36 batctl-2014.4.0.tar.gz
diff --git a/package/batctl/batctl.mk b/package/batctl/batctl.mk
new file mode 100644
index 0000000..a65a5cd
--- /dev/null
+++ b/package/batctl/batctl.mk
@@ -0,0 +1,23 @@
+################################################################################
+#
+# batman-adv control
+#
+################################################################################
+
+BATCTL_VERSION = 2014.4.0
+BATCTL_SOURCE = batctl-$(BATCTL_VERSION).tar.gz
+BATCTL_SITE = http://downloads.open-mesh.org/batman/releases/batman-adv-$(BATCTL_VERSION)
+BATCTL_LICENSE = GPLv2
+BATCTL_DEPENDENCIES += libnl
+
+define BATCTL_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3" \
+ LDFLAGS="$(TARGET_LDFLAGS)"
+endef
+
+define BATCTL_INSTALL_TARGET_CMDS
+ $(INSTALL) -m 755 -D $(@D)/batctl $(TARGET_DIR)/usr/sbin/batctl
+endef
+
+$(eval $(generic-package))
--
2.0.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] batctl: new package
2015-02-08 19:47 [Buildroot] [PATCH 1/1] batctl: new package Jens Zettelmeyer
@ 2015-02-08 20:23 ` Thomas Petazzoni
2015-02-08 20:29 ` Jens Zettelmeyer
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2015-02-08 20:23 UTC (permalink / raw)
To: buildroot
Dear Jens Zettelmeyer,
On Sun, 8 Feb 2015 19:47:18 +0000, Jens Zettelmeyer wrote:
> From: user <zettelmeyerj@goooglemail.com>
Does not look good.
> Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
> ---
> package/Config.in | 1 +
> package/batctl/Config.in | 9 +++++++++
> package/batctl/batctl.hash | 2 ++
> package/batctl/batctl.mk | 23 +++++++++++++++++++++++
> 4 files changed, 35 insertions(+)
> create mode 100644 package/batctl/Config.in
> create mode 100644 package/batctl/batctl.hash
> create mode 100644 package/batctl/batctl.mk
Also, you have taken into account none of the comments I made at:
http://lists.busybox.net/pipermail/buildroot/2015-February/118951.html.
Can you look at these comments?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] batctl: new package
2015-02-08 20:23 ` Thomas Petazzoni
@ 2015-02-08 20:29 ` Jens Zettelmeyer
0 siblings, 0 replies; 6+ messages in thread
From: Jens Zettelmeyer @ 2015-02-08 20:29 UTC (permalink / raw)
To: buildroot
Hi,
oh you are right, haven't seen all those comments. I'll try to adjust the
file accordingly.
And i'll try to find out where this "user" is comming from.
Thank you
Jens
2015-02-08 20:23 GMT+00:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:
> Dear Jens Zettelmeyer,
>
> On Sun, 8 Feb 2015 19:47:18 +0000, Jens Zettelmeyer wrote:
> > From: user <zettelmeyerj@goooglemail.com>
>
> Does not look good.
>
> > Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
> > ---
> > package/Config.in | 1 +
> > package/batctl/Config.in | 9 +++++++++
> > package/batctl/batctl.hash | 2 ++
> > package/batctl/batctl.mk | 23 +++++++++++++++++++++++
> > 4 files changed, 35 insertions(+)
> > create mode 100644 package/batctl/Config.in
> > create mode 100644 package/batctl/batctl.hash
> > create mode 100644 package/batctl/batctl.mk
>
> Also, you have taken into account none of the comments I made at:
> http://lists.busybox.net/pipermail/buildroot/2015-February/118951.html.
>
> Can you look at these comments?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150208/f60384ce/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] batctl: new package
@ 2015-02-09 20:22 Jens Zettelmeyer
2015-02-09 21:48 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Jens Zettelmeyer @ 2015-02-09 20:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
---
package/Config.in | 1 +
package/batctl/Config.in | 12 ++++++++++++
package/batctl/batctl.hash | 2 ++
package/batctl/batctl.mk | 21 +++++++++++++++++++++
4 files changed, 36 insertions(+)
create mode 100644 package/batctl/Config.in
create mode 100644 package/batctl/batctl.hash
create mode 100644 package/batctl/batctl.mk
diff --git a/package/Config.in b/package/Config.in
index fe3d3d0..b9d6753 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1055,6 +1055,7 @@ menu "Networking applications"
source "package/avahi/Config.in"
source "package/axel/Config.in"
source "package/bandwidthd/Config.in"
+ source "package/batctl/Config.in"
source "package/bcusdk/Config.in"
source "package/bind/Config.in"
source "package/bluez_utils/Config.in"
diff --git a/package/batctl/Config.in b/package/batctl/Config.in
new file mode 100644
index 0000000..03ee991
--- /dev/null
+++ b/package/batctl/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_BATCTL
+ bool "batctl"
+ depends on BR2_INET_IPV6
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBNL
+ help
+ Batctl is the configuration and debugging tool for batman-adv.
+
+ http://www.open-mesh.org/projects/batman-adv/wiki/Using-batctl
+
+comment "batctl needs a toolchain w/ IPv6, threads"
+ depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS # libnl
diff --git a/package/batctl/batctl.hash b/package/batctl/batctl.hash
new file mode 100644
index 0000000..663e602
--- /dev/null
+++ b/package/batctl/batctl.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 77509ed70232ebc0b73e2fa9471ae13b12d6547d167dda0a82f7a7fad7252c36 batctl-2014.4.0.tar.gz
diff --git a/package/batctl/batctl.mk b/package/batctl/batctl.mk
new file mode 100644
index 0000000..9974e29
--- /dev/null
+++ b/package/batctl/batctl.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# batctl
+#
+################################################################################
+
+BATCTL_VERSION = 2014.4.0
+BATCTL_SOURCE = batctl-$(BATCTL_VERSION).tar.gz
+BATCTL_SITE = http://downloads.open-mesh.org/batman/releases/batman-adv-$(BATCTL_VERSION)
+BATCTL_LICENSE = GPLv2
+BATCTL_DEPENDENCIES = libnl host-pkgconf
+
+define BATCTL_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
+endef
+
+define BATCTL_INSTALL_TARGET_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) PREFIX=/usr DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
--
2.0.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] batctl: new package
2015-02-09 20:22 Jens Zettelmeyer
@ 2015-02-09 21:48 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2015-02-09 21:48 UTC (permalink / raw)
To: buildroot
Dear Jens Zettelmeyer,
On Mon, 9 Feb 2015 20:22:18 +0000, Jens Zettelmeyer wrote:
> Signed-off-by: Jens Zettelmeyer <zettelmeyerj@goooglemail.com>
> ---
> package/Config.in | 1 +
> package/batctl/Config.in | 12 ++++++++++++
> package/batctl/batctl.hash | 2 ++
> package/batctl/batctl.mk | 21 +++++++++++++++++++++
> 4 files changed, 36 insertions(+)
> create mode 100644 package/batctl/Config.in
> create mode 100644 package/batctl/batctl.hash
> create mode 100644 package/batctl/batctl.mk
Thanks, I've applied your patch to the next branch, with a small number
of modifications:
[Thomas:
- remove trailing whitespace
- remove "# libnl" comment in Config.in
- remove BATCTL_SOURCE, which is not needed, since the default value
is used
- pass $(TARGET_CONFIGURE_OPTS) in the make environment, not as a
make option, otherwise the CFLAGS += lines of batctl Makefile do
not have any effect, and lead to not have the proper include path
to the libnl header files.]
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] batctl: new package
@ 2015-02-08 19:23 user
0 siblings, 0 replies; 6+ messages in thread
From: user @ 2015-02-08 19:23 UTC (permalink / raw)
To: buildroot
Signed-off-by: user <zettelmeyerj@goooglemail.com>
---
package/Config.in | 1 +
package/batctl/Config.in | 29 +++++++++++++++++++++++++++++
package/batctl/batctl.hash | 2 ++
package/batctl/batctl.mk | 43 +++++++++++++++++++++++++++++++++++++++++++
4 files changed, 75 insertions(+)
create mode 100644 package/batctl/Config.in
create mode 100644 package/batctl/batctl.hash
create mode 100644 package/batctl/batctl.mk
diff --git a/package/Config.in b/package/Config.in
index fe3d3d0..b9d6753 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1055,6 +1055,7 @@ menu "Networking applications"
source "package/avahi/Config.in"
source "package/axel/Config.in"
source "package/bandwidthd/Config.in"
+ source "package/batctl/Config.in"
source "package/bcusdk/Config.in"
source "package/bind/Config.in"
source "package/bluez_utils/Config.in"
diff --git a/package/batctl/Config.in b/package/batctl/Config.in
new file mode 100644
index 0000000..fed4c4d
--- /dev/null
+++ b/package/batctl/Config.in
@@ -0,0 +1,29 @@
+config BR2_PACKAGE_BATCTL
+ bool "batctl"
+<<<<<<< HEAD
+<<<<<<< HEAD
+ depends on BR2_INET_IPV6
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBNL
+ help
+ Batctl is the configuration and debugging tool for batman-adv.
+
+ http://www.open-mesh.org/projects/batman-adv/wiki/Using-batctl
+=======
+ depends on BR2_USE_MMU # needs fork()
+=======
+>>>>>>> eb3c5ae... Change build according to advises from Yann E. MORIN
+ depends on BR2_INET_IPV6
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBNL
+ help
+<<<<<<< HEAD
+ batman-adv controll utility
+
+ http://www.open-mesh.org/projects/open-mesh/wiki
+>>>>>>> f570503... Add build for B.A.T.M.A.N. Advanced control utility
+=======
+ Batctl is the configuration and debugging tool for batman-adv.
+
+ http://www.open-mesh.org/projects/batman-adv/wiki/Using-batctl
+>>>>>>> eb3c5ae... Change build according to advises from Yann E. MORIN
diff --git a/package/batctl/batctl.hash b/package/batctl/batctl.hash
new file mode 100644
index 0000000..663e602
--- /dev/null
+++ b/package/batctl/batctl.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 77509ed70232ebc0b73e2fa9471ae13b12d6547d167dda0a82f7a7fad7252c36 batctl-2014.4.0.tar.gz
diff --git a/package/batctl/batctl.mk b/package/batctl/batctl.mk
new file mode 100644
index 0000000..3823e63
--- /dev/null
+++ b/package/batctl/batctl.mk
@@ -0,0 +1,43 @@
+################################################################################
+#
+# batman-adv control
+#
+################################################################################
+
+BATCTL_VERSION = 2014.4.0
+BATCTL_SOURCE = batctl-$(BATCTL_VERSION).tar.gz
+BATCTL_SITE = http://downloads.open-mesh.org/batman/releases/batman-adv-$(BATCTL_VERSION)
+<<<<<<< HEAD
+<<<<<<< HEAD
+BATCTL_LICENSE = GPLv2
+BATCTL_DEPENDENCIES += libnl
+
+define BATCTL_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC)" \
+ CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3" \
+ LDFLAGS="$(TARGET_LDFLAGS)"
+=======
+BATCTL_LICENSE = GPLv2+
+=======
+BATCTL_LICENSE = GPLv2
+>>>>>>> eb3c5ae... Change build according to advises from Yann E. MORIN
+BATCTL_DEPENDENCIES += libnl
+
+define BATCTL_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC)" \
+<<<<<<< HEAD
+ CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3" \
+ DBM_INCLUDE="$(STAGING_DIR)/usr/include" \
+ LDFLAGS="$(TARGET_LDFLAGS)"
+>>>>>>> f570503... Add build for B.A.T.M.A.N. Advanced control utility
+=======
+ CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3" \
+ LDFLAGS="$(TARGET_LDFLAGS)"
+>>>>>>> eb3c5ae... Change build according to advises from Yann E. MORIN
+endef
+
+define BATCTL_INSTALL_TARGET_CMDS
+ $(INSTALL) -m 755 -D $(@D)/batctl $(TARGET_DIR)/usr/sbin/batctl
+endef
+
+$(eval $(generic-package))
--
2.0.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-09 21:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 19:47 [Buildroot] [PATCH 1/1] batctl: new package Jens Zettelmeyer
2015-02-08 20:23 ` Thomas Petazzoni
2015-02-08 20:29 ` Jens Zettelmeyer
-- strict thread matches above, loose matches on Subject: below --
2015-02-09 20:22 Jens Zettelmeyer
2015-02-09 21:48 ` Thomas Petazzoni
2015-02-08 19:23 user
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox