[Buildroot] [PATCH] gcc: 4.9.2: Add patch to remove a wrong header

[Buildroot] [PATCH] gcc: 4.9.2: Add patch to remove a wrong header

[Ezequiel Garcia]

This commit adds a patch to gcc removing a unistd.h header include
in libgcc/config/nios2/linux-atomic.c

The file is built as part of GCC first stage (host-gcc-initial),
and so the header is not accesible. Given the header is not needed
it's fine to simply remove it.

Chung-Lin Tang (GCC nios2 maintainer) confirmed patch is good:
""
Thanks for noticing, this part appears to be unneeded now that Nios II
uses a kernel provided user function for Linux atomic operations. I'll
remove the include, and the #define's as well in upstream GCC.
""

This commit is required to build a Nios-II internal toolchain.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch

diff --git a/package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch b/package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch
new file mode 100644
index 0000000..df5372b
--- /dev/null
+++ b/package/gcc/4.9.2/920-libgcc-remove-unistd-header.patch
@@ -0,0 +1,12 @@
+Upstream status: In progress
+
+--- a/libgcc/config/nios2/linux-atomic.c
++++ b/libgcc/config/nios2/linux-atomic.c
+@@ -20,7 +20,6 @@
+ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
+ <http://www.gnu.org/licenses/>.  */
+ 
+-#include <asm/unistd.h>
+ #define EFAULT  14
+ #define EBUSY   16
+ #define ENOSYS  38
-- 
2.2.1

[Buildroot] [PATCH] gcc: 4.9.2: Add patch to remove a wrong header

[Peter Korsgaard]

>>>>> "Ezequiel" == Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

 > This commit adds a patch to gcc removing a unistd.h header include
 > in libgcc/config/nios2/linux-atomic.c

 > The file is built as part of GCC first stage (host-gcc-initial),
 > and so the header is not accesible. Given the header is not needed
 > it's fine to simply remove it.

 > Chung-Lin Tang (GCC nios2 maintainer) confirmed patch is good:
 > ""
 > Thanks for noticing, this part appears to be unneeded now that Nios II
 > uses a kernel provided user function for Linux atomic operations. I'll
 > remove the include, and the #define's as well in upstream GCC.
 > ""

 > This commit is required to build a Nios-II internal toolchain.

I'll wait with this until you post the patches to actually build an
internal nios2 toolchain, ok?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] gcc: 4.9.2: Add patch to remove a wrong header

[Thomas Petazzoni]

Peter, Ezequiel,

On Thu, 12 Feb 2015 22:31:11 +0100, Peter Korsgaard wrote:

> I'll wait with this until you post the patches to actually build an
> internal nios2 toolchain, ok?

I have consequently marked this patch as Rejected in patchwork.
Ezequiel, please include it with the rest of the series adding NIOS II
support to the internal toolchain backend. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] gcc: 4.9.2: Add patch to remove a wrong header

[Ezequiel Garcia]

On 02/14/2015 05:12 AM, Thomas Petazzoni wrote:
> Peter, Ezequiel,
> 
> On Thu, 12 Feb 2015 22:31:11 +0100, Peter Korsgaard wrote:
> 
>> I'll wait with this until you post the patches to actually build an
>> internal nios2 toolchain, ok?
> 
> I have consequently marked this patch as Rejected in patchwork.
> Ezequiel, please include it with the rest of the series adding NIOS II
> support to the internal toolchain backend. Thanks!
> 

Sure, I will.

-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar