From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library
Date: Wed, 4 Mar 2015 23:29:09 +0100 [thread overview]
Message-ID: <20150304232909.625985fa@free-electrons.com> (raw)
In-Reply-To: <1425244013-2509-3-git-send-email-fabio.porcedda@gmail.com>
Dear Fabio Porcedda,
In the title: s/opt/popt/
On Sun, 1 Mar 2015 22:06:53 +0100, Fabio Porcedda wrote:
> Without using the pkg-config the dependencies are not included for a
> static linking so it fails to build.
> These failures are fixed by linking the libintl library that is a
> dependency of the opt library.
s/opt/popt/
I've fixed and committed. Though I have one concern below.
> + $(MAKE) CC="$(TARGET_CC) $(TARGET_CFLAGS)" LDFLAGS="$(LDFLAGS)" \
> + LOADLIBES="$(shell $(PKG_CONFIG_HOST_BINARY) --libs popt)" \
It's not currently supported in Buildroot, but LOADLIBES is extended by
the logrotate Makefile with -lacl or -lselinux when WITH_ACL or
WITH_SELINUX are used. I'm not sure this will play well with your
proposed solution.
But ok, this can be handled when/if someone adds ACL and/or SELinux
support to logrotate.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-04 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 21:06 [Buildroot] [PATCH v3 0/2] Fix logrotate autobuild failure Fabio Porcedda
2015-03-01 21:06 ` [Buildroot] [PATCH v3 1/2] popt: add to the "popt.pc" file the libintl library Fabio Porcedda
2015-03-04 22:27 ` Thomas Petazzoni
2015-03-01 21:06 ` [Buildroot] [PATCH v3 2/2] logrotate: use pkg-config for the opt library Fabio Porcedda
2015-03-04 22:29 ` Thomas Petazzoni [this message]
2015-03-04 23:38 ` Fabio Porcedda
2015-03-05 8:28 ` Thomas Petazzoni
2015-03-05 8:43 ` Fabio Porcedda
2015-03-01 21:35 ` [Buildroot] [PATCH v3 0/2] Fix logrotate autobuild failure Peter Korsgaard
2015-03-01 21:43 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304232909.625985fa@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox