* [Buildroot] [PATCH] linux: clarify kernel configuration entries
@ 2015-03-05 17:55 Vivien Didelot
2015-03-05 18:30 ` Yann E. MORIN
2015-03-05 20:18 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Vivien Didelot @ 2015-03-05 17:55 UTC (permalink / raw)
To: buildroot
Since BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE can either be a complete
.config file or a defconfig file, it can be confusing to the user
whether to choose BR2_LINUX_KERNEL_USE_DEFCONFIG or
BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG.
To avoid that confusion, clarify Kconfig entry messages for in-tree
defconfig and custom (def)config files.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
linux/Config.in | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/linux/Config.in b/linux/Config.in
index 95c847b..36d7691 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -140,10 +140,10 @@ choice
default BR2_LINUX_KERNEL_USE_DEFCONFIG
config BR2_LINUX_KERNEL_USE_DEFCONFIG
- bool "Using a defconfig"
+ bool "Using an in-tree defconfig file"
config BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG
- bool "Using a custom config file"
+ bool "Using a custom (def)config file"
endchoice
@@ -161,6 +161,9 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE
help
Path to the kernel configuration file
+ Note: this can be a defconfig file or a complete .config file,
+ which can later be saved back with make linux-update-(def)config.
+
#
# Binary format
#
--
2.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] linux: clarify kernel configuration entries
2015-03-05 17:55 [Buildroot] [PATCH] linux: clarify kernel configuration entries Vivien Didelot
@ 2015-03-05 18:30 ` Yann E. MORIN
2015-03-05 20:18 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-03-05 18:30 UTC (permalink / raw)
To: buildroot
Vivien, Thomas, All,
On 2015-03-05 12:55 -0500, Vivien Didelot spake thusly:
> Since BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE can either be a complete
> .config file or a defconfig file, it can be confusing to the user
> whether to choose BR2_LINUX_KERNEL_USE_DEFCONFIG or
> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG.
>
> To avoid that confusion, clarify Kconfig entry messages for in-tree
> defconfig and custom (def)config files.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> linux/Config.in | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/linux/Config.in b/linux/Config.in
> index 95c847b..36d7691 100644
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -140,10 +140,10 @@ choice
> default BR2_LINUX_KERNEL_USE_DEFCONFIG
>
> config BR2_LINUX_KERNEL_USE_DEFCONFIG
> - bool "Using a defconfig"
> + bool "Using an in-tree defconfig file"
>
> config BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG
> - bool "Using a custom config file"
> + bool "Using a custom (def)config file"
>
> endchoice
>
> @@ -161,6 +161,9 @@ config BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE
> help
> Path to the kernel configuration file
>
> + Note: this can be a defconfig file or a complete .config file,
> + which can later be saved back with make linux-update-(def)config.
> +
> #
> # Binary format
> #
> --
> 2.3.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] linux: clarify kernel configuration entries
2015-03-05 17:55 [Buildroot] [PATCH] linux: clarify kernel configuration entries Vivien Didelot
2015-03-05 18:30 ` Yann E. MORIN
@ 2015-03-05 20:18 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-03-05 20:18 UTC (permalink / raw)
To: buildroot
Dear Vivien Didelot,
On Thu, 5 Mar 2015 12:55:12 -0500, Vivien Didelot wrote:
> Since BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE can either be a complete
> .config file or a defconfig file, it can be confusing to the user
> whether to choose BR2_LINUX_KERNEL_USE_DEFCONFIG or
> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG.
>
> To avoid that confusion, clarify Kconfig entry messages for in-tree
> defconfig and custom (def)config files.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-05 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 17:55 [Buildroot] [PATCH] linux: clarify kernel configuration entries Vivien Didelot
2015-03-05 18:30 ` Yann E. MORIN
2015-03-05 20:18 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox