Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] wine: Add dependency check for ALSA
@ 2015-03-05 19:38 André Hentschel
  2015-03-05 20:11 ` Ryan Barnett
  2015-03-05 20:19 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: André Hentschel @ 2015-03-05 19:38 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
---

This fixes the problem from http://autobuild.buildroot.org/results/018/018391c5e70d33bc0b5745ad7a2a273efa9be0d7/

 package/wine/wine.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/wine/wine.mk b/package/wine/wine.mk
index 926ac99..47c7259 100644
--- a/package/wine/wine.mk
+++ b/package/wine/wine.mk
@@ -29,6 +29,13 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL),y)
 WINE_CONF_OPTS += TARGETFLAGS="-b $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PREFIX))"
 endif
 
+ifeq ($(BR2_PACKAGE_ALSA_LIB)$(BR2_PACKAGE_ALSA_LIB_SEQ),yy)
+WINE_CONF_OPTS += --with-alsa
+WINE_DEPENDENCIES += alsa-lib
+else
+WINE_CONF_OPTS += --without-alsa
+endif
+
 ifeq ($(BR2_PACKAGE_CUPS),y)
 WINE_CONF_OPTS += --with-cups
 WINE_DEPENDENCIES += cups

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] wine: Add dependency check for ALSA
  2015-03-05 19:38 [Buildroot] [PATCH] wine: Add dependency check for ALSA André Hentschel
@ 2015-03-05 20:11 ` Ryan Barnett
  2015-03-05 20:19 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Ryan Barnett @ 2015-03-05 20:11 UTC (permalink / raw)
  To: buildroot

Andr? ,

On Thu, Mar 5, 2015 at 1:38 PM, Andr? Hentschel <nerv@dawncrow.de> wrote:

You should move the fixes line above your signed off line as follows
otherwise it will not be preserved in the commit message:

Fixes:
  http://autobuild.buildroot.org/results/018/018391c5e70d33bc0b5745ad7a2a273efa9be0d7/

> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> ---
>
> This fixes the problem from http://autobuild.buildroot.org/results/018/018391c5e70d33bc0b5745ad7a2a273efa9be0d7/
>
>  package/wine/wine.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Thanks,
-Ryan

-- 
Ryan Barnett / Sr Software Engineer
Airborne Information Systems / Security Systems and Software
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
ryan.barnett at rockwellcollins.com
www.rockwellcollins.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] wine: Add dependency check for ALSA
  2015-03-05 19:38 [Buildroot] [PATCH] wine: Add dependency check for ALSA André Hentschel
  2015-03-05 20:11 ` Ryan Barnett
@ 2015-03-05 20:19 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-03-05 20:19 UTC (permalink / raw)
  To: buildroot

Dear Andr? Hentschel,

On Thu, 05 Mar 2015 20:38:40 +0100, Andr? Hentschel wrote:
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

Thanks, applied, after moving the reference to the autobuilder failure
within the commit log itself, as suggested by Ryan.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-05 20:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-05 19:38 [Buildroot] [PATCH] wine: Add dependency check for ALSA André Hentschel
2015-03-05 20:11 ` Ryan Barnett
2015-03-05 20:19 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox