From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0
Date: Fri, 6 Mar 2015 09:40:08 +0100 [thread overview]
Message-ID: <20150306094008.7baf8c91@free-electrons.com> (raw)
In-Reply-To: <54F8F0AC.8030707@zacarias.com.ar>
Dear Gustavo Zacarias,
On Thu, 05 Mar 2015 21:11:24 -0300, Gustavo Zacarias wrote:
> > This cleanup of the indentation is definitely good, but has nothing to
> > do with the bump to 4.2.0. It should be part of a separate patch.
>
> Well, it's pointless IMHO to split it, since some options changed and
> it's a major bump, does it really make sense?
> I won't make a badly-indented 4.2.x package file to fix it later, it
> would be pointless. It'll give me one more commit that doesn't do
> anything useful.
> And "fixing" 4.1.x just to just stomp on it later with the bump would
> make no sense either, same case, many changes.
I'm sorry, but I don't buy this. Separating logical changes is
something we ask to all contributors. And the specific chunk I pointed
at does not change at *all* when doing the 4.1 -> 4.2 bump. And even if
some parts of it are changed by the 4.1 -> 4.2 bump, that's OK.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-06 8:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 20:44 [Buildroot] [PATCH 1/2] samba: deprecate package due to EOL Gustavo Zacarias
2015-03-05 20:44 ` [Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0 Gustavo Zacarias
2015-03-05 22:29 ` Thomas Petazzoni
2015-03-06 0:11 ` Gustavo Zacarias
2015-03-06 8:40 ` Thomas Petazzoni [this message]
2015-03-06 9:04 ` Gustavo Zacarias
2015-03-06 9:26 ` Thomas Petazzoni
2015-03-06 9:34 ` Gustavo Zacarias
2015-03-06 9:40 ` Thomas Petazzoni
2015-03-06 10:32 ` Gustavo Zacarias
2015-03-06 11:35 ` Thomas Petazzoni
2015-03-06 13:13 ` Gustavo Zacarias
2015-03-10 22:04 ` Peter Korsgaard
2015-03-10 21:53 ` Peter Korsgaard
2015-03-10 21:56 ` Thomas Petazzoni
2015-03-10 22:08 ` Peter Korsgaard
2015-03-10 21:49 ` Peter Korsgaard
2015-03-10 21:35 ` Peter Korsgaard
2015-03-06 10:03 ` Thomas Petazzoni
2015-04-09 10:33 ` Bernd Kuhls
2015-04-09 10:49 ` Gustavo Zacarias
2015-04-09 20:20 ` Waldemar Brodkorb
2015-04-10 12:16 ` Gustavo Zacarias
2015-04-16 19:55 ` Waldemar Brodkorb
2015-04-16 19:58 ` Gustavo Zacarias
2015-04-16 20:09 ` Waldemar Brodkorb
2015-04-16 20:13 ` Gustavo Zacarias
2015-04-16 20:19 ` Bernd Kuhls
2015-03-05 21:53 ` [Buildroot] [PATCH 1/2] samba: deprecate package due to EOL Arnout Vandecappelle
2015-03-05 22:06 ` Thomas Petazzoni
2015-03-05 22:10 ` Arnout Vandecappelle
2015-03-05 22:23 ` Thomas Petazzoni
2015-03-06 0:11 ` Gustavo Zacarias
2015-03-06 8:19 ` Thomas Petazzoni
2015-03-06 9:07 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306094008.7baf8c91@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox