From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0
Date: Fri, 06 Mar 2015 06:34:59 -0300 [thread overview]
Message-ID: <54F974C3.2020509@zacarias.com.ar> (raw)
In-Reply-To: <20150306102632.20dff6f7@free-electrons.com>
On 03/06/2015 06:26 AM, Thomas Petazzoni wrote:
>> Because the workload and noise committing will go up higher if that's
>> the choice.
>> And how does a package style fix differ from renaming patches that's
>> another style fix?
>
> I'd say readability. Renaming patches is clearly separated from .mk
> changes. In the case of your Samba 4.2 bump, the changes within the .mk
> file are mixed between bump-related changes, and indentation-related
> changes, and this is what bothers me.
It doesn't break any bisectability so what's the problem, you don't like
a patch that changes too many things at once?
Sorry to rehash an old thread but this kind of things don't motivate me
at all.
One thing is when you say "typo" which well, yes, it's a typo and it's
fine to correct it.
But this is just personal preference.
Regards.
next prev parent reply other threads:[~2015-03-06 9:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 20:44 [Buildroot] [PATCH 1/2] samba: deprecate package due to EOL Gustavo Zacarias
2015-03-05 20:44 ` [Buildroot] [PATCH 2/2] samba4: bump to version 4.2.0 Gustavo Zacarias
2015-03-05 22:29 ` Thomas Petazzoni
2015-03-06 0:11 ` Gustavo Zacarias
2015-03-06 8:40 ` Thomas Petazzoni
2015-03-06 9:04 ` Gustavo Zacarias
2015-03-06 9:26 ` Thomas Petazzoni
2015-03-06 9:34 ` Gustavo Zacarias [this message]
2015-03-06 9:40 ` Thomas Petazzoni
2015-03-06 10:32 ` Gustavo Zacarias
2015-03-06 11:35 ` Thomas Petazzoni
2015-03-06 13:13 ` Gustavo Zacarias
2015-03-10 22:04 ` Peter Korsgaard
2015-03-10 21:53 ` Peter Korsgaard
2015-03-10 21:56 ` Thomas Petazzoni
2015-03-10 22:08 ` Peter Korsgaard
2015-03-10 21:49 ` Peter Korsgaard
2015-03-10 21:35 ` Peter Korsgaard
2015-03-06 10:03 ` Thomas Petazzoni
2015-04-09 10:33 ` Bernd Kuhls
2015-04-09 10:49 ` Gustavo Zacarias
2015-04-09 20:20 ` Waldemar Brodkorb
2015-04-10 12:16 ` Gustavo Zacarias
2015-04-16 19:55 ` Waldemar Brodkorb
2015-04-16 19:58 ` Gustavo Zacarias
2015-04-16 20:09 ` Waldemar Brodkorb
2015-04-16 20:13 ` Gustavo Zacarias
2015-04-16 20:19 ` Bernd Kuhls
2015-03-05 21:53 ` [Buildroot] [PATCH 1/2] samba: deprecate package due to EOL Arnout Vandecappelle
2015-03-05 22:06 ` Thomas Petazzoni
2015-03-05 22:10 ` Arnout Vandecappelle
2015-03-05 22:23 ` Thomas Petazzoni
2015-03-06 0:11 ` Gustavo Zacarias
2015-03-06 8:19 ` Thomas Petazzoni
2015-03-06 9:07 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F974C3.2020509@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox