From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] tcl: rename BR2_PACKAGE_TCL_SHLIB_ONLY to be more consistent
Date: Fri, 6 Mar 2015 23:42:39 +0100 [thread overview]
Message-ID: <20150306234239.00ede664@free-electrons.com> (raw)
In-Reply-To: <1425681022-16612-2-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Fri, 6 Mar 2015 22:30:22 +0000, Vicente Olivert Riera wrote:
> The BR2_PACKAGE_TCL_SHLIB_ONLY is confusing because someone could think
> that only shared libraries would be installed. But, what actually does
> is removing the 'tclsh' binary, so better to reword it in order to be
> consistent with what actually does.
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/tcl/Config.in | 7 +++----
> package/tcl/tcl.mk | 2 +-
> 2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/package/tcl/Config.in b/package/tcl/Config.in
> index c3d0d87..996dc96 100644
> --- a/package/tcl/Config.in
> +++ b/package/tcl/Config.in
> @@ -25,12 +25,11 @@ config BR2_PACKAGE_TCL_DEL_ENCODINGS
>
> It saves approx. 1.6 Mb of space.
>
> -config BR2_PACKAGE_TCL_SHLIB_ONLY
> - bool "install only shared library"
> +config BR2_PACKAGE_TCL_REMOVE_TCLSH
Renaming options requires Config.in.legacy handling.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-06 22:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 22:30 [Buildroot] [PATCH 1/2] tcl: add support for static builds Vicente Olivert Riera
2015-03-06 22:30 ` [Buildroot] [PATCH 2/2] tcl: rename BR2_PACKAGE_TCL_SHLIB_ONLY to be more consistent Vicente Olivert Riera
2015-03-06 22:42 ` Thomas Petazzoni [this message]
2015-03-07 12:14 ` Vicente Olivert Riera
2015-03-07 10:11 ` [Buildroot] [PATCH 1/2] tcl: add support for static builds Thomas Petazzoni
2015-03-07 12:20 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306234239.00ede664@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox