From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] tcl: add support for static builds
Date: Sat, 7 Mar 2015 13:20:31 +0100 [thread overview]
Message-ID: <54FAED0F.8030804@imgtec.com> (raw)
In-Reply-To: <20150307111101.5c44cd2c@free-electrons.com>
Dear Thomas Petazzoni,
On 07/03/15 11:11, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Fri, 6 Mar 2015 22:30:21 +0000, Vicente Olivert Riera wrote:
>
>> +ifeq ($(BR2_STATIC_LIBS),y)
>> +# Do not build tclsh with dynamic loading support when building it
>> +# statically because it needs dlopen() and friends.
>> +TCL_CONF_OPTS += --disable-load
>> +HOST_TCL_CONF_OPTS += --disable-load
>> +# Also, build only the binaries and libraries and don't build the
>> +# 'packages' because they are shared objects which are intended to be
>> +# loaded dynamically.
>> +TCL_MAKE_OPTS = binaries libraries
>> +HOST_TCL_MAKE_OPTS = binaries libraries
>> +TCL_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install-binaries install-libraries
>> +TCL_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-binaries
>> +HOST_TCL_INSTALL_OPTS = DESTDIR=$(STAGING_DIR) install-binaries install-libraries
>> +endif
>
> BR2_STATIC_LIBS indicates that the *target* packages are built static
> only. Host packages continue to be built dynamically. So I believe all
> the HOST_* assignments in here are wrong.
Noted. I will fix that in the v2. Thanks!
--
Vincent
> Best regards,
>
> Thomas
>
prev parent reply other threads:[~2015-03-07 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 22:30 [Buildroot] [PATCH 1/2] tcl: add support for static builds Vicente Olivert Riera
2015-03-06 22:30 ` [Buildroot] [PATCH 2/2] tcl: rename BR2_PACKAGE_TCL_SHLIB_ONLY to be more consistent Vicente Olivert Riera
2015-03-06 22:42 ` Thomas Petazzoni
2015-03-07 12:14 ` Vicente Olivert Riera
2015-03-07 10:11 ` [Buildroot] [PATCH 1/2] tcl: add support for static builds Thomas Petazzoni
2015-03-07 12:20 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FAED0F.8030804@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox