[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Thomas De Schampheleire]

From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

When a filesystem image is xz-compressed, the XZ variable is used to refer
to the xz compression tool, but it is not necessarily available. Add a
proper dependency to fix that.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 fs/common.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/common.mk b/fs/common.mk
index 1d3926f..5d07f00 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -62,6 +62,7 @@ ROOTFS_$(2)_COMPRESS_EXT = .lzo
 ROOTFS_$(2)_COMPRESS_CMD = $$(LZOP) -9 -c
 endif
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_XZ),y)
+ROOTFS_$(2)_DEPENDENCIES += host-xz
 ROOTFS_$(2)_COMPRESS_EXT = .xz
 ROOTFS_$(2)_COMPRESS_CMD = xz -9 -C crc32 -c
 endif
-- 
1.8.5.1

[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
 > When a filesystem image is xz-compressed, the XZ variable is used to refer
 > to the xz compression tool, but it is not necessarily available. Add a
 > proper dependency to fix that.

Isn't that already handled by support/dependencies/check-host-xzcat.mk?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Thomas Petazzoni]

Dear Thomas De Schampheleire,

On Mon,  9 Mar 2015 10:34:13 +0100, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> When a filesystem image is xz-compressed, the XZ variable is used to refer
> to the xz compression tool, but it is not necessarily available. Add a
> proper dependency to fix that.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> ---
>  fs/common.mk | 1 +
>  1 file changed, 1 insertion(+)

I must say I don't quite understand why we have these options to
compress the resulting filesystem image.

But since we have them, I've applied your patch :)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Thomas De Schampheleire]

On March 9, 2015 2:16:28 PM CET, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com>
>writes:
>
> > From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>> When a filesystem image is xz-compressed, the XZ variable is used to
>refer
>> to the xz compression tool, but it is not necessarily available. Add
>a
> > proper dependency to fix that.
>
>Isn't that already handled by support/dependencies/check-host-xzcat.mk?

No, that file handles xzcat, the decompression tool, but in fs/ we use
 compression (xz).

[Buildroot] [PATCH] fs/common: build host-xz when xz compression is used

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

Hi,

 > On March 9, 2015 2:16:28 PM CET, Peter Korsgaard <peter@korsgaard.com> wrote:

>> Isn't that already handled by support/dependencies/check-host-xzcat.mk?

 > No, that file handles xzcat, the decompression tool, but in fs/ we use
 >  compression (xz).

While that is true, have you ever seen a distribution that provides one
but not the other? They come from the same upstream package.

And if there would be such an (odd) distribution somewhere we could
probably extend check-host-xzcat.mk to check for both with little effort.

-- 
Venlig hilsen,
Peter Korsgaard