Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc
Date: Mon, 9 Mar 2015 18:54:05 +0100	[thread overview]
Message-ID: <20150309185405.5f312f1b@free-electrons.com> (raw)
In-Reply-To: <1425918264-1912-1-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Mon,  9 Mar 2015 17:24:23 +0100, Samuel Martin wrote:
> This patch generates all *.pyc files from *.py located in
> <target>/usr/python*/site-packages, before stripping the rootfs.
> 
> This prevents modules from packages that do not compile the *.py
> files from disappearing.
> 
> Reported-by: Yegor Yefremov <yegorslists@googlemail.com>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
>  Makefile | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index af043a3..ec0b923 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -564,6 +564,11 @@ $(TARGETS_ROOTFS): target-finalize
>  
>  target-finalize: $(TARGETS)
>  	@$(call MESSAGE,"Finalizing target directory")
> +ifneq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),)
> +	PYTHONPATH="$(PYTHON_PATH)" \
> +		$(HOST_DIR)/usr/bin/python -c "import compileall; \
> +			compileall.compile_dir('$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages')"
> +endif

Why not, but then don't we want to do something in the Python package
infra, and in the Python 2/3 packages themselves to avoid spending time
biulding the .pyc files?

Also, using TARGET_FINALIZE_HOOKS would be nicer. But there is the
issue that the hook is the same between python and python3, so we
wouldn't know where to put it.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-03-09 17:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:24 [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc Samuel Martin
2015-03-09 16:24 ` [Buildroot] [PATCH 2/2] package/samba4: remove SAMBA4_BUILD_PYC_FILES hook Samuel Martin
2015-03-09 16:37 ` [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc Yegor Yefremov
2015-03-09 17:54 ` Thomas Petazzoni [this message]
2015-03-09 21:30   ` Samuel Martin
2015-03-09 21:44     ` Thomas Petazzoni
2015-03-09 21:42   ` Arnout Vandecappelle
2015-03-09 21:46     ` Thomas Petazzoni
2015-08-05  6:26       ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309185405.5f312f1b@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox