Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc
Date: Mon, 9 Mar 2015 22:44:49 +0100	[thread overview]
Message-ID: <20150309224449.730a5c99@free-electrons.com> (raw)
In-Reply-To: <CAHXCMMLDX9MXeR19NDkkDwenvJVH3pguVSxaRt6sROGQ+kNb_A@mail.gmail.com>

Dear Samuel Martin,

On Mon, 9 Mar 2015 22:30:02 +0100, Samuel Martin wrote:

> Indeed, it'd be better to avoid  wasting time building *.pyc during
> per-package build, though it does not seem really easy to do at first
> glance.
> Well, after hacking around, it is not that hard to do it! :-)
> I cleanup my hacks and will submit them.

Ok, cool.

> The hook is simple enough to be moved in pkg-python.mk as a helper,
> then just being added to the PYTHON{,3}_TARGET_FINALIZE_HOOKS.

Indeed.

> However, if we decide to not go using a global TARGET_FINALIZE_HOOKS,
> but per-package target-install hook, the helper can be easily added to
> the packages that need it; the biggest remaining task being
> identifying and updating all packages not using the pkg-python infra
> but providing a python module.

Well, as it is currently implemented, the hook byte-compiles *all* .py
files. So if you call this hook multiple times, you're going to
byte-compile all .py files multiple times. Doesn't seem like the most
efficient thing to do.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-03-09 21:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:24 [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc Samuel Martin
2015-03-09 16:24 ` [Buildroot] [PATCH 2/2] package/samba4: remove SAMBA4_BUILD_PYC_FILES hook Samuel Martin
2015-03-09 16:37 ` [Buildroot] [PATCH 1/2] target-finalize: generate all *.pyc Yegor Yefremov
2015-03-09 17:54 ` Thomas Petazzoni
2015-03-09 21:30   ` Samuel Martin
2015-03-09 21:44     ` Thomas Petazzoni [this message]
2015-03-09 21:42   ` Arnout Vandecappelle
2015-03-09 21:46     ` Thomas Petazzoni
2015-08-05  6:26       ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309224449.730a5c99@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox