[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Matt Weber]

Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
 package/bash/Config.in | 10 ++++++++++
 package/bash/bash.mk   |  9 +++++++++
 2 files changed, 19 insertions(+)

diff --git a/package/bash/Config.in b/package/bash/Config.in
index 2f823dc..171d2ad 100644
--- a/package/bash/Config.in
+++ b/package/bash/Config.in
@@ -8,3 +8,13 @@ config BR2_PACKAGE_BASH
 	  The standard GNU Bourne again shell.
 
 	  http://tiswww.case.edu/php/chet/bash/bashtop.html
+
+if BR2_PACKAGE_BASH
+
+config BR2_PACKAGE_BASH_NO_LOCALE
+	bool "disable locale support"
+	help
+	  Disable locale support for cases where toolchain has it
+	  but target isn't setup to use it.
+
+endif
diff --git a/package/bash/bash.mk b/package/bash/bash.mk
index 9865e19..67a423e 100644
--- a/package/bash/bash.mk
+++ b/package/bash/bash.mk
@@ -21,6 +21,15 @@ BASH_CONF_ENV += \
 	bash_cv_func_sigsetjmp=present \
 	bash_cv_printf_a_format=yes
 
+
+ifeq ($(BR2_PACKAGE_BASH_NO_LOCALE),y)
+BASH_CONF_ENV += \
+	ac_cv_header_locale_h=no \
+	ac_cv_func_locale_charset=no \
+	ac_cv_func_setlocale=no \
+	ac_cv_func_localeconv=no
+endif
+
 # Parallel build sometimes fails because some of the generator tools
 # are built twice (i.e. while executing).
 BASH_MAKE = $(MAKE1)
-- 
1.9.1

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Thomas Petazzoni]

Dear Matt Weber,

On Mon,  9 Mar 2015 16:13:15 -0500, Matt Weber wrote:

> +if BR2_PACKAGE_BASH
> +
> +config BR2_PACKAGE_BASH_NO_LOCALE
> +	bool "disable locale support"
> +	help
> +	  Disable locale support for cases where toolchain has it
> +	  but target isn't setup to use it.
> +
> +endif

To be honest, I'm not sure we want to support such cases. What does it
mean for the target to not be setup to use locales?

What is the opinion of other Buildroot developers?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Matthew Weber]

Thomas, all.

On Mon, Mar 9, 2015 at 4:42 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Matt Weber,
>
> On Mon,  9 Mar 2015 16:13:15 -0500, Matt Weber wrote:
>
>> +if BR2_PACKAGE_BASH
>> +
>> +config BR2_PACKAGE_BASH_NO_LOCALE
>> +     bool "disable locale support"
>> +     help
>> +       Disable locale support for cases where toolchain has it
>> +       but target isn't setup to use it.
>> +
>> +endif
>
> To be honest, I'm not sure we want to support such cases. What does it
> mean for the target to not be setup to use locales?

I should probably clarify, this disabled the runtime check of locale
that bash did everytime a shell was invoked.  All packages where still
built with locale support.  Busybox ash didn't perform this check so
we never noticed it until we switched to bash.  (I believe, will have
to double check)Bash is running  setlocale after checking for a env
variable LC_xxxxx before the shell starts.  Currently we don't have
our env setup to by default have LC_xxxxx set.  Instead we  set the
LC_xxxxx as part of the service/app start rcS script. (There maybe
better way's of handling this I'm sure).

Thanks,
Matt

>
> What is the opinion of other Buildroot developers?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Peter Korsgaard]

>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:

 > Thomas, all.
 > On Mon, Mar 9, 2015 at 4:42 PM, Thomas Petazzoni
 > <thomas.petazzoni@free-electrons.com> wrote:
 >> Dear Matt Weber,
 >> 
 >> On Mon,  9 Mar 2015 16:13:15 -0500, Matt Weber wrote:
 >> 
 >>> +if BR2_PACKAGE_BASH
 >>> +
 >>> +config BR2_PACKAGE_BASH_NO_LOCALE
 >>> +     bool "disable locale support"
 >>> +     help
 >>> +       Disable locale support for cases where toolchain has it
 >>> +       but target isn't setup to use it.
 >>> +
 >>> +endif
 >> 
 >> To be honest, I'm not sure we want to support such cases. What does it
 >> mean for the target to not be setup to use locales?

 > I should probably clarify, this disabled the runtime check of locale
 > that bash did everytime a shell was invoked.  All packages where still
 > built with locale support.  Busybox ash didn't perform this check so
 > we never noticed it until we switched to bash.  (I believe, will have
 > to double check)Bash is running  setlocale after checking for a env
 > variable LC_xxxxx before the shell starts.  Currently we don't have
 > our env setup to by default have LC_xxxxx set.  Instead we  set the
 > LC_xxxxx as part of the service/app start rcS script. (There maybe
 > better way's of handling this I'm sure).

So what is the impact exactly of having/not having this option?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Matthew Weber]

All,

On Tue, Mar 10, 2015 at 2:52 PM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Matthew" == Matthew Weber <matthew.weber@rockwellcollins.com> writes:
>
>  > Thomas, all.
>  > On Mon, Mar 9, 2015 at 4:42 PM, Thomas Petazzoni
>  > <thomas.petazzoni@free-electrons.com> wrote:
>  >> Dear Matt Weber,
>  >>
>  >> On Mon,  9 Mar 2015 16:13:15 -0500, Matt Weber wrote:
>  >>
>  >>> +if BR2_PACKAGE_BASH
>  >>> +
>  >>> +config BR2_PACKAGE_BASH_NO_LOCALE
>  >>> +     bool "disable locale support"
>  >>> +     help
>  >>> +       Disable locale support for cases where toolchain has it
>  >>> +       but target isn't setup to use it.
>  >>> +
>  >>> +endif
>  >>
>  >> To be honest, I'm not sure we want to support such cases. What does it
>  >> mean for the target to not be setup to use locales?
>
>  > I should probably clarify, this disabled the runtime check of locale
>  > that bash did everytime a shell was invoked.  All packages where still
>  > built with locale support.  Busybox ash didn't perform this check so
>  > we never noticed it until we switched to bash.  (I believe, will have
>  > to double check)Bash is running  setlocale after checking for a env
>  > variable LC_xxxxx before the shell starts.  Currently we don't have
>  > our env setup to by default have LC_xxxxx set.  Instead we  set the
>  > LC_xxxxx as part of the service/app start rcS script. (There maybe
>  > better way's of handling this I'm sure).
>
> So what is the impact exactly of having/not having this option?

I'd like to drop this patch at this point.  I think I figured out what
was happening and resolved it through additional busybox options being
enabled.  Pending more testing I might submit a follow on if it is
really required.  Should I transition it to rejected and archive it?

-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.

[Buildroot] [PATCH 1/1] bash: added option to disable locale support

[Thomas Petazzoni]

Dear Matthew Weber,

On Mon, 11 May 2015 22:17:26 -0500, Matthew Weber wrote:

> > So what is the impact exactly of having/not having this option?
> 
> I'd like to drop this patch at this point.  I think I figured out what
> was happening and resolved it through additional busybox options being
> enabled.  Pending more testing I might submit a follow on if it is
> really required.  Should I transition it to rejected and archive it?

Yes, you can manage all your patches in patchwork by yourself, as long
as you have a patchwork account matching the e-mail address with which
you're sending the patches. So feel free to update the status of your
patches as needed, this is actually very helpful for us.

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com